[GitHub] [iceberg] pvary commented on a change in pull request #2449: Hive: Capitalize write format value when creating writer

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2449:
URL: https://github.com/apache/iceberg/pull/2449#discussion_r610628235



##########
File path: mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerWithEngine.java
##########
@@ -662,6 +663,27 @@ public void testMultiTableInsert() throws IOException {
     HiveIcebergTestUtils.validateData(target2, target2Records, 1);
   }
 
+  @Test
+  public void testWriteWithDefaultWriteFormat() {
+    Assume.assumeTrue("Tez write is not implemented yet", executionEngine.equals("mr"));

Review comment:
       Do we need to run this for every catalog / fileFormat?
   Maybe we do not want to create a test class just for this, but at least skip the unnecessary tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org