You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/30 07:10:06 UTC

[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #11700: [Feature][Style] Configure Spotless to format YAML file in DS

SbloodyS commented on code in PR #11700:
URL: https://github.com/apache/dolphinscheduler/pull/11700#discussion_r958087256


##########
pom.xml:
##########
@@ -684,6 +684,16 @@
                         </includes>
                         <flexmark />
                     </markdown>
+                    <formats>
+                        <format>
+                            <includes>
+                                <include>**/*.yaml</include>
+                            </includes>
+                            <prettier>
+                                <prettierVersion>2.0.5</prettierVersion>

Review Comment:
   Can you provide several different types of yaml files to see the effect after formatting?
   
   As far as I know, we have many different types of yaml files. Such as `docker-compose yaml` and `spring application yaml`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org