You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by abellina <gi...@git.apache.org> on 2018/09/12 21:14:54 UTC

[GitHub] spark pull request #21809: [SPARK-24851][UI] Map a Stage ID to it's Associat...

Github user abellina commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21809#discussion_r217106065
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/jobs/StagePage.scala ---
    @@ -182,6 +197,15 @@ private[ui] class StagePage(parent: StagesTab, store: AppStatusStore) extends We
                   {Utils.bytesToString(stageData.diskBytesSpilled)}
                 </li>
               }}
    +          {if (!stageJobIds.isEmpty) {
    --- End diff --
    
    This could throw an NPE if `stageDataTuple` is `None`
    
    ```
    scala> var x:Seq[Int] = null
    x: Seq[Int] = null
    
    scala> x.isEmpty
    java.lang.NullPointerException
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org