You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/05/26 11:43:31 UTC
[GitHub] [maven-resolver] cstamas opened a new pull request, #292: Make code self explanatory
cstamas opened a new pull request, #292:
URL: https://github.com/apache/maven-resolver/pull/292
This PR does NOT make any semantic change, it literally just makes existing code self-explanatory.
Just to avoid that in 2 years another of us looks at this and become puzzled what in case of "last modified" means 0L, and why a method returns 1L, etc.
This class is fully covered with self explanatory UTs as well.
No JIRA created either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #292: Make code self explanatory
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #292:
URL: https://github.com/apache/maven-resolver/pull/292#issuecomment-1564279727
Again, I did not change anything. But spent so much time figure out the logic behind all this and "why 1???", so intent is really just to add constants that are "decorated" with javadoc explaining their meaning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-resolver] cstamas merged pull request #292: Make code self explanatory
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #292:
URL: https://github.com/apache/maven-resolver/pull/292
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org