[GitHub] [trafficcontrol] rob05c edited a comment on issue #4293: tc package: Split enum into its own package

[GitBox <gi...@apache.org>]

rob05c edited a comment on issue #4293: tc package: Split enum into its own package
URL: https://github.com/apache/trafficcontrol/pull/4293#issuecomment-574356841
 
 
   Personally, I'd really prefer we kept this stuff in `tc`. It's used so much in so many places, it makes the code much terser to have e.g. `tc.DeliveryServiceName` everywhere than `enum.DeliveryServiceName`. The brevity was a big part of naming it `tc`.
   
   I think it's also good to keep as much as we can in a library that indicates it's Traffic Control, so it's easy for people not intricately familiar with the code to immediately see it's ours and not a third-party. And we could do something like `tcenum.DeliveryServiceName`, but that's even more verbose.
   
   > enum.go is 727 lines
   
   I wouldn't object to breaking that file into multiple files, though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services