You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Emond Papegaaij (JIRA)" <ji...@apache.org> on 2011/01/25 14:32:47 UTC
[jira] Created: (WICKET-3383) Strange writeObjectMethodCache in
SerializableChecker
Strange writeObjectMethodCache in SerializableChecker
-----------------------------------------------------
Key: WICKET-3383
URL: https://issues.apache.org/jira/browse/WICKET-3383
Project: Wicket
Issue Type: Bug
Components: wicket
Affects Versions: 1.4.15
Reporter: Emond Papegaaij
Priority: Minor
At Topicus, we maintain a customized SerializableChecker with some additional
checks. I was trying to fix some generics-warnings and noticed a strange thing
about the writeObjectMethodCache. This variable is used in only 4 places, one
is a clear, one a get and 2 are puts. Both puts take a Boolean as value, but
the get checks if the value returned is a Method, which obviously can never
happen. I think the 'writeObjectMethod' should be put into the map after line
473:
writeObjectMethod = cls.getDeclaredMethod("writeObject",
new Class[] { java.io.ObjectOutputStream.class });
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3383) Strange writeObjectMethodCache in
SerializableChecker
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3383.
-------------------------------------
Resolution: Fixed
Fix Version/s: 1.4.16
Assignee: Martin Grigorov
Fixed with r1070214 in 1.4.x.
1.5.x handles this a bit different and no fix is needed there.
> Strange writeObjectMethodCache in SerializableChecker
> -----------------------------------------------------
>
> Key: WICKET-3383
> URL: https://issues.apache.org/jira/browse/WICKET-3383
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.15
> Reporter: Emond Papegaaij
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.4.16
>
> Attachments: wicket-3383.diff
>
>
> At Topicus, we maintain a customized SerializableChecker with some additional
> checks. I was trying to fix some generics-warnings and noticed a strange thing
> about the writeObjectMethodCache. This variable is used in only 4 places, one
> is a clear, one a get and 2 are puts. Both puts take a Boolean as value, but
> the get checks if the value returned is a Method, which obviously can never
> happen. I think the 'writeObjectMethod' should be put into the map after line
> 473:
> writeObjectMethod = cls.getDeclaredMethod("writeObject",
> new Class[] { java.io.ObjectOutputStream.class });
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WICKET-3383) Strange writeObjectMethodCache in
SerializableChecker
Posted by "Emond Papegaaij (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emond Papegaaij updated WICKET-3383:
------------------------------------
Attachment: wicket-3383.diff
> Strange writeObjectMethodCache in SerializableChecker
> -----------------------------------------------------
>
> Key: WICKET-3383
> URL: https://issues.apache.org/jira/browse/WICKET-3383
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.15
> Reporter: Emond Papegaaij
> Priority: Minor
> Attachments: wicket-3383.diff
>
>
> At Topicus, we maintain a customized SerializableChecker with some additional
> checks. I was trying to fix some generics-warnings and noticed a strange thing
> about the writeObjectMethodCache. This variable is used in only 4 places, one
> is a clear, one a get and 2 are puts. Both puts take a Boolean as value, but
> the get checks if the value returned is a Method, which obviously can never
> happen. I think the 'writeObjectMethod' should be put into the map after line
> 473:
> writeObjectMethod = cls.getDeclaredMethod("writeObject",
> new Class[] { java.io.ObjectOutputStream.class });
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3383) Strange writeObjectMethodCache in
SerializableChecker
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994078#comment-12994078 ]
Hudson commented on WICKET-3383:
--------------------------------
Integrated in Apache Wicket 1.4.x #436 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.4.x/436/])
WICKET-3383 Strange writeObjectMethodCache in SerializableChecker
Add the found writeObject() method in the cache.
> Strange writeObjectMethodCache in SerializableChecker
> -----------------------------------------------------
>
> Key: WICKET-3383
> URL: https://issues.apache.org/jira/browse/WICKET-3383
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.4.15
> Reporter: Emond Papegaaij
> Assignee: Martin Grigorov
> Priority: Minor
> Fix For: 1.4.16
>
> Attachments: wicket-3383.diff
>
>
> At Topicus, we maintain a customized SerializableChecker with some additional
> checks. I was trying to fix some generics-warnings and noticed a strange thing
> about the writeObjectMethodCache. This variable is used in only 4 places, one
> is a clear, one a get and 2 are puts. Both puts take a Boolean as value, but
> the get checks if the value returned is a Method, which obviously can never
> happen. I think the 'writeObjectMethod' should be put into the map after line
> 473:
> writeObjectMethod = cls.getDeclaredMethod("writeObject",
> new Class[] { java.io.ObjectOutputStream.class });
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira