You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/27 10:33:42 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #39242: [SPARK-41649][CONNECT][FOLLOW-UP] Change `PySparkWindowSpec.Window` to `PySparkWindow`

HyukjinKwon opened a new pull request, #39242:
URL: https://github.com/apache/spark/pull/39242

   ### What changes were proposed in this pull request?
   
   This PR is a followup of https://github.com/apache/spark/pull/39238 that fixes the mistake on the deduplication of docs in Window.
   
   ### Why are the changes needed?
   
   To fix the broken build.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No.
   
   ### How was this patch tested?
   
   Manually tested with `./dev/lint-python`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] bjornjorgensen commented on pull request #39242: [SPARK-41649][CONNECT][FOLLOW-UP] Change `PySparkWindowSpec.Window` to `PySparkWindow`

Posted by GitBox <gi...@apache.org>.
bjornjorgensen commented on PR #39242:
URL: https://github.com/apache/spark/pull/39242#issuecomment-1365849228

   @HyukjinKwon Thank you :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #39242: [SPARK-41649][CONNECT][FOLLOW-UP] Change `PySparkWindowSpec.Window` to `PySparkWindow`

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39242:
URL: https://github.com/apache/spark/pull/39242#issuecomment-1365795311

   I manually verified this. I am merging this to unblock other PRs.
   
   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #39242: [SPARK-41649][CONNECT][FOLLOW-UP] Change `PySparkWindowSpec.Window` to `PySparkWindow`

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39242: [SPARK-41649][CONNECT][FOLLOW-UP] Change `PySparkWindowSpec.Window` to `PySparkWindow`
URL: https://github.com/apache/spark/pull/39242


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org