You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/22 02:15:39 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #32252: [SPARK-35094][SQL]Spark from_json(JsonToStruct) function return wrong value in permissive mode

HyukjinKwon commented on a change in pull request #32252:
URL: https://github.com/apache/spark/pull/32252#discussion_r618032925



##########
File path: sql/core/src/test/scala/org/apache/spark/sql/JsonFunctionsSuite.scala
##########
@@ -840,4 +841,29 @@ class JsonFunctionsSuite extends QueryTest with SharedSparkSession {
       }
     }
   }
+
+  test("SPARK-35094: Spark from_json(JsonToStruct) function return wrong value " +

Review comment:
       @Peng-Lei this test passes without your fix. Can you show the reproducible codes with before/after results?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org