You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ch...@apache.org on 2019/05/15 11:49:45 UTC
[flink] branch master updated (f8f98ef -> c10e18c)
This is an automated email from the ASF dual-hosted git repository.
chesnay pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git.
from f8f98ef [FLINK-12463][tests] Deduplicate empty .out log file checks
new 8e5d34d [hotfix][tests] Don't set process variable to null
new 17a7fca [hotfix][tests] Removed unused field
new 294915e [FLINK-12111][tests] Wait until TM has shut down
new c10e18c [FLINK-12111][tests] Allow multiple restarts
The 4 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java | 3 +--
.../test/recovery/TaskManagerProcessFailureBatchRecoveryITCase.java | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
[flink] 02/04: [hotfix][tests] Removed unused field
Posted by ch...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
chesnay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 17a7fca2a593533706b78edb0612033b1fa37575
Author: Chesnay Schepler <ch...@apache.org>
AuthorDate: Fri May 10 13:43:19 2019 +0200
[hotfix][tests] Removed unused field
---
.../test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java | 1 -
1 file changed, 1 deletion(-)
diff --git a/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java b/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
index 897fab1..d72507d 100644
--- a/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
+++ b/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
@@ -70,7 +70,6 @@ public abstract class AbstractTaskManagerProcessFailureRecoveryTest extends Test
protected static final String READY_MARKER_FILE_PREFIX = "ready_";
protected static final String PROCEED_MARKER_FILE = "proceed";
- protected static final String FINISH_MARKER_FILE_PREFIX = "finish_";
protected static final int PARALLELISM = 4;
[flink] 01/04: [hotfix][tests] Don't set process variable to null
Posted by ch...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
chesnay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 8e5d34d30a47cfbc3fd2515dc1afca1b989eb86f
Author: Chesnay Schepler <ch...@apache.org>
AuthorDate: Thu May 9 21:38:23 2019 +0200
[hotfix][tests] Don't set process variable to null
Prevents the output from being written in case of failure
---
.../test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java | 1 -
1 file changed, 1 deletion(-)
diff --git a/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java b/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
index 9dd4542..897fab1 100644
--- a/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
+++ b/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
@@ -172,7 +172,6 @@ public abstract class AbstractTaskManagerProcessFailureRecoveryTest extends Test
// kill one of the previous TaskManagers, triggering a failure and recovery
taskManagerProcess1.destroy();
- taskManagerProcess1 = null;
// we create the marker file which signals the program functions tasks that they can complete
touchFile(new File(coordinateTempDir, PROCEED_MARKER_FILE));
[flink] 04/04: [FLINK-12111][tests] Allow multiple restarts
Posted by ch...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
chesnay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit c10e18c0eb497588f0f2e27590a6f6c6a9d23563
Author: Chesnay Schepler <ch...@apache.org>
AuthorDate: Fri May 10 13:50:35 2019 +0200
[FLINK-12111][tests] Allow multiple restarts
For some reason this test could fail multiple times, instead of just once.
---
.../test/recovery/TaskManagerProcessFailureBatchRecoveryITCase.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/flink-tests/src/test/java/org/apache/flink/test/recovery/TaskManagerProcessFailureBatchRecoveryITCase.java b/flink-tests/src/test/java/org/apache/flink/test/recovery/TaskManagerProcessFailureBatchRecoveryITCase.java
index 473fb39..8577f9c 100644
--- a/flink-tests/src/test/java/org/apache/flink/test/recovery/TaskManagerProcessFailureBatchRecoveryITCase.java
+++ b/flink-tests/src/test/java/org/apache/flink/test/recovery/TaskManagerProcessFailureBatchRecoveryITCase.java
@@ -68,7 +68,7 @@ public class TaskManagerProcessFailureBatchRecoveryITCase extends AbstractTaskMa
ExecutionEnvironment env = ExecutionEnvironment.createRemoteEnvironment("localhost", 1337, configuration);
env.setParallelism(PARALLELISM);
- env.setRestartStrategy(RestartStrategies.fixedDelayRestart(1, 0L));
+ env.setRestartStrategy(RestartStrategies.fixedDelayRestart(2, 0L));
env.getConfig().setExecutionMode(executionMode);
env.getConfig().disableSysoutLogging();
[flink] 03/04: [FLINK-12111][tests] Wait until TM has shut down
Posted by ch...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
chesnay pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git
commit 294915e3e057886fef39528c5e1e72582ea1f4b8
Author: Chesnay Schepler <ch...@apache.org>
AuthorDate: Thu May 9 21:38:56 2019 +0200
[FLINK-12111][tests] Wait until TM has shut down
Prevents theoretical scenarios where the job can finish because the destroy() command takes a while to take effect.
---
.../test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java | 1 +
1 file changed, 1 insertion(+)
diff --git a/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java b/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
index d72507d..26840e7 100644
--- a/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
+++ b/flink-tests/src/test/java/org/apache/flink/test/recovery/AbstractTaskManagerProcessFailureRecoveryTest.java
@@ -171,6 +171,7 @@ public abstract class AbstractTaskManagerProcessFailureRecoveryTest extends Test
// kill one of the previous TaskManagers, triggering a failure and recovery
taskManagerProcess1.destroy();
+ waitForShutdown("TaskManager 1", taskManagerProcess1);
// we create the marker file which signals the program functions tasks that they can complete
touchFile(new File(coordinateTempDir, PROCEED_MARKER_FILE));