You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cayenne.apache.org by Ksenia Khailenko <xe...@tut.by> on 2011/06/20 19:35:31 UTC
Re: Gsoc project Patch
Hi there!
Eshan, I've applied your patch, and here're some comments:
1) cayenne-modeler-eclipse-plugin-II - let's choose some more meaningful
name for the project… Say, while it is experimental it can be
cayenne-modeler-eclipse-plugin-gsoc, and then when we will finish - just
cayenne-modeler-eclipse-plugin.. I don't like this "II" very much..
2) the root folder ("cayenne-modeler-eclipse-plugin-II" for now) should also
be included into the patch
3)pom.xml:
<bundle.symbolicName>cayenne-modeler-eclipse-plugin</bundle.symbolicName>
the symbolic name,artifactId, and the name of the project should be equal
to the enclosing folder - that's why it is so important to choose the good
name for it; and also, please format your code
4) plugin.patch is useless here - I've included this file into my project in
order not to forget some details from the old Cay-1392, but you don't need
it
5) as for dependencies - are sure we can't use some public repository? say,
this one:
http://www.mvnbrowser.com/artifacts-browse.html?groupId=org.eclipse ? as I
can see, there all the needed dependencies here
6) Add some picture for your editor - hard to find it in list
7) try to launch your plugin not as eclipse application, but as standalone
artifact - the simplest way, when you are copying your jar into plugins
eclipse folder and launching eclipse. this may be not so easy…
I've just tested the building and launching of the project, haven't looked
in depth, but in general, it looks nice, good work!:) I'm looking forward
for your further updates.
2011/6/17 Eshan Sudharaka <es...@gmail.com>
> Hi Ksenia,
> I have attached a patch of my current work and the zipped
> repository folder. Apply this patch and copy this folder in to
> /sandbox/cayenne-modeler-eclipse-plugin-II .
>
> I will create a list of used third party dependencies and attached it on
> jira issue with the patch file.
>
> --
> *~Thanks & Regards~*
> ***
> *
> P.A.Eshan Sudharaka
> Dept of Computer Science and Engineering
> University of Moratuwa
> Sri Lanka
> http://esudharaka.blogspot.com/
>
>
--
Regards, Ksenia Khailenko
Re: Gsoc project Patch
Posted by Eshan Sudharaka <es...@gmail.com>.
Thanks. Now it is ok. Now i am trying to build same manifest file using
maven felix plugin. otherwise i have to create plugin jar file manually by
putting third party libraries in to it and also when i add a new dependency
i need to update manifest file as well.
On Thu, Jun 23, 2011 at 12:50 PM, Andrey Razumovsky <
razumovsky.andrey@gmail.com> wrote:
> Export-Package is something your plugin exports for other plugins to use.
> Since you have just one plugin, there's no need for that header. I think
> you
> should link all third-party libraries that are not present in Eclipse
> (including Cayenne itself) just like you did before (using
> Bundle-Classpath), but link all Eclipse-contained bundles using
> Require-Bundle,
> like you do now. Also, we need to decide what versions of Eclipse we're
> supporting (I suggest Eclipse 3.5+) and maybe remove bundle-version
> attribute
>
> 2011/6/23 Eshan Sudharaka <es...@gmail.com>
>
> > ---------- Forwarded message ----------
> > From: Eshan Sudharaka <es...@gmail.com>
> > Date: Thu, Jun 23, 2011 at 12:36 PM
> > Subject: Re: Gsoc project Patch
> > To: dev@cayenne.apache.org
> >
> >
> > Manifest-Version: 1.0
> > Bundle-Name: Cayenne Modeler Plugin for Eclipse
> > Created-By: Apache Maven Bundle Plugin
> > Bundle-Vendor: Apache Cayenne
> > Build-Jdk: 1.6.0_11
> > Bundle-Version: 3.1.0.SNAPSHOT
> > Bnd-LastModified: 1308209524304
> > Bundle-Activator: org.apache.cayenne.Activator
> > Bundle-ManifestVersion: 2
> > Bundle-SymbolicName: cayenne-modeler-eclipse-plugin;singleton:=true
> > Require-Bundle:
> org.eclipse.ui;bundle-version="3.5.1";visibility:=reexport,
> > org.eclipse.ui.editors;bundle-version="3.5.0";visibility:=reexport,
> > org.eclipse.jface.text;bundle-version="3.5.1";visibility:=reexport,
> > org.eclipse.ui.ide;bundle-version="3.5.1";visibility:=reexport,
> > org.eclipse.ui.navigator;bundle-version="3.4.1";visibility:=reexport,
> > org.eclipse.ui.views;bundle-version="3.4.1",
> > org.eclipse.core.resources,
> > org.eclipse.ui.navigator.resources,
> > org.eclipse.ui.console;bundle-version="3.4.0",
> > org.eclipse.ltk.ui.refactoring;bundle-version="3.4.100",
> >
> >
> org.eclipse.ui.workbench.texteditor;bundle-version="3.5.1";visibility:=reexport,
> > org.eclipse.core.filesystem;bundle-version="1.2.1"
> > Export-Package: org.overture.ide.ui,
> > org.apache.cayenne.extentions.*,
> > org.apache.cayenne.cayenne-modeler,
> > org.apache.cayenne.unpublished.cayenne-project-unpublished,
> > org.apache.cayenne.unpublished.cayenne-jdk1.5-unpublished,
> > org.apache.cayenne.cayenne-tools,
> > org.apache.cayenne.unpublished.cayenne-wocompat-unpublished,
> > org.apache.cayenne.unpublished.cayenne-di-unpublished
> >
> >
> > I created manifest file manually (with out using felix plugin). But it
> > seems
> > that export packages are not loading. Do i need to put those packages in
> to
> > class path ? Since manifest contains errors i can not run this as a
> eclipse
> > application from eclipse IDE.
> >
> > I found a example pom file which uses felix and now trying to do it in
> this
> > way.
> >
> >
> >
> http://dirstudio-ldap-tooling.googlecode.com/svn/trunk/persistence-tooling/persistence-ui/pom.xml
> >
> >
> > On Wed, Jun 22, 2011 at 6:07 PM, Eshan Sudharaka <esudharaka@gmail.com
> > >wrote:
> >
> > > hi,
> > >
> > > On Wed, Jun 22, 2011 at 2:28 AM, Andrey Razumovsky <
> > > razumovsky.andrey@gmail.com> wrote:
> > >
> > >> Let me join the discussion..
> > >>
> > >> Eshan, the new dependencies are Eclipse dependencies, right? Are they
> > >> *default* Eclipse bundles?
> > >
> > >
> > > yes. They all are included in Eclipse bundles.
> > >
> > > If so, it is incorrect to provide them as Maven
> > >> dependencies, because they will be included in our bundle, while they
> > are
> > >> already in Eclipse. It's also incorrect to rely on certain Eclipse
> > bundles
> > >> (like workbench-3.6.1.M20100826-1330.jar), because plugin can be run
> in
> > >> different versions of Eclipse.
> > >>
> > >> I strongly advice you to add all Eclipse bundles via Require-Bundle
> > header
> > >> in manifest, and do not mess with Maven currently at all.. We can
> figure
> > >> out
> > >> how to build plugin using Maven later.
> > >> Currently manifest in your patch contains lots of unneeded stuff, it
> > >> should
> > >> be really little (most of Private-Package and Import-Package would go
> > >> away,
> > >> since Eclipse bundles would be attached via Require-Bundle). I'm
> pretty
> > >> sure
> > >> this is the only correct way.
> > >>
> > >> Good luck!
> > >>
> > > thanks for the help.
> > >
> > >>
> > >> 2011/6/21 Andrus Adamchik <an...@objectstyle.org>
> > >>
> > >> >
> > >> > On Jun 21, 2011, at 4:46 AM, Aristedes Maniatis wrote:
> > >> >
> > >> > > Isn't there a process for submitting artifacts to central?
> > >> >
> > >> > BTW, I tried to investigate that for core Cayenne dependencies still
> > >> > sitting on objectstyle.org. Central has a requirement to have a
> -src
> > >> and
> > >> > -javadoc artifacts submitted with the binary. This is a reasonable
> > >> > expectation for an open source project, but in practice it means a
> bit
> > >> of an
> > >> > effort to prepare a compatible distro.
> > >> >
> > >> > E.g. it took some time to even find the SVN for Hessian: svn://
> > >> > svn.caucho.com/resin/ And now I have to checkout everything to find
> > the
> > >> > sources for the right version of Hessian, the figure out how to
> build
> > >> it.
> > >> >
> > >> > But in case of Eclipse and friends that seems moot, as it is all in
> > >> their
> > >> > p2 repositories already. So it is a question of an appropriate
> > adapter,
> > >> like
> > >> > Tycho. (this is my assumption anyways; I am not an Eclipse dev of
> > >> course).
> > >> >
> > >> > Some more googling shows that Nexus Professional can proxy p2 repos
> (
> > >> > http://www.sonatype.com/books/nexus-book/reference/p2.html), which
> is
> > >> not
> > >> > very helpful either (we don't have a "canonical" install of Nexus
> > >> > Professional).
> > >> >
> > >> > Andrus
> > >> >
> > >> >
> > >>
> > >>
> > >> --
> > >> Andrey
> > >>
> > >
> > >
> > >
> > > --
> > > *~Thanks & Regards~*
> > > ***
> > > *
> > > P.A.Eshan Sudharaka
> > > Dept of Computer Science and Engineering
> > > University of Moratuwa
> > > Sri Lanka
> > > http://esudharaka.blogspot.com/
> > >
> > >
> >
> >
> > --
> > *~Thanks & Regards~*
> > ***
> > *
> > P.A.Eshan Sudharaka
> > Dept of Computer Science and Engineering
> > University of Moratuwa
> > Sri Lanka
> > http://esudharaka.blogspot.com/
> >
> >
> >
> >
> > --
> > *~Thanks & Regards~*
> > ***
> > *
> > P.A.Eshan Sudharaka
> > Dept of Computer Science and Engineering
> > University of Moratuwa
> > Sri Lanka
> > http://esudharaka.blogspot.com/
> >
>
>
>
> --
> Andrey
>
--
*~Thanks & Regards~*
***
*
P.A.Eshan Sudharaka
Dept of Computer Science and Engineering
University of Moratuwa
Sri Lanka
http://esudharaka.blogspot.com/
Re: Gsoc project Patch
Posted by Andrey Razumovsky <ra...@gmail.com>.
Export-Package is something your plugin exports for other plugins to use.
Since you have just one plugin, there's no need for that header. I think you
should link all third-party libraries that are not present in Eclipse
(including Cayenne itself) just like you did before (using
Bundle-Classpath), but link all Eclipse-contained bundles using Require-Bundle,
like you do now. Also, we need to decide what versions of Eclipse we're
supporting (I suggest Eclipse 3.5+) and maybe remove bundle-version
attribute
2011/6/23 Eshan Sudharaka <es...@gmail.com>
> ---------- Forwarded message ----------
> From: Eshan Sudharaka <es...@gmail.com>
> Date: Thu, Jun 23, 2011 at 12:36 PM
> Subject: Re: Gsoc project Patch
> To: dev@cayenne.apache.org
>
>
> Manifest-Version: 1.0
> Bundle-Name: Cayenne Modeler Plugin for Eclipse
> Created-By: Apache Maven Bundle Plugin
> Bundle-Vendor: Apache Cayenne
> Build-Jdk: 1.6.0_11
> Bundle-Version: 3.1.0.SNAPSHOT
> Bnd-LastModified: 1308209524304
> Bundle-Activator: org.apache.cayenne.Activator
> Bundle-ManifestVersion: 2
> Bundle-SymbolicName: cayenne-modeler-eclipse-plugin;singleton:=true
> Require-Bundle: org.eclipse.ui;bundle-version="3.5.1";visibility:=reexport,
> org.eclipse.ui.editors;bundle-version="3.5.0";visibility:=reexport,
> org.eclipse.jface.text;bundle-version="3.5.1";visibility:=reexport,
> org.eclipse.ui.ide;bundle-version="3.5.1";visibility:=reexport,
> org.eclipse.ui.navigator;bundle-version="3.4.1";visibility:=reexport,
> org.eclipse.ui.views;bundle-version="3.4.1",
> org.eclipse.core.resources,
> org.eclipse.ui.navigator.resources,
> org.eclipse.ui.console;bundle-version="3.4.0",
> org.eclipse.ltk.ui.refactoring;bundle-version="3.4.100",
>
> org.eclipse.ui.workbench.texteditor;bundle-version="3.5.1";visibility:=reexport,
> org.eclipse.core.filesystem;bundle-version="1.2.1"
> Export-Package: org.overture.ide.ui,
> org.apache.cayenne.extentions.*,
> org.apache.cayenne.cayenne-modeler,
> org.apache.cayenne.unpublished.cayenne-project-unpublished,
> org.apache.cayenne.unpublished.cayenne-jdk1.5-unpublished,
> org.apache.cayenne.cayenne-tools,
> org.apache.cayenne.unpublished.cayenne-wocompat-unpublished,
> org.apache.cayenne.unpublished.cayenne-di-unpublished
>
>
> I created manifest file manually (with out using felix plugin). But it
> seems
> that export packages are not loading. Do i need to put those packages in to
> class path ? Since manifest contains errors i can not run this as a eclipse
> application from eclipse IDE.
>
> I found a example pom file which uses felix and now trying to do it in this
> way.
>
>
> http://dirstudio-ldap-tooling.googlecode.com/svn/trunk/persistence-tooling/persistence-ui/pom.xml
>
>
> On Wed, Jun 22, 2011 at 6:07 PM, Eshan Sudharaka <esudharaka@gmail.com
> >wrote:
>
> > hi,
> >
> > On Wed, Jun 22, 2011 at 2:28 AM, Andrey Razumovsky <
> > razumovsky.andrey@gmail.com> wrote:
> >
> >> Let me join the discussion..
> >>
> >> Eshan, the new dependencies are Eclipse dependencies, right? Are they
> >> *default* Eclipse bundles?
> >
> >
> > yes. They all are included in Eclipse bundles.
> >
> > If so, it is incorrect to provide them as Maven
> >> dependencies, because they will be included in our bundle, while they
> are
> >> already in Eclipse. It's also incorrect to rely on certain Eclipse
> bundles
> >> (like workbench-3.6.1.M20100826-1330.jar), because plugin can be run in
> >> different versions of Eclipse.
> >>
> >> I strongly advice you to add all Eclipse bundles via Require-Bundle
> header
> >> in manifest, and do not mess with Maven currently at all.. We can figure
> >> out
> >> how to build plugin using Maven later.
> >> Currently manifest in your patch contains lots of unneeded stuff, it
> >> should
> >> be really little (most of Private-Package and Import-Package would go
> >> away,
> >> since Eclipse bundles would be attached via Require-Bundle). I'm pretty
> >> sure
> >> this is the only correct way.
> >>
> >> Good luck!
> >>
> > thanks for the help.
> >
> >>
> >> 2011/6/21 Andrus Adamchik <an...@objectstyle.org>
> >>
> >> >
> >> > On Jun 21, 2011, at 4:46 AM, Aristedes Maniatis wrote:
> >> >
> >> > > Isn't there a process for submitting artifacts to central?
> >> >
> >> > BTW, I tried to investigate that for core Cayenne dependencies still
> >> > sitting on objectstyle.org. Central has a requirement to have a -src
> >> and
> >> > -javadoc artifacts submitted with the binary. This is a reasonable
> >> > expectation for an open source project, but in practice it means a bit
> >> of an
> >> > effort to prepare a compatible distro.
> >> >
> >> > E.g. it took some time to even find the SVN for Hessian: svn://
> >> > svn.caucho.com/resin/ And now I have to checkout everything to find
> the
> >> > sources for the right version of Hessian, the figure out how to build
> >> it.
> >> >
> >> > But in case of Eclipse and friends that seems moot, as it is all in
> >> their
> >> > p2 repositories already. So it is a question of an appropriate
> adapter,
> >> like
> >> > Tycho. (this is my assumption anyways; I am not an Eclipse dev of
> >> course).
> >> >
> >> > Some more googling shows that Nexus Professional can proxy p2 repos (
> >> > http://www.sonatype.com/books/nexus-book/reference/p2.html), which is
> >> not
> >> > very helpful either (we don't have a "canonical" install of Nexus
> >> > Professional).
> >> >
> >> > Andrus
> >> >
> >> >
> >>
> >>
> >> --
> >> Andrey
> >>
> >
> >
> >
> > --
> > *~Thanks & Regards~*
> > ***
> > *
> > P.A.Eshan Sudharaka
> > Dept of Computer Science and Engineering
> > University of Moratuwa
> > Sri Lanka
> > http://esudharaka.blogspot.com/
> >
> >
>
>
> --
> *~Thanks & Regards~*
> ***
> *
> P.A.Eshan Sudharaka
> Dept of Computer Science and Engineering
> University of Moratuwa
> Sri Lanka
> http://esudharaka.blogspot.com/
>
>
>
>
> --
> *~Thanks & Regards~*
> ***
> *
> P.A.Eshan Sudharaka
> Dept of Computer Science and Engineering
> University of Moratuwa
> Sri Lanka
> http://esudharaka.blogspot.com/
>
--
Andrey
Fwd: Gsoc project Patch
Posted by Eshan Sudharaka <es...@gmail.com>.
---------- Forwarded message ----------
From: Eshan Sudharaka <es...@gmail.com>
Date: Thu, Jun 23, 2011 at 12:36 PM
Subject: Re: Gsoc project Patch
To: dev@cayenne.apache.org
Manifest-Version: 1.0
Bundle-Name: Cayenne Modeler Plugin for Eclipse
Created-By: Apache Maven Bundle Plugin
Bundle-Vendor: Apache Cayenne
Build-Jdk: 1.6.0_11
Bundle-Version: 3.1.0.SNAPSHOT
Bnd-LastModified: 1308209524304
Bundle-Activator: org.apache.cayenne.Activator
Bundle-ManifestVersion: 2
Bundle-SymbolicName: cayenne-modeler-eclipse-plugin;singleton:=true
Require-Bundle: org.eclipse.ui;bundle-version="3.5.1";visibility:=reexport,
org.eclipse.ui.editors;bundle-version="3.5.0";visibility:=reexport,
org.eclipse.jface.text;bundle-version="3.5.1";visibility:=reexport,
org.eclipse.ui.ide;bundle-version="3.5.1";visibility:=reexport,
org.eclipse.ui.navigator;bundle-version="3.4.1";visibility:=reexport,
org.eclipse.ui.views;bundle-version="3.4.1",
org.eclipse.core.resources,
org.eclipse.ui.navigator.resources,
org.eclipse.ui.console;bundle-version="3.4.0",
org.eclipse.ltk.ui.refactoring;bundle-version="3.4.100",
org.eclipse.ui.workbench.texteditor;bundle-version="3.5.1";visibility:=reexport,
org.eclipse.core.filesystem;bundle-version="1.2.1"
Export-Package: org.overture.ide.ui,
org.apache.cayenne.extentions.*,
org.apache.cayenne.cayenne-modeler,
org.apache.cayenne.unpublished.cayenne-project-unpublished,
org.apache.cayenne.unpublished.cayenne-jdk1.5-unpublished,
org.apache.cayenne.cayenne-tools,
org.apache.cayenne.unpublished.cayenne-wocompat-unpublished,
org.apache.cayenne.unpublished.cayenne-di-unpublished
I created manifest file manually (with out using felix plugin). But it seems
that export packages are not loading. Do i need to put those packages in to
class path ? Since manifest contains errors i can not run this as a eclipse
application from eclipse IDE.
I found a example pom file which uses felix and now trying to do it in this
way.
http://dirstudio-ldap-tooling.googlecode.com/svn/trunk/persistence-tooling/persistence-ui/pom.xml
On Wed, Jun 22, 2011 at 6:07 PM, Eshan Sudharaka <es...@gmail.com>wrote:
> hi,
>
> On Wed, Jun 22, 2011 at 2:28 AM, Andrey Razumovsky <
> razumovsky.andrey@gmail.com> wrote:
>
>> Let me join the discussion..
>>
>> Eshan, the new dependencies are Eclipse dependencies, right? Are they
>> *default* Eclipse bundles?
>
>
> yes. They all are included in Eclipse bundles.
>
> If so, it is incorrect to provide them as Maven
>> dependencies, because they will be included in our bundle, while they are
>> already in Eclipse. It's also incorrect to rely on certain Eclipse bundles
>> (like workbench-3.6.1.M20100826-1330.jar), because plugin can be run in
>> different versions of Eclipse.
>>
>> I strongly advice you to add all Eclipse bundles via Require-Bundle header
>> in manifest, and do not mess with Maven currently at all.. We can figure
>> out
>> how to build plugin using Maven later.
>> Currently manifest in your patch contains lots of unneeded stuff, it
>> should
>> be really little (most of Private-Package and Import-Package would go
>> away,
>> since Eclipse bundles would be attached via Require-Bundle). I'm pretty
>> sure
>> this is the only correct way.
>>
>> Good luck!
>>
> thanks for the help.
>
>>
>> 2011/6/21 Andrus Adamchik <an...@objectstyle.org>
>>
>> >
>> > On Jun 21, 2011, at 4:46 AM, Aristedes Maniatis wrote:
>> >
>> > > Isn't there a process for submitting artifacts to central?
>> >
>> > BTW, I tried to investigate that for core Cayenne dependencies still
>> > sitting on objectstyle.org. Central has a requirement to have a -src
>> and
>> > -javadoc artifacts submitted with the binary. This is a reasonable
>> > expectation for an open source project, but in practice it means a bit
>> of an
>> > effort to prepare a compatible distro.
>> >
>> > E.g. it took some time to even find the SVN for Hessian: svn://
>> > svn.caucho.com/resin/ And now I have to checkout everything to find the
>> > sources for the right version of Hessian, the figure out how to build
>> it.
>> >
>> > But in case of Eclipse and friends that seems moot, as it is all in
>> their
>> > p2 repositories already. So it is a question of an appropriate adapter,
>> like
>> > Tycho. (this is my assumption anyways; I am not an Eclipse dev of
>> course).
>> >
>> > Some more googling shows that Nexus Professional can proxy p2 repos (
>> > http://www.sonatype.com/books/nexus-book/reference/p2.html), which is
>> not
>> > very helpful either (we don't have a "canonical" install of Nexus
>> > Professional).
>> >
>> > Andrus
>> >
>> >
>>
>>
>> --
>> Andrey
>>
>
>
>
> --
> *~Thanks & Regards~*
> ***
> *
> P.A.Eshan Sudharaka
> Dept of Computer Science and Engineering
> University of Moratuwa
> Sri Lanka
> http://esudharaka.blogspot.com/
>
>
--
*~Thanks & Regards~*
***
*
P.A.Eshan Sudharaka
Dept of Computer Science and Engineering
University of Moratuwa
Sri Lanka
http://esudharaka.blogspot.com/
--
*~Thanks & Regards~*
***
*
P.A.Eshan Sudharaka
Dept of Computer Science and Engineering
University of Moratuwa
Sri Lanka
http://esudharaka.blogspot.com/
Re: Gsoc project Patch
Posted by Eshan Sudharaka <es...@gmail.com>.
Manifest-Version: 1.0
Bundle-Name: Cayenne Modeler Plugin for Eclipse
Created-By: Apache Maven Bundle Plugin
Bundle-Vendor: Apache Cayenne
Build-Jdk: 1.6.0_11
Bundle-Version: 3.1.0.SNAPSHOT
Bnd-LastModified: 1308209524304
Bundle-Activator: org.apache.cayenne.Activator
Bundle-ManifestVersion: 2
Bundle-SymbolicName: cayenne-modeler-eclipse-plugin;singleton:=true
Require-Bundle: org.eclipse.ui;bundle-version="3.5.1";visibility:=reexport,
org.eclipse.ui.editors;bundle-version="3.5.0";visibility:=reexport,
org.eclipse.jface.text;bundle-version="3.5.1";visibility:=reexport,
org.eclipse.ui.ide;bundle-version="3.5.1";visibility:=reexport,
org.eclipse.ui.navigator;bundle-version="3.4.1";visibility:=reexport,
org.eclipse.ui.views;bundle-version="3.4.1",
org.eclipse.core.resources,
org.eclipse.ui.navigator.resources,
org.eclipse.ui.console;bundle-version="3.4.0",
org.eclipse.ltk.ui.refactoring;bundle-version="3.4.100",
org.eclipse.ui.workbench.texteditor;bundle-version="3.5.1";visibility:=reexport,
org.eclipse.core.filesystem;bundle-version="1.2.1"
Export-Package: org.overture.ide.ui,
org.apache.cayenne.extentions.*,
org.apache.cayenne.cayenne-modeler,
org.apache.cayenne.unpublished.cayenne-project-unpublished,
org.apache.cayenne.unpublished.cayenne-jdk1.5-unpublished,
org.apache.cayenne.cayenne-tools,
org.apache.cayenne.unpublished.cayenne-wocompat-unpublished,
org.apache.cayenne.unpublished.cayenne-di-unpublished
I created manifest file manually (with out using felix plugin). But it seems
that export packages are not loading. Do i need to put those packages in to
class path ? Since manifest contains errors i can not run this as a eclipse
application from eclipse IDE.
I found a example pom file which uses felix and now trying to do it in this
way.
On Wed, Jun 22, 2011 at 6:07 PM, Eshan Sudharaka <es...@gmail.com>wrote:
> hi,
>
> On Wed, Jun 22, 2011 at 2:28 AM, Andrey Razumovsky <
> razumovsky.andrey@gmail.com> wrote:
>
>> Let me join the discussion..
>>
>> Eshan, the new dependencies are Eclipse dependencies, right? Are they
>> *default* Eclipse bundles?
>
>
> yes. They all are included in Eclipse bundles.
>
> If so, it is incorrect to provide them as Maven
>> dependencies, because they will be included in our bundle, while they are
>> already in Eclipse. It's also incorrect to rely on certain Eclipse bundles
>> (like workbench-3.6.1.M20100826-1330.jar), because plugin can be run in
>> different versions of Eclipse.
>>
>> I strongly advice you to add all Eclipse bundles via Require-Bundle header
>> in manifest, and do not mess with Maven currently at all.. We can figure
>> out
>> how to build plugin using Maven later.
>> Currently manifest in your patch contains lots of unneeded stuff, it
>> should
>> be really little (most of Private-Package and Import-Package would go
>> away,
>> since Eclipse bundles would be attached via Require-Bundle). I'm pretty
>> sure
>> this is the only correct way.
>>
>> Good luck!
>>
> thanks for the help.
>
>>
>> 2011/6/21 Andrus Adamchik <an...@objectstyle.org>
>>
>> >
>> > On Jun 21, 2011, at 4:46 AM, Aristedes Maniatis wrote:
>> >
>> > > Isn't there a process for submitting artifacts to central?
>> >
>> > BTW, I tried to investigate that for core Cayenne dependencies still
>> > sitting on objectstyle.org. Central has a requirement to have a -src
>> and
>> > -javadoc artifacts submitted with the binary. This is a reasonable
>> > expectation for an open source project, but in practice it means a bit
>> of an
>> > effort to prepare a compatible distro.
>> >
>> > E.g. it took some time to even find the SVN for Hessian: svn://
>> > svn.caucho.com/resin/ And now I have to checkout everything to find the
>> > sources for the right version of Hessian, the figure out how to build
>> it.
>> >
>> > But in case of Eclipse and friends that seems moot, as it is all in
>> their
>> > p2 repositories already. So it is a question of an appropriate adapter,
>> like
>> > Tycho. (this is my assumption anyways; I am not an Eclipse dev of
>> course).
>> >
>> > Some more googling shows that Nexus Professional can proxy p2 repos (
>> > http://www.sonatype.com/books/nexus-book/reference/p2.html), which is
>> not
>> > very helpful either (we don't have a "canonical" install of Nexus
>> > Professional).
>> >
>> > Andrus
>> >
>> >
>>
>>
>> --
>> Andrey
>>
>
>
>
> --
> *~Thanks & Regards~*
> ***
> *
> P.A.Eshan Sudharaka
> Dept of Computer Science and Engineering
> University of Moratuwa
> Sri Lanka
> http://esudharaka.blogspot.com/
>
>
--
*~Thanks & Regards~*
***
*
P.A.Eshan Sudharaka
Dept of Computer Science and Engineering
University of Moratuwa
Sri Lanka
http://esudharaka.blogspot.com/
Re: Gsoc project Patch
Posted by Eshan Sudharaka <es...@gmail.com>.
hi,
On Wed, Jun 22, 2011 at 2:28 AM, Andrey Razumovsky <
razumovsky.andrey@gmail.com> wrote:
> Let me join the discussion..
>
> Eshan, the new dependencies are Eclipse dependencies, right? Are they
> *default* Eclipse bundles?
yes. They all are included in Eclipse bundles.
If so, it is incorrect to provide them as Maven
> dependencies, because they will be included in our bundle, while they are
> already in Eclipse. It's also incorrect to rely on certain Eclipse bundles
> (like workbench-3.6.1.M20100826-1330.jar), because plugin can be run in
> different versions of Eclipse.
>
> I strongly advice you to add all Eclipse bundles via Require-Bundle header
> in manifest, and do not mess with Maven currently at all.. We can figure
> out
> how to build plugin using Maven later.
> Currently manifest in your patch contains lots of unneeded stuff, it should
> be really little (most of Private-Package and Import-Package would go away,
> since Eclipse bundles would be attached via Require-Bundle). I'm pretty
> sure
> this is the only correct way.
>
> Good luck!
>
thanks for the help.
>
> 2011/6/21 Andrus Adamchik <an...@objectstyle.org>
>
> >
> > On Jun 21, 2011, at 4:46 AM, Aristedes Maniatis wrote:
> >
> > > Isn't there a process for submitting artifacts to central?
> >
> > BTW, I tried to investigate that for core Cayenne dependencies still
> > sitting on objectstyle.org. Central has a requirement to have a -src and
> > -javadoc artifacts submitted with the binary. This is a reasonable
> > expectation for an open source project, but in practice it means a bit of
> an
> > effort to prepare a compatible distro.
> >
> > E.g. it took some time to even find the SVN for Hessian: svn://
> > svn.caucho.com/resin/ And now I have to checkout everything to find the
> > sources for the right version of Hessian, the figure out how to build it.
> >
> > But in case of Eclipse and friends that seems moot, as it is all in their
> > p2 repositories already. So it is a question of an appropriate adapter,
> like
> > Tycho. (this is my assumption anyways; I am not an Eclipse dev of
> course).
> >
> > Some more googling shows that Nexus Professional can proxy p2 repos (
> > http://www.sonatype.com/books/nexus-book/reference/p2.html), which is
> not
> > very helpful either (we don't have a "canonical" install of Nexus
> > Professional).
> >
> > Andrus
> >
> >
>
>
> --
> Andrey
>
--
*~Thanks & Regards~*
***
*
P.A.Eshan Sudharaka
Dept of Computer Science and Engineering
University of Moratuwa
Sri Lanka
http://esudharaka.blogspot.com/
Re: Gsoc project Patch
Posted by Andrus Adamchik <an...@objectstyle.org>.
Ah, thanks for clarification!
On Jun 21, 2011, at 11:59 PM, Andrey Razumovsky wrote:
> The bottom line is that I don't think our Eclipse plugin would require any
> new Maven dependencies at this state.
>
> 2011/6/22 Andrey Razumovsky <ra...@gmail.com>
>
>> Let me join the discussion..
>>
>> Eshan, the new dependencies are Eclipse dependencies, right? Are they
>> *default* Eclipse bundles? If so, it is incorrect to provide them as Maven
>> dependencies, because they will be included in our bundle, while they are
>> already in Eclipse. It's also incorrect to rely on certain Eclipse bundles
>> (like workbench-3.6.1.M20100826-1330.jar), because plugin can be run in
>> different versions of Eclipse.
>>
>> I strongly advice you to add all Eclipse bundles via Require-Bundle header
>> in manifest, and do not mess with Maven currently at all.. We can figure out
>> how to build plugin using Maven later.
>> Currently manifest in your patch contains lots of unneeded stuff, it should
>> be really little (most of Private-Package and Import-Package would go away,
>> since Eclipse bundles would be attached via Require-Bundle). I'm pretty sure
>> this is the only correct way.
>>
>> Good luck!
>>
>>
>> 2011/6/21 Andrus Adamchik <an...@objectstyle.org>
>>
>>>
>>> On Jun 21, 2011, at 4:46 AM, Aristedes Maniatis wrote:
>>>
>>>> Isn't there a process for submitting artifacts to central?
>>>
>>> BTW, I tried to investigate that for core Cayenne dependencies still
>>> sitting on objectstyle.org. Central has a requirement to have a -src and
>>> -javadoc artifacts submitted with the binary. This is a reasonable
>>> expectation for an open source project, but in practice it means a bit of an
>>> effort to prepare a compatible distro.
>>>
>>> E.g. it took some time to even find the SVN for Hessian: svn://
>>> svn.caucho.com/resin/ And now I have to checkout everything to find the
>>> sources for the right version of Hessian, the figure out how to build it.
>>>
>>> But in case of Eclipse and friends that seems moot, as it is all in their
>>> p2 repositories already. So it is a question of an appropriate adapter, like
>>> Tycho. (this is my assumption anyways; I am not an Eclipse dev of course).
>>>
>>> Some more googling shows that Nexus Professional can proxy p2 repos (
>>> http://www.sonatype.com/books/nexus-book/reference/p2.html), which is not
>>> very helpful either (we don't have a "canonical" install of Nexus
>>> Professional).
>>>
>>> Andrus
>>>
>>>
>>
>>
>> --
>> Andrey
>>
>
>
>
> --
> Andrey
Re: Gsoc project Patch
Posted by Andrey Razumovsky <ra...@gmail.com>.
The bottom line is that I don't think our Eclipse plugin would require any
new Maven dependencies at this state.
2011/6/22 Andrey Razumovsky <ra...@gmail.com>
> Let me join the discussion..
>
> Eshan, the new dependencies are Eclipse dependencies, right? Are they
> *default* Eclipse bundles? If so, it is incorrect to provide them as Maven
> dependencies, because they will be included in our bundle, while they are
> already in Eclipse. It's also incorrect to rely on certain Eclipse bundles
> (like workbench-3.6.1.M20100826-1330.jar), because plugin can be run in
> different versions of Eclipse.
>
> I strongly advice you to add all Eclipse bundles via Require-Bundle header
> in manifest, and do not mess with Maven currently at all.. We can figure out
> how to build plugin using Maven later.
> Currently manifest in your patch contains lots of unneeded stuff, it should
> be really little (most of Private-Package and Import-Package would go away,
> since Eclipse bundles would be attached via Require-Bundle). I'm pretty sure
> this is the only correct way.
>
> Good luck!
>
>
> 2011/6/21 Andrus Adamchik <an...@objectstyle.org>
>
>>
>> On Jun 21, 2011, at 4:46 AM, Aristedes Maniatis wrote:
>>
>> > Isn't there a process for submitting artifacts to central?
>>
>> BTW, I tried to investigate that for core Cayenne dependencies still
>> sitting on objectstyle.org. Central has a requirement to have a -src and
>> -javadoc artifacts submitted with the binary. This is a reasonable
>> expectation for an open source project, but in practice it means a bit of an
>> effort to prepare a compatible distro.
>>
>> E.g. it took some time to even find the SVN for Hessian: svn://
>> svn.caucho.com/resin/ And now I have to checkout everything to find the
>> sources for the right version of Hessian, the figure out how to build it.
>>
>> But in case of Eclipse and friends that seems moot, as it is all in their
>> p2 repositories already. So it is a question of an appropriate adapter, like
>> Tycho. (this is my assumption anyways; I am not an Eclipse dev of course).
>>
>> Some more googling shows that Nexus Professional can proxy p2 repos (
>> http://www.sonatype.com/books/nexus-book/reference/p2.html), which is not
>> very helpful either (we don't have a "canonical" install of Nexus
>> Professional).
>>
>> Andrus
>>
>>
>
>
> --
> Andrey
>
--
Andrey
Re: Gsoc project Patch
Posted by Andrey Razumovsky <ra...@gmail.com>.
Let me join the discussion..
Eshan, the new dependencies are Eclipse dependencies, right? Are they
*default* Eclipse bundles? If so, it is incorrect to provide them as Maven
dependencies, because they will be included in our bundle, while they are
already in Eclipse. It's also incorrect to rely on certain Eclipse bundles
(like workbench-3.6.1.M20100826-1330.jar), because plugin can be run in
different versions of Eclipse.
I strongly advice you to add all Eclipse bundles via Require-Bundle header
in manifest, and do not mess with Maven currently at all.. We can figure out
how to build plugin using Maven later.
Currently manifest in your patch contains lots of unneeded stuff, it should
be really little (most of Private-Package and Import-Package would go away,
since Eclipse bundles would be attached via Require-Bundle). I'm pretty sure
this is the only correct way.
Good luck!
2011/6/21 Andrus Adamchik <an...@objectstyle.org>
>
> On Jun 21, 2011, at 4:46 AM, Aristedes Maniatis wrote:
>
> > Isn't there a process for submitting artifacts to central?
>
> BTW, I tried to investigate that for core Cayenne dependencies still
> sitting on objectstyle.org. Central has a requirement to have a -src and
> -javadoc artifacts submitted with the binary. This is a reasonable
> expectation for an open source project, but in practice it means a bit of an
> effort to prepare a compatible distro.
>
> E.g. it took some time to even find the SVN for Hessian: svn://
> svn.caucho.com/resin/ And now I have to checkout everything to find the
> sources for the right version of Hessian, the figure out how to build it.
>
> But in case of Eclipse and friends that seems moot, as it is all in their
> p2 repositories already. So it is a question of an appropriate adapter, like
> Tycho. (this is my assumption anyways; I am not an Eclipse dev of course).
>
> Some more googling shows that Nexus Professional can proxy p2 repos (
> http://www.sonatype.com/books/nexus-book/reference/p2.html), which is not
> very helpful either (we don't have a "canonical" install of Nexus
> Professional).
>
> Andrus
>
>
--
Andrey
Re: Gsoc project Patch
Posted by Andrus Adamchik <an...@objectstyle.org>.
On Jun 21, 2011, at 4:46 AM, Aristedes Maniatis wrote:
> Isn't there a process for submitting artifacts to central?
BTW, I tried to investigate that for core Cayenne dependencies still sitting on objectstyle.org. Central has a requirement to have a -src and -javadoc artifacts submitted with the binary. This is a reasonable expectation for an open source project, but in practice it means a bit of an effort to prepare a compatible distro.
E.g. it took some time to even find the SVN for Hessian: svn://svn.caucho.com/resin/ And now I have to checkout everything to find the sources for the right version of Hessian, the figure out how to build it.
But in case of Eclipse and friends that seems moot, as it is all in their p2 repositories already. So it is a question of an appropriate adapter, like Tycho. (this is my assumption anyways; I am not an Eclipse dev of course).
Some more googling shows that Nexus Professional can proxy p2 repos (http://www.sonatype.com/books/nexus-book/reference/p2.html), which is not very helpful either (we don't have a "canonical" install of Nexus Professional).
Andrus
Re: Gsoc project Patch
Posted by Aristedes Maniatis <ar...@maniatis.org>.
On 21/06/11 4:06 AM, Andrus Adamchik wrote:
> Relying on random public repos can be treacherous. Artifacts there can come and go without notice. For now I feel like the safest way is to keep maintaining the "dependencies" file that Eshan put in Jira for things that are not in central, and put them in the repo that we control (ObjectStyle.org ... should prolly install a repo manager on that server to simplify maintenance).
Isn't there a process for submitting artifacts to central? Then we also speed up the build process and not depend on Objectstyle having to maintain a repository.
Ari
--
-------------------------->
Aristedes Maniatis
GPG fingerprint CBFB 84B4 738D 4E87 5E5C 5EFA EF6A 7D2E 3E49 102A
Re: Gsoc project Patch
Posted by Andrus Adamchik <an...@objectstyle.org>.
On Jun 20, 2011, at 8:35 PM, Ksenia Khailenko wrote:
> 5) as for dependencies - are sure we can't use some public repository? say,
> this one:
> http://www.mvnbrowser.com/artifacts-browse.html?groupId=org.eclipse ? as I
> can see, there all the needed dependencies here
Relying on random public repos can be treacherous. Artifacts there can come and go without notice. For now I feel like the safest way is to keep maintaining the "dependencies" file that Eshan put in Jira for things that are not in central, and put them in the repo that we control (ObjectStyle.org ... should prolly install a repo manager on that server to simplify maintenance).
Also I noticed that Tycho project (http://www.eclipse.org/tycho/) seems to allow access to Eclipse p2 repositories. Not being an Eclipse developer I've no idea whether those contain needed artifacts, but from those 15 minutes that I spent reading on it, that might be *the way* to handle dependencies. Can somebody comment on that?
Andrus
Re: Gsoc project Patch
Posted by Eshan Sudharaka <es...@gmail.com>.
On Mon, Jun 20, 2011 at 11:05 PM, Ksenia Khailenko
<xe...@tut.by>wrote:
> Hi there!
>
> Eshan, I've applied your patch, and here're some comments:
>
> 1) cayenne-modeler-eclipse-plugin-II - let's choose some more meaningful
> name for the project… Say, while it is experimental it can be
> cayenne-modeler-eclipse-plugin-gsoc, and then when we will finish - just
> cayenne-modeler-eclipse-plugin.. I don't like this "II" very much..
>
> 2) the root folder ("cayenne-modeler-eclipse-plugin-II" for now) should
> also
> be included into the patch
>
> 3)pom.xml:
> <bundle.symbolicName>cayenne-modeler-eclipse-plugin</bundle.symbolicName>
> the symbolic name,artifactId, and the name of the project should be equal
> to the enclosing folder - that's why it is so important to choose the good
> name for it; and also, please format your code
>
> 4) plugin.patch is useless here - I've included this file into my project
> in
> order not to forget some details from the old Cay-1392, but you don't need
> it
>
> 5) as for dependencies - are sure we can't use some public repository? say,
> this one:
> http://www.mvnbrowser.com/artifacts-browse.html?groupId=org.eclipse ? as I
> can see, there all the needed dependencies here
>
> 6) Add some picture for your editor - hard to find it in list
>
> I added cayenne.png as the icon for editor. But it seems image size is too
large so it is not appear on the editor (I tested icon configuration with
eclipse giff image and it is working).
> 7) try to launch your plugin not as eclipse application, but as standalone
> artifact - the simplest way, when you are copying your jar into plugins
> eclipse folder and launching eclipse. this may be not so easy…
>
> I've just tested the building and launching of the project, haven't looked
> in depth, but in general, it looks nice, good work!:) I'm looking forward
> for your further updates.
>
> 2011/6/17 Eshan Sudharaka <es...@gmail.com>
>
> > Hi Ksenia,
> > I have attached a patch of my current work and the zipped
> > repository folder. Apply this patch and copy this folder in to
> > /sandbox/cayenne-modeler-eclipse-plugin-II .
> >
> > I will create a list of used third party dependencies and attached it on
> > jira issue with the patch file.
> >
> > --
> > *~Thanks & Regards~*
> > ***
> > *
> > P.A.Eshan Sudharaka
> > Dept of Computer Science and Engineering
> > University of Moratuwa
> > Sri Lanka
> > http://esudharaka.blogspot.com/
> >
> >
>
>
> --
> Regards, Ksenia Khailenko
>
--
*~Thanks & Regards~*
***
*
P.A.Eshan Sudharaka
Dept of Computer Science and Engineering
University of Moratuwa
Sri Lanka
http://esudharaka.blogspot.com/