You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2014/07/28 21:55:40 UTC

[jira] [Commented] (HBASE-3135) Make our MR jobs implement Tool and use ToolRunner so can do -D trickery, etc.

    [ https://issues.apache.org/jira/browse/HBASE-3135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14076706#comment-14076706 ] 

stack commented on HBASE-3135:
------------------------------

Looks great.  Why this change?

-    Job job = new Job(conf, NAME + "_" + tableName);
+    Job job = Job.getInstance(conf, NAME + "_" + tableName);

Did you try running the new mains you added to make sure they basically work?

Let me see what hadoopqa says.  Thanks [~talat]

> Make our MR jobs implement Tool and use ToolRunner so can do -D trickery, etc.
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-3135
>                 URL: https://issues.apache.org/jira/browse/HBASE-3135
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: stack
>            Assignee: Talat UYARER
>         Attachments: HBASE-3135.patch
>
>
> Our TIF can take a bunch of config.  If our MR jobs -- rowcounter, export, import, etc. -- all implemented Tool/ToolRunner, then we'd pick up the Tool cmdline parse of -D that sets config.  Small change.  Lots of utility.



--
This message was sent by Atlassian JIRA
(v6.2#6252)