[GitHub] [yunikorn-site] wilfred-s commented on a diff in pull request #178: [YUNIKORN-1289] Publish Daemonset scheduling design doc

[GitBox <gi...@apache.org>]

wilfred-s commented on code in PR #178:
URL: https://github.com/apache/yunikorn-site/pull/178#discussion_r953302580


##########
docs/design/simple_preemptor.md:
##########
@@ -0,0 +1,114 @@
+             ---

Review Comment:
   No spaces at the start of the line



##########
sidebars.js:
##########
@@ -75,6 +75,7 @@ module.exports = {
                     'design/state_aware_scheduling',
                     'design/scheduler_object_states',
                     'design/scheduler_core_design',
+                    'design/simple_preemptor'

Review Comment:
   This should not be in between the two old/no longer maintained docs. It should be higher up the list, around the generic resource line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org