You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by md...@apache.org on 2013/11/25 10:35:02 UTC

svn commit: r1545188 - in /jackrabbit/oak/trunk: oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/principal/PrincipalManagerTest.java oak-parent/pom.xml

Author: mduerig
Date: Mon Nov 25 09:35:01 2013
New Revision: 1545188

URL: http://svn.apache.org/r1545188
Log:
OAK-482 Group members stored in a rep:members tree
- revert from previous commit: println for diagnosing build failure on Buildbot
- Temporary disable using files for reporting test failures

Modified:
    jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/principal/PrincipalManagerTest.java
    jackrabbit/oak/trunk/oak-parent/pom.xml

Modified: jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/principal/PrincipalManagerTest.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/principal/PrincipalManagerTest.java?rev=1545188&r1=1545187&r2=1545188&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/principal/PrincipalManagerTest.java (original)
+++ jackrabbit/oak/trunk/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/security/principal/PrincipalManagerTest.java Mon Nov 25 09:35:01 2013
@@ -174,28 +174,21 @@ public class PrincipalManagerTest extend
         }
     }
 
-    // FIXME remove println statements put here to diagnose why the build fails on Buildbot
     @Test
-    public void testMembers() throws Throwable {
-        try {
-            PrincipalIterator it = principalMgr.getPrincipals(PrincipalManager.SEARCH_TYPE_ALL);
-            while (it.hasNext()) {
-                Principal p = it.nextPrincipal();
-                System.out.println(p);
-                if (p.equals(principalMgr.getEveryone())) {
-                    continue;
-                }
-                if (isGroup(p)) {
-                    Enumeration<? extends Principal> en = ((java.security.acl.Group) p).members();
-                    while (en.hasMoreElements()) {
-                        Principal memb = en.nextElement();
-                        assertTrue(principalMgr.hasPrincipal(memb.getName()));
-                    }
+    public void testMembers() {
+        PrincipalIterator it = principalMgr.getPrincipals(PrincipalManager.SEARCH_TYPE_ALL);
+        while (it.hasNext()) {
+            Principal p = it.nextPrincipal();
+            if (p.equals(principalMgr.getEveryone())) {
+                continue;
+            }
+            if (isGroup(p)) {
+                Enumeration<? extends Principal> en = ((java.security.acl.Group) p).members();
+                while (en.hasMoreElements()) {
+                    Principal memb = en.nextElement();
+                    assertTrue(principalMgr.hasPrincipal(memb.getName()));
                 }
             }
-        } catch (Throwable t) {
-            t.printStackTrace();
-            throw t;
         }
     }
 

Modified: jackrabbit/oak/trunk/oak-parent/pom.xml
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-parent/pom.xml?rev=1545188&r1=1545187&r2=1545188&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-parent/pom.xml (original)
+++ jackrabbit/oak/trunk/oak-parent/pom.xml Mon Nov 25 09:35:01 2013
@@ -156,6 +156,7 @@
               <segment.db>${segment.db}</segment.db>
             </systemPropertyVariables>
             <redirectTestOutputToFile>true</redirectTestOutputToFile>
+            <useFile>false</useFile>  <!-- FIXME remove again: put her to diagnose test failure on Buildbot -->
           </configuration>
         </plugin>
         <plugin>