You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by se...@apache.org on 2016/11/15 20:20:36 UTC
[04/50] [abbrv] hive git commit: HIVE-15164. Change default RPC port
for llap to be a dynamic port. (Siddharth Seth,
reviewed by Prasanth Jayachandran)
HIVE-15164. Change default RPC port for llap to be a dynamic port. (Siddharth Seth, reviewed by Prasanth Jayachandran)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/85711700
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/85711700
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/85711700
Branch: refs/heads/hive-14535
Commit: 85711700e55839dc606167f72e6593d4624bfd04
Parents: ab45629
Author: Siddharth Seth <ss...@apache.org>
Authored: Thu Nov 10 11:37:55 2016 -0800
Committer: Siddharth Seth <ss...@apache.org>
Committed: Thu Nov 10 11:37:55 2016 -0800
----------------------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java | 4 ++--
.../hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java | 5 ++---
.../hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java | 2 ++
3 files changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/85711700/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
----------------------------------------------------------------------
diff --git a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
index 7ce29e1..56289c9 100644
--- a/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
+++ b/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
@@ -2958,8 +2958,8 @@ public class HiveConf extends Configuration {
LLAP_DAEMON_NUM_EXECUTORS("hive.llap.daemon.num.executors", 4,
"Number of executors to use in LLAP daemon; essentially, the number of tasks that can be\n" +
"executed in parallel.", "llap.daemon.num.executors"),
- LLAP_DAEMON_RPC_PORT("hive.llap.daemon.rpc.port", 15001, "The LLAP daemon RPC port.",
- "llap.daemon.rpc.port"),
+ LLAP_DAEMON_RPC_PORT("hive.llap.daemon.rpc.port", 0, "The LLAP daemon RPC port.",
+ "llap.daemon.rpc.port. A value of 0 indicates a dynamic port"),
LLAP_DAEMON_MEMORY_PER_INSTANCE_MB("hive.llap.daemon.memory.per.instance.mb", 3276,
"The total amount of memory to use for the executors inside LLAP (in megabytes).",
"llap.daemon.memory.per.instance.mb"),
http://git-wip-us.apache.org/repos/asf/hive/blob/85711700/llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java
----------------------------------------------------------------------
diff --git a/llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java b/llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java
index 105a912..719518e 100644
--- a/llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java
+++ b/llap-server/src/test/org/apache/hadoop/hive/llap/daemon/impl/TestLlapDaemonProtocolServerImpl.java
@@ -38,15 +38,14 @@ public class TestLlapDaemonProtocolServerImpl {
@Test(timeout = 10000)
- public void test() throws ServiceException, IOException {
+ public void testSimpleCall() throws ServiceException, IOException {
LlapDaemonConfiguration daemonConf = new LlapDaemonConfiguration();
- int rpcPort = HiveConf.getIntVar(daemonConf, ConfVars.LLAP_DAEMON_RPC_PORT);
int numHandlers = HiveConf.getIntVar(daemonConf, ConfVars.LLAP_DAEMON_RPC_NUM_HANDLERS);
ContainerRunner containerRunnerMock = mock(ContainerRunner.class);
LlapProtocolServerImpl server =
new LlapProtocolServerImpl(null, numHandlers, containerRunnerMock,
new AtomicReference<InetSocketAddress>(), new AtomicReference<InetSocketAddress>(),
- rpcPort, rpcPort + 1, null);
+ 0, 0, null);
when(containerRunnerMock.submitWork(any(SubmitWorkRequestProto.class))).thenReturn(
SubmitWorkResponseProto
.newBuilder()
http://git-wip-us.apache.org/repos/asf/hive/blob/85711700/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
----------------------------------------------------------------------
diff --git a/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java b/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
index 7dd778d..0deebf9 100644
--- a/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
+++ b/llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java
@@ -459,6 +459,8 @@ public class LlapTaskCommunicator extends TezTaskCommunicatorImpl {
.sourceStateUpdated(vertexStateUpdate.getVertexName(), vertexStateUpdate.getVertexState());
}
+ // TODO HIVE-15163. Handle cases where nodes go down and come back on the same port. Historic information
+ // can prevent updates from being sent out to the new node.
public void sendStateUpdate(final LlapNodeId nodeId,
final SourceStateUpdatedRequestProto request) {
communicator.sendSourceStateUpdate(request, nodeId,