[jira] [Commented] (OFBIZ-9111) Service "deletePayHistory" does not have correct implementation

["Michael Brohl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15873279#comment-15873279 ] 

Michael Brohl commented on OFBIZ-9111:
--------------------------------------

[~pawan.verma],

thanks for your contribution. Derived from the naming "deletePayHistory" I would say that the remove-value is correct, it deletes the data entry. Maybe it's a bit misleading that the thruDate is first set and stored before the value is removed so maybe we should remove the lines

         <set field="lookedUpValue.thruDate" from-field="nowTimeStamp"/>
         <store-value value-field="lookedUpValue"/>



> Service "deletePayHistory" does not have correct implementation
> ---------------------------------------------------------------
>
>                 Key: OFBIZ-9111
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9111
>             Project: OFBiz
>          Issue Type: Bug
>          Components: humanres
>    Affects Versions: Trunk
>            Reporter: Pawan Verma
>            Assignee: Michael Brohl
>            Priority: Minor
>         Attachments: OFBIZ-9111.patch
>
>
> Service "deletePayHistory" does not have correct implementation.This service set thru_date then remove record of PayHistory.This should be corrected.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)