You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by jo...@apache.org on 2016/12/19 22:43:10 UTC
[04/14] opennlp git commit: Remove unnecessary parentheses
Remove unnecessary parentheses
See issue OPENNLP-871
Project: http://git-wip-us.apache.org/repos/asf/opennlp/repo
Commit: http://git-wip-us.apache.org/repos/asf/opennlp/commit/dd483afe
Tree: http://git-wip-us.apache.org/repos/asf/opennlp/tree/dd483afe
Diff: http://git-wip-us.apache.org/repos/asf/opennlp/diff/dd483afe
Branch: refs/heads/trunk
Commit: dd483afe90b157ab39af6fab1f6f1a5d1775fbe3
Parents: d79b97c
Author: J�rn Kottmann <jo...@apache.org>
Authored: Fri Oct 28 18:54:40 2016 +0200
Committer: J�rn Kottmann <jo...@apache.org>
Committed: Mon Dec 19 23:37:32 2016 +0100
----------------------------------------------------------------------
.../src/main/java/opennlp/tools/chunker/ChunkSample.java | 8 ++++----
.../tools/chunker/DefaultChunkerSequenceValidator.java | 6 +++---
.../java/opennlp/tools/formats/Conll03NameSampleStream.java | 4 ++--
.../java/opennlp/tools/formats/EvalitaNameSampleStream.java | 2 +-
.../opennlp/tools/formats/NameSampleDataStreamFactory.java | 2 +-
.../formats/convert/ParseToTokenSampleStreamFactory.java | 4 ++--
.../src/main/java/opennlp/tools/lemmatizer/LemmaSample.java | 6 +++---
.../src/main/java/opennlp/tools/ml/model/AbstractModel.java | 2 +-
.../main/java/opennlp/tools/ml/model/ComparableEvent.java | 4 ++--
.../java/opennlp/tools/ml/model/ComparablePredicate.java | 4 ++--
.../src/main/java/opennlp/tools/ml/model/MutableContext.java | 2 +-
.../opennlp/tools/ml/model/RealValueFileEventStream.java | 2 +-
.../java/opennlp/tools/ml/naivebayes/NaiveBayesModel.java | 2 +-
.../java/opennlp/tools/namefind/DictionaryNameFinder.java | 2 +-
.../java/opennlp/tools/parser/AbstractContextGenerator.java | 6 +++---
.../java/opennlp/tools/parser/AbstractParserEventStream.java | 2 +-
.../java/opennlp/tools/parser/ChunkContextGenerator.java | 6 +++---
.../opennlp/tools/parser/chunking/BuildContextGenerator.java | 2 +-
.../java/opennlp/tools/sentdetect/SentenceDetectorME.java | 2 +-
.../test/java/opennlp/tools/namefind/NameFinderMETest.java | 2 +-
.../test/java/opennlp/tools/postag/POSTaggerFactoryTest.java | 2 +-
.../src/test/java/opennlp/tools/postag/POSTaggerMETest.java | 2 +-
.../src/main/java/opennlp/uima/chunker/ChunkerTrainer.java | 2 +-
23 files changed, 38 insertions(+), 38 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/chunker/ChunkSample.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/chunker/ChunkSample.java b/opennlp-tools/src/main/java/opennlp/tools/chunker/ChunkSample.java
index e829f9d..da71d36 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/chunker/ChunkSample.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/chunker/ChunkSample.java
@@ -66,9 +66,9 @@ public class ChunkSample {
validateArguments(sentence.size(), tags.size(), preds.size());
- this.sentence = Collections.unmodifiableList(new ArrayList<String>((sentence)));
- this.tags = Collections.unmodifiableList(new ArrayList<String>((tags)));
- this.preds = Collections.unmodifiableList(new ArrayList<String>((preds)));
+ this.sentence = Collections.unmodifiableList(new ArrayList<String>(sentence));
+ this.tags = Collections.unmodifiableList(new ArrayList<String>(tags));
+ this.preds = Collections.unmodifiableList(new ArrayList<String>(preds));
}
/** Gets the training sentence */
@@ -117,7 +117,7 @@ public class ChunkSample {
for (int ci = 0, cn = aPreds.length; ci < cn; ci++) {
String pred = aPreds[ci];
if (pred.startsWith("B-")
- || (!pred.equals("I-" + startTag) && !pred.equals("O"))) { // start
+ || !pred.equals("I-" + startTag) && !pred.equals("O")) { // start
if (foundPhrase) { // handle the last
phrases.add(new Span(startIndex, ci, startTag));
}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/chunker/DefaultChunkerSequenceValidator.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/chunker/DefaultChunkerSequenceValidator.java b/opennlp-tools/src/main/java/opennlp/tools/chunker/DefaultChunkerSequenceValidator.java
index 41e0230..ff7136a 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/chunker/DefaultChunkerSequenceValidator.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/chunker/DefaultChunkerSequenceValidator.java
@@ -24,14 +24,14 @@ public class DefaultChunkerSequenceValidator implements SequenceValidator<String
private boolean validOutcome(String outcome, String prevOutcome) {
if (outcome.startsWith("I-")) {
if (prevOutcome == null) {
- return (false);
+ return false;
}
else {
if (prevOutcome.equals("O")) {
- return (false);
+ return false;
}
if (!prevOutcome.substring(2).equals(outcome.substring(2))) {
- return (false);
+ return false;
}
}
}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/formats/Conll03NameSampleStream.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/formats/Conll03NameSampleStream.java b/opennlp-tools/src/main/java/opennlp/tools/formats/Conll03NameSampleStream.java
index eed8eef..78c0ee8 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/formats/Conll03NameSampleStream.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/formats/Conll03NameSampleStream.java
@@ -116,12 +116,12 @@ public class Conll03NameSampleStream implements ObjectStream<NameSample>{
String fields[] = line.split(" ");
// For English: WORD POS-TAG SC-TAG NE-TAG
- if (LANGUAGE.EN.equals(lang) && (fields.length == 4)) {
+ if (LANGUAGE.EN.equals(lang) && fields.length == 4) {
sentence.add(fields[0]);
tags.add(fields[3]); // 3 is NE-TAG
}
// For German: WORD LEMA-TAG POS-TAG SC-TAG NE-TAG
- else if (LANGUAGE.DE.equals(lang) && (fields.length == 5)) {
+ else if (LANGUAGE.DE.equals(lang) && fields.length == 5) {
sentence.add(fields[0]);
tags.add(fields[4]); // 4 is NE-TAG
}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/formats/EvalitaNameSampleStream.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/formats/EvalitaNameSampleStream.java b/opennlp-tools/src/main/java/opennlp/tools/formats/EvalitaNameSampleStream.java
index a983b87..026b2a1 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/formats/EvalitaNameSampleStream.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/formats/EvalitaNameSampleStream.java
@@ -160,7 +160,7 @@ public class EvalitaNameSampleStream implements ObjectStream<NameSample>{
String fields[] = line.split(" ");
// For Italian: WORD POS-TAG SC-TAG NE-TAG
- if (LANGUAGE.IT.equals(lang) && (fields.length == 4)) {
+ if (LANGUAGE.IT.equals(lang) && fields.length == 4) {
sentence.add(fields[0]);
tags.add(fields[3]); // 3 is NE-TAG
}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/formats/NameSampleDataStreamFactory.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/formats/NameSampleDataStreamFactory.java b/opennlp-tools/src/main/java/opennlp/tools/formats/NameSampleDataStreamFactory.java
index 69a5adb..a95c8c6 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/formats/NameSampleDataStreamFactory.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/formats/NameSampleDataStreamFactory.java
@@ -54,7 +54,7 @@ public class NameSampleDataStreamFactory extends AbstractSampleStreamFactory<Nam
ObjectStream<String> lineStream = null;
try {
- lineStream = new PlainTextByLineStream((sampleDataIn), params.getEncoding());
+ lineStream = new PlainTextByLineStream(sampleDataIn, params.getEncoding());
} catch (IOException ex) {
CmdLineUtil.handleCreateObjectStreamError(ex);
}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/formats/convert/ParseToTokenSampleStreamFactory.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/formats/convert/ParseToTokenSampleStreamFactory.java b/opennlp-tools/src/main/java/opennlp/tools/formats/convert/ParseToTokenSampleStreamFactory.java
index 8b13ece..318b562 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/formats/convert/ParseToTokenSampleStreamFactory.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/formats/convert/ParseToTokenSampleStreamFactory.java
@@ -46,8 +46,8 @@ public class ParseToTokenSampleStreamFactory extends DetokenizerSampleStreamFact
StreamFactoryRegistry.DEFAULT_FORMAT).create(
ArgumentParser.filter(args, WordTagSampleStreamFactory.Parameters.class));
- return (new POSToTokenSampleStream(createDetokenizer(params),
- new ParseToPOSSampleStream(parseSampleStream)));
+ return new POSToTokenSampleStream(createDetokenizer(params),
+ new ParseToPOSSampleStream(parseSampleStream));
}
public static void registerFactory() {
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/lemmatizer/LemmaSample.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/lemmatizer/LemmaSample.java b/opennlp-tools/src/main/java/opennlp/tools/lemmatizer/LemmaSample.java
index a743575..fe6dd69 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/lemmatizer/LemmaSample.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/lemmatizer/LemmaSample.java
@@ -58,9 +58,9 @@ public LemmaSample(String[] tokens, String[] tags, String[] lemmas) {
validateArguments(tokens.size(), tags.size(), lemmas.size());
- this.tokens = Collections.unmodifiableList(new ArrayList<String>((tokens)));
- this.tags = Collections.unmodifiableList(new ArrayList<String>((tags)));
- this.lemmas = Collections.unmodifiableList(new ArrayList<String>((lemmas)));
+ this.tokens = Collections.unmodifiableList(new ArrayList<String>(tokens));
+ this.tags = Collections.unmodifiableList(new ArrayList<String>(tags));
+ this.lemmas = Collections.unmodifiableList(new ArrayList<String>(lemmas));
}
public String[] getTokens() {
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/ml/model/AbstractModel.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/ml/model/AbstractModel.java b/opennlp-tools/src/main/java/opennlp/tools/ml/model/AbstractModel.java
index 8ce2e3a..0ab1fc6 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/ml/model/AbstractModel.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/ml/model/AbstractModel.java
@@ -139,7 +139,7 @@ public abstract class AbstractModel implements MaxentModel {
}
public int getNumOutcomes() {
- return(evalParams.getNumOutcomes());
+ return evalParams.getNumOutcomes();
}
/**
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/ml/model/ComparableEvent.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/ml/model/ComparableEvent.java b/opennlp-tools/src/main/java/opennlp/tools/ml/model/ComparableEvent.java
index a1d9e78..83ed078 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/ml/model/ComparableEvent.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/ml/model/ComparableEvent.java
@@ -49,8 +49,8 @@ public class ComparableEvent implements Comparable<ComparableEvent> {
else if (outcome > ce.outcome)
return 1;
- int smallerLength = (predIndexes.length > ce.predIndexes.length ? ce.predIndexes.length
- : predIndexes.length);
+ int smallerLength = predIndexes.length > ce.predIndexes.length ? ce.predIndexes.length
+ : predIndexes.length;
for (int i = 0; i < smallerLength; i++) {
if (predIndexes[i] < ce.predIndexes[i])
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/ml/model/ComparablePredicate.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/ml/model/ComparablePredicate.java b/opennlp-tools/src/main/java/opennlp/tools/ml/model/ComparablePredicate.java
index 561f13b..7483a26 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/ml/model/ComparablePredicate.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/ml/model/ComparablePredicate.java
@@ -36,8 +36,8 @@ public class ComparablePredicate implements Comparable<ComparablePredicate> {
}
public int compareTo(ComparablePredicate cp) {
- int smallerLength = (outcomes.length > cp.outcomes.length?
- cp.outcomes.length : outcomes.length);
+ int smallerLength = outcomes.length > cp.outcomes.length?
+ cp.outcomes.length : outcomes.length;
for (int i=0; i<smallerLength; i++) {
if (outcomes[i] < cp.outcomes[i]) return -1;
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/ml/model/MutableContext.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/ml/model/MutableContext.java b/opennlp-tools/src/main/java/opennlp/tools/ml/model/MutableContext.java
index 3685974..36e2cf1 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/ml/model/MutableContext.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/ml/model/MutableContext.java
@@ -59,6 +59,6 @@ public class MutableContext extends Context {
}
public boolean contains(int outcome) {
- return(Arrays.binarySearch(outcomes,outcome) >= 0);
+ return Arrays.binarySearch(outcomes,outcome) >= 0;
}
}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/ml/model/RealValueFileEventStream.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/ml/model/RealValueFileEventStream.java b/opennlp-tools/src/main/java/opennlp/tools/ml/model/RealValueFileEventStream.java
index 68b3503..1c9f430 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/ml/model/RealValueFileEventStream.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/ml/model/RealValueFileEventStream.java
@@ -86,7 +86,7 @@ public class RealValueFileEventStream extends FileEventStream {
String outcome = line.substring(0, si);
String[] contexts = line.substring(si + 1).split(" ");
float[] values = parseContexts(contexts);
- return (new Event(outcome, contexts, values));
+ return new Event(outcome, contexts, values);
}
return null;
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/ml/naivebayes/NaiveBayesModel.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/ml/naivebayes/NaiveBayesModel.java b/opennlp-tools/src/main/java/opennlp/tools/ml/naivebayes/NaiveBayesModel.java
index 23ec75a..05503fa 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/ml/naivebayes/NaiveBayesModel.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/ml/naivebayes/NaiveBayesModel.java
@@ -136,7 +136,7 @@ public class NaiveBayesModel extends AbstractModel {
else if (denominator == 0 || denominator < Double.MIN_VALUE)
return 0;
else
- return 1.0 * (numerator) / (denominator);
+ return 1.0 * numerator / denominator;
}
private static double getSmoothedProbability(double numerator, double denominator, double vocabulary) {
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/namefind/DictionaryNameFinder.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/namefind/DictionaryNameFinder.java b/opennlp-tools/src/main/java/opennlp/tools/namefind/DictionaryNameFinder.java
index 746aeb0..b9e1f17 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/namefind/DictionaryNameFinder.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/namefind/DictionaryNameFinder.java
@@ -90,7 +90,7 @@ public class DictionaryNameFinder implements TokenNameFinder {
if (nameFound != null) {
namesFound.add(nameFound);
// skip over the found tokens for the next search
- offsetFrom += (nameFound.length() - 1);
+ offsetFrom += nameFound.length() - 1;
}
}
return namesFound.toArray(new Span[namesFound.size()]);
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/parser/AbstractContextGenerator.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/parser/AbstractContextGenerator.java b/opennlp-tools/src/main/java/opennlp/tools/parser/AbstractContextGenerator.java
index 5cfff7d..f537576 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/parser/AbstractContextGenerator.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/parser/AbstractContextGenerator.java
@@ -58,7 +58,7 @@ public abstract class AbstractContextGenerator {
StringBuilder feat = new StringBuilder(5);
feat.append(i).append("=");
feat.append(punct.getType());
- return (feat.toString());
+ return feat.toString();
}
protected String cons(Parse p, int i) {
@@ -73,7 +73,7 @@ public abstract class AbstractContextGenerator {
else {
feat.append(EOS);
}
- return (feat.toString());
+ return feat.toString();
}
protected String consbo(Parse p, int i) { //cons back-off
@@ -88,7 +88,7 @@ public abstract class AbstractContextGenerator {
else {
feat.append(EOS);
}
- return (feat.toString());
+ return feat.toString();
}
/**
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/parser/AbstractParserEventStream.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/parser/AbstractParserEventStream.java b/opennlp-tools/src/main/java/opennlp/tools/parser/AbstractParserEventStream.java
index 8913c3c..9d72bf8 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/parser/AbstractParserEventStream.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/parser/AbstractParserEventStream.java
@@ -199,7 +199,7 @@ public abstract class AbstractParserEventStream extends opennlp.tools.util.Abstr
*/
protected boolean lastChild(Parse child, Parse parent) {
Parse[] kids = AbstractBottomUpParser.collapsePunctuation(parent.getChildren(),punctSet);
- return (kids[kids.length - 1] == child);
+ return kids[kids.length - 1] == child;
}
}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/parser/ChunkContextGenerator.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/parser/ChunkContextGenerator.java b/opennlp-tools/src/main/java/opennlp/tools/parser/ChunkContextGenerator.java
index 7471b3c..d3d8303 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/parser/ChunkContextGenerator.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/parser/ChunkContextGenerator.java
@@ -164,7 +164,7 @@ public class ChunkContextGenerator implements ChunkerContextGenerator {
if (contextsCache != null) {
contextsCache.put(cacheKey,contexts);
}
- return (contexts);
+ return contexts;
}
private String chunkandpostag(int i, String tok, String tag, String chunk) {
@@ -173,7 +173,7 @@ public class ChunkContextGenerator implements ChunkerContextGenerator {
if (i < 0) {
feat.append("|").append(chunk);
}
- return (feat.toString());
+ return feat.toString();
}
private String chunkandpostagbo(int i, String tag, String chunk) {
@@ -182,6 +182,6 @@ public class ChunkContextGenerator implements ChunkerContextGenerator {
if (i < 0) {
feat.append("|").append(chunk);
}
- return (feat.toString());
+ return feat.toString();
}
}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/parser/chunking/BuildContextGenerator.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/parser/chunking/BuildContextGenerator.java b/opennlp-tools/src/main/java/opennlp/tools/parser/chunking/BuildContextGenerator.java
index 01e9a44..081ef9a 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/parser/chunking/BuildContextGenerator.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/parser/chunking/BuildContextGenerator.java
@@ -304,6 +304,6 @@ public class BuildContextGenerator extends AbstractContextGenerator {
}
}
}
- return (features.toArray(new String[features.size()]));
+ return features.toArray(new String[features.size()]);
}
}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceDetectorME.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceDetectorME.java b/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceDetectorME.java
index fce4e52..4998545 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceDetectorME.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/sentdetect/SentenceDetectorME.java
@@ -215,7 +215,7 @@ public class SentenceDetectorME implements SentenceDetector {
while (end > 0 && StringUtil.isWhitespace(s.charAt(end - 1)))
end--;
- if ((end - start) > 0) {
+ if (end - start > 0) {
sentProbs.add(1d);
return new Span[] {new Span(start, end)};
}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/test/java/opennlp/tools/namefind/NameFinderMETest.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/test/java/opennlp/tools/namefind/NameFinderMETest.java b/opennlp-tools/src/test/java/opennlp/tools/namefind/NameFinderMETest.java
index 2fe40d1..cc8b0d1 100644
--- a/opennlp-tools/src/test/java/opennlp/tools/namefind/NameFinderMETest.java
+++ b/opennlp-tools/src/test/java/opennlp/tools/namefind/NameFinderMETest.java
@@ -272,7 +272,7 @@ public class NameFinderMETest {
// now test if it can detect the sample sentences
- String[] sentence = ("NATO United States Barack Obama").split("\\s+");
+ String[] sentence = "NATO United States Barack Obama".split("\\s+");
Span[] names1 = nameFinder.find(sentence);
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/test/java/opennlp/tools/postag/POSTaggerFactoryTest.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/test/java/opennlp/tools/postag/POSTaggerFactoryTest.java b/opennlp-tools/src/test/java/opennlp/tools/postag/POSTaggerFactoryTest.java
index fbab448..2f72124 100644
--- a/opennlp-tools/src/test/java/opennlp/tools/postag/POSTaggerFactoryTest.java
+++ b/opennlp-tools/src/test/java/opennlp/tools/postag/POSTaggerFactoryTest.java
@@ -134,4 +134,4 @@ public class POSTaggerFactoryTest {
public void testCreateWithHierarchy2() throws InvalidFormatException {
POSTaggerFactory.create(this.getClass().getCanonicalName(), null, null);
}
-}
\ No newline at end of file
+}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-tools/src/test/java/opennlp/tools/postag/POSTaggerMETest.java
----------------------------------------------------------------------
diff --git a/opennlp-tools/src/test/java/opennlp/tools/postag/POSTaggerMETest.java b/opennlp-tools/src/test/java/opennlp/tools/postag/POSTaggerMETest.java
index 996b233..bcac9ae 100644
--- a/opennlp-tools/src/test/java/opennlp/tools/postag/POSTaggerMETest.java
+++ b/opennlp-tools/src/test/java/opennlp/tools/postag/POSTaggerMETest.java
@@ -89,4 +89,4 @@ public class POSTaggerMETest {
POSTaggerME.buildNGramDictionary(samples, 0);
}
-}
\ No newline at end of file
+}
http://git-wip-us.apache.org/repos/asf/opennlp/blob/dd483afe/opennlp-uima/src/main/java/opennlp/uima/chunker/ChunkerTrainer.java
----------------------------------------------------------------------
diff --git a/opennlp-uima/src/main/java/opennlp/uima/chunker/ChunkerTrainer.java b/opennlp-uima/src/main/java/opennlp/uima/chunker/ChunkerTrainer.java
index ad194ed..d22879d 100644
--- a/opennlp-uima/src/main/java/opennlp/uima/chunker/ChunkerTrainer.java
+++ b/opennlp-uima/src/main/java/opennlp/uima/chunker/ChunkerTrainer.java
@@ -167,7 +167,7 @@ public class ChunkerTrainer extends CasConsumer_ImplBase {
while (chunkIterator.hasNext()) {
AnnotationFS chunkAnnotation = chunkIterator.next();
- processChunk(tcas, (chunkAnnotation));
+ processChunk(tcas, chunkAnnotation);
}
}