You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2009/12/11 20:04:37 UTC
svn commit: r889768 - in /commons/proper/jexl/trunk/src:
main/java/org/apache/commons/jexl2/internal/introspection/
test/java/org/apache/commons/jexl2/
Author: sebb
Date: Fri Dec 11 19:04:36 2009
New Revision: 889768
URL: http://svn.apache.org/viewvc?rev=889768&view=rev
Log:
Fix some Eclipse warnings
Modified:
commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/internal/introspection/IntrospectorBase.java
commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/AssignTest.java
commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/ClassCreator.java
commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/ClassCreatorTest.java
commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/MethodTest.java
Modified: commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/internal/introspection/IntrospectorBase.java
URL: http://svn.apache.org/viewvc/commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/internal/introspection/IntrospectorBase.java?rev=889768&r1=889767&r2=889768&view=diff
==============================================================================
--- commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/internal/introspection/IntrospectorBase.java (original)
+++ commons/proper/jexl/trunk/src/main/java/org/apache/commons/jexl2/internal/introspection/IntrospectorBase.java Fri Dec 11 19:04:36 2009
@@ -128,6 +128,7 @@
*/
private static class CacheMiss {
/** The constructor used as cache-miss. */
+ @SuppressWarnings("unused")
public CacheMiss() {}
}
/** The cache-miss marker for the constructors map. */
Modified: commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/AssignTest.java
URL: http://svn.apache.org/viewvc/commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/AssignTest.java?rev=889768&r1=889767&r2=889768&view=diff
==============================================================================
--- commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/AssignTest.java (original)
+++ commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/AssignTest.java Fri Dec 11 19:04:36 2009
@@ -145,7 +145,7 @@
}
public void testUtil() throws Exception {
- Quux quux = ENGINE.newInstance(Quux.class, "xuuq", 100);
+ Quux quux = ENGINE.newInstance(Quux.class, "xuuq", Integer.valueOf(100));
ENGINE.setProperty(quux, "froboz.value", Integer.valueOf(100));
Object o = ENGINE.getProperty(quux, "froboz.value");
assertEquals("Result is not 100", new Integer(100), o);
Modified: commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/ClassCreator.java
URL: http://svn.apache.org/viewvc/commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/ClassCreator.java?rev=889768&r1=889767&r2=889768&view=diff
==============================================================================
--- commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/ClassCreator.java (original)
+++ commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/ClassCreator.java Fri Dec 11 19:04:36 2009
@@ -128,7 +128,7 @@
return null;
}
Integer r = (Integer) jexl.invokeMethod(javac, "compile", source);
- if (r >= 0) {
+ if (r.intValue() >= 0) {
return getClassLoader().loadClass("org.apache.commons.jexl2.generated." + className);
}
return null;
Modified: commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/ClassCreatorTest.java
URL: http://svn.apache.org/viewvc/commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/ClassCreatorTest.java?rev=889768&r1=889767&r2=889768&view=diff
==============================================================================
--- commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/ClassCreatorTest.java (original)
+++ commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/ClassCreatorTest.java Fri Dec 11 19:04:36 2009
@@ -62,6 +62,7 @@
// A space hog class
static final int MEGA = 1024 * 1024;
public class BigObject {
+ @SuppressWarnings("unused")
private final byte[] space = new byte[MEGA];
private final int id;
Modified: commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/MethodTest.java
URL: http://svn.apache.org/viewvc/commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/MethodTest.java?rev=889768&r1=889767&r2=889768&view=diff
==============================================================================
--- commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/MethodTest.java (original)
+++ commons/proper/jexl/trunk/src/test/java/org/apache/commons/jexl2/MethodTest.java Fri Dec 11 19:04:36 2009
@@ -66,7 +66,7 @@
public void testInvoke() throws Exception {
Functor func = new Functor();
assertEquals(Integer.valueOf(10), JEXL.invokeMethod(func, "ten"));
- assertEquals(Integer.valueOf(42), JEXL.invokeMethod(func, "PLUS20", 22));
+ assertEquals(Integer.valueOf(42), JEXL.invokeMethod(func, "PLUS20", Integer.valueOf(22)));
try {
JEXL.invokeMethod(func, "nonExistentMethod");
fail("method does not exist!");
@@ -74,7 +74,7 @@
// ignore
}
try {
- JEXL.invokeMethod(func, "NPEIfNull", null);
+ JEXL.invokeMethod(func, "NPEIfNull", (Object[]) null);
fail("method should have thrown!");
} catch(Exception xj0) {
// ignore
@@ -146,7 +146,7 @@
o = e.evaluate(jc);
assertEquals("Result is not 20", new Integer(20), o);
- jc.set("pi", Math.PI);
+ jc.set("pi", new Double(Math.PI));
e = JEXL.createExpression("math:cos(pi)");
o = e.evaluate(jc);
assertEquals(Double.valueOf(-1),o);