You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Wang Jie <wa...@cmss.chinamobile.com> on 2017/03/10 02:21:19 UTC
Re: Review Request 57492: Inappropriate kafka log4j configuration
results in too much kafka logs
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57492/
-----------------------------------------------------------
(Updated \u4e09\u6708 10, 2017, 2:21 a.m.)
Review request for Ambari, Andrii Tkach and Jayush Luniya.
Bugs: AMBARI-20390
https://issues.apache.org/jira/browse/AMBARI-20390
Repository: ambari
Description
-------
Inappropriate kafka log4j configuration results in too much kafka logs which are constantly increasing and never be removed.
Besides,DailyRollingFileAppender does not support property:maxBackupIndex and maxFileSize, Only RollingFileAppender supports it.
Suggestion:
Change kafka log4j appender mode from DailyRollingFileAppender to RollingFileAppender.
In this way, it will automatically remove the useless kafka log file.
Diffs
-----
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-log4j.xml 0eed025
Diff: https://reviews.apache.org/r/57492/diff/1/
Testing
-------
Done
Thanks,
Wang Jie
Re: Review Request 57492: Inappropriate kafka log4j configuration
results in too much kafka logs
Posted by Wang Jie <wa...@cmss.chinamobile.com>.
> On \u4e09\u6708 10, 2017, 2:23 a.m., Alejandro Fernandez wrote:
> > Ship It!
Thank you so much for reviewing my patch on reviewboard, and could you commit the patch ? Thanks
- Wang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57492/#review168579
-----------------------------------------------------------
On \u4e09\u6708 10, 2017, 2:21 a.m., Wang Jie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57492/
> -----------------------------------------------------------
>
> (Updated \u4e09\u6708 10, 2017, 2:21 a.m.)
>
>
> Review request for Ambari, Andrii Tkach and Jayush Luniya.
>
>
> Bugs: AMBARI-20390
> https://issues.apache.org/jira/browse/AMBARI-20390
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Inappropriate kafka log4j configuration results in too much kafka logs which are constantly increasing and never be removed.
> Besides,DailyRollingFileAppender does not support property:maxBackupIndex and maxFileSize, Only RollingFileAppender supports it.
>
> Suggestion:
> Change kafka log4j appender mode from DailyRollingFileAppender to RollingFileAppender.
> In this way, it will automatically remove the useless kafka log file.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-log4j.xml 0eed025
>
>
> Diff: https://reviews.apache.org/r/57492/diff/1/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Wang Jie
>
>
Re: Review Request 57492: Inappropriate kafka log4j configuration
results in too much kafka logs
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57492/#review168579
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On March 10, 2017, 2:21 a.m., Wang Jie wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57492/
> -----------------------------------------------------------
>
> (Updated March 10, 2017, 2:21 a.m.)
>
>
> Review request for Ambari, Andrii Tkach and Jayush Luniya.
>
>
> Bugs: AMBARI-20390
> https://issues.apache.org/jira/browse/AMBARI-20390
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Inappropriate kafka log4j configuration results in too much kafka logs which are constantly increasing and never be removed.
> Besides,DailyRollingFileAppender does not support property:maxBackupIndex and maxFileSize, Only RollingFileAppender supports it.
>
> Suggestion:
> Change kafka log4j appender mode from DailyRollingFileAppender to RollingFileAppender.
> In this way, it will automatically remove the useless kafka log file.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-log4j.xml 0eed025
>
>
> Diff: https://reviews.apache.org/r/57492/diff/1/
>
>
> Testing
> -------
>
> Done
>
>
> Thanks,
>
> Wang Jie
>
>