You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/11/28 00:15:51 UTC
Review Request: Fixed cgroup cpuset.cpus parsing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8238/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
Description
-------
The trailing newline in the cgroup.cpus file caused the slave to fail during CgroupIsolationModule initialization.
Diffs
-----
src/slave/cgroups_isolation_module.cpp 0f2975d1adf874dba4d0a539eb5c99233cef6e6b
Diff: https://reviews.apache.org/r/8238/diff/
Testing
-------
make check + deployment
Thanks,
Ben Mahler
Re: Review Request: Fixed cgroup cpuset.cpus parsing.
Posted by Ben Mahler <be...@gmail.com>.
> On Nov. 27, 2012, 11:22 p.m., Vinod Kone wrote:
> > src/slave/cgroups_isolation_module.cpp, line 373
> > <https://reviews.apache.org/r/8238/diff/1/?file=231224#file231224line373>
> >
> > why the trim here and below? are you just being defensive?
yes
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8238/#review13789
-----------------------------------------------------------
On Nov. 27, 2012, 11:15 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8238/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 11:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> The trailing newline in the cgroup.cpus file caused the slave to fail during CgroupIsolationModule initialization.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolation_module.cpp 0f2975d1adf874dba4d0a539eb5c99233cef6e6b
>
> Diff: https://reviews.apache.org/r/8238/diff/
>
>
> Testing
> -------
>
> make check + deployment
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed cgroup cpuset.cpus parsing.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8238/#review13789
-----------------------------------------------------------
src/slave/cgroups_isolation_module.cpp
<https://reviews.apache.org/r/8238/#comment29466>
why the trim here and below? are you just being defensive?
- Vinod Kone
On Nov. 27, 2012, 11:15 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8238/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 11:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> The trailing newline in the cgroup.cpus file caused the slave to fail during CgroupIsolationModule initialization.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolation_module.cpp 0f2975d1adf874dba4d0a539eb5c99233cef6e6b
>
> Diff: https://reviews.apache.org/r/8238/diff/
>
>
> Testing
> -------
>
> make check + deployment
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed cgroup cpuset.cpus parsing.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8238/#review13788
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 27, 2012, 11:15 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8238/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 11:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> The trailing newline in the cgroup.cpus file caused the slave to fail during CgroupIsolationModule initialization.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolation_module.cpp 0f2975d1adf874dba4d0a539eb5c99233cef6e6b
>
> Diff: https://reviews.apache.org/r/8238/diff/
>
>
> Testing
> -------
>
> make check + deployment
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed cgroup cpuset.cpus parsing.
Posted by Joe Smith <js...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8238/#review13787
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On Nov. 27, 2012, 11:15 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8238/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 11:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> The trailing newline in the cgroup.cpus file caused the slave to fail during CgroupIsolationModule initialization.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolation_module.cpp 0f2975d1adf874dba4d0a539eb5c99233cef6e6b
>
> Diff: https://reviews.apache.org/r/8238/diff/
>
>
> Testing
> -------
>
> make check + deployment
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Fixed cgroup cpuset.cpus parsing.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8238/#review14321
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Nov. 27, 2012, 11:15 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8238/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2012, 11:15 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
>
>
> Description
> -------
>
> The trailing newline in the cgroup.cpus file caused the slave to fail during CgroupIsolationModule initialization.
>
>
> Diffs
> -----
>
> src/slave/cgroups_isolation_module.cpp 0f2975d1adf874dba4d0a539eb5c99233cef6e6b
>
> Diff: https://reviews.apache.org/r/8238/diff/
>
>
> Testing
> -------
>
> make check + deployment
>
>
> Thanks,
>
> Ben Mahler
>
>