You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/22 06:03:17 UTC

[GitHub] [iotdb] HTHou commented on a change in pull request #4436: [IOTDB-1984] Upgrade the data migration granularity to device

HTHou commented on a change in pull request #4436:
URL: https://github.com/apache/iotdb/pull/4436#discussion_r753886372



##########
File path: example/session/src/main/java/org/apache/iotdb/DataMigrationExample.java
##########
@@ -174,13 +214,13 @@ public Void call() {
 
       } catch (Exception e) {
         System.out.println(
-            "Loading the " + i + "-th timeseries: " + series + " failed " + e.getMessage());
+            "Loading the " + i + "-th devices: " + device + " failed " + e.getMessage());
         return null;
       } finally {
         readerPool.closeResultSet(dataSet);
       }
 
-      System.out.println("Loading the " + i + "-th timeseries: " + series + " success");
+      System.out.println("Loading the " + i + "-th devices: " + device + " success");

Review comment:
       The printed number of loaded devices is not correct, right? I think the better choice is keeping printing the number of timeseries. 
   
   To implement it, we can use an AtomicInteger or AtomicLong field to record the number of loaded timeseries. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org