You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by "mridulpathak (via GitHub)" <gi...@apache.org> on 2026/10/23 11:34:45 UTC

[PR] Improved: Run the passport user sync with TransactionUtil.doNewTransaction (OFBIZ-13723) [ofbiz-plugins]

mridulpathak opened a new pull request, #463:
URL: https://github.com/apache/ofbiz-plugins/pull/463

   GitHubAuthenticator and LinkedInAuthenticator suspended the current transaction by hand and kept it in a javax.transaction.Transaction variable, which ties the plugin to the javax.transaction API that the framework is moving away from in OFBIZ-13723. They now use TransactionUtil.doNewTransaction, which compiles against both javax.transaction and jakarta.transaction, so this can be merged before the framework change. A failure while creating or updating the user now rolls back that transaction instead of committing the partial work, and a failure to suspend or resume the transaction is reported instead of only logged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Run the passport user sync with TransactionUtil.doNewTransaction (OFBIZ-13723) [ofbiz-plugins]

Posted by "mridulpathak (via GitHub)" <gi...@apache.org>.

mridulpathak merged PR #463:
URL: https://github.com/apache/ofbiz-plugins/pull/463


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Run the passport user sync with TransactionUtil.doNewTransaction (OFBIZ-13723) [ofbiz-plugins]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #463:
URL: https://github.com/apache/ofbiz-plugins/pull/463#issuecomment-6363953312

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=463) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=463&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins&pullRequest=463&issueStatuses=ACCEPTED)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins&pullRequest=463&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=463&metric=new_coverage&view=list)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins&pullRequest=463&metric=new_duplicated_lines_density&view=list)  
     
   <!-- sqra-placement-anchor -->
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-plugins&pullRequest=463)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Run the passport user sync with TransactionUtil.doNewTransaction (OFBIZ-13723) [ofbiz-plugins]

Posted by "mridulpathak (via GitHub)" <gi...@apache.org>.

mridulpathak commented on PR #463:
URL: https://github.com/apache/ofbiz-plugins/pull/463#issuecomment-6370265917

   Thanks for the review @jacopoc.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org