You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-dev@xmlgraphics.apache.org by bu...@apache.org on 2008/09/25 00:56:33 UTC

DO NOT REPLY [Bug 45883] New: Change to style CDATA not detected

https://issues.apache.org/bugzilla/show_bug.cgi?id=45883

           Summary: Change to style CDATA not detected
           Product: Batik
           Version: 1.7
          Platform: Macintosh
        OS/Version: Mac OS X 10.4
            Status: NEW
          Severity: normal
          Priority: P2
         Component: SVG DOM
        AssignedTo: batik-dev@xmlgraphics.apache.org
        ReportedBy: steve@drakenz.com


Created an attachment (id=22632)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22632)
Bug demonstration - square should change colour when clicked.

Changes to the CDATA of a style element are not reflected in a document loaded
in a JSVGComponent.

To reproduce: Load the attached document cdata.svg and click on the square. 
This will run a script to replace the CDATA content of a style element.

Observed: No change.

Expected: The square should alternate between red and blue when clicked.

Workaround:  Replace the entire style element instead of its contents.

Analysis:  I think this is a simple copy-and-paste-o in
SVGOMDocument.DOMCharacterDataModifiedListenerWrapper, which forwards its event
using the subTreeModified(Node) method instead of characterDataModified(Node),
which is what I would have expected.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 45883] Change to style CDATA not detected

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45883





--- Comment #1 from Stephen Drake <st...@drakenz.com>  2008-09-24 15:59:06 PST ---
Created an attachment (id=22633)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22633)
Patch to SVGOMDocument.DOMCharacterDataModifiedListenerWrapper


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org


DO NOT REPLY [Bug 45883] Change to style CDATA not detected

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=45883


Cameron McCormack <ca...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Cameron McCormack <ca...@apache.org>  2008-10-04 07:40:29 PST ---
Patch looks good and has been applied, thanks!  And your analysis is likely
correct.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: batik-dev-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: batik-dev-help@xmlgraphics.apache.org