[jira] [Commented] (GEODE-7698) Create a MemberIdentifier for use in membership only tests

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-7698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17016400#comment-17016400 ] 

ASF subversion and git services commented on GEODE-7698:
--------------------------------------------------------

Commit 5a8b992fdfed8e00d96d508437efbcd2ec59ee6e in geode's branch refs/heads/develop from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=5a8b992 ]

GEODE-7698: Extracting a superclass of InternalDistributedMember

GEODE-7698: Extracting a superclass of InternalDistributedMember

We need a concrete MemberIdentifier implementation in geode-membership
to test membership.

Extracting a superclass of InternalDistributedMember,
MemberIdentifierImpl, which contains pretty much all of the
InternalDistributedMember logic. InternalDistributedMember now just
extends that class and implements DistributedMember.

Removing unecessary use of SocketCreator during IDM deserialization. We were 
using flags and methods on SocketCreator to either change or cache the hostName
that we read off the wire from the remote member. We don't want to do either of
those things during deserialization. We should just keep the hostname we read
as is. This logic was used to change the toString value of ids that come from
clients to use the ip address instead of the hostname. Instead of changing the
deserialization logic, we change the addFixedToString logic.

Check for IP address rather than SocketCreator.resolve_dns in addFixedToString. 
InternalDistributedMember has a dependency on this mutable static flag in it's
to string, which is not ideal. It looks like the intention was to only shorten
the hostname if it is dns name, not an ip address.


> Create a MemberIdentifier for use in membership only tests
> ----------------------------------------------------------
>
>                 Key: GEODE-7698
>                 URL: https://issues.apache.org/jira/browse/GEODE-7698
>             Project: Geode
>          Issue Type: Improvement
>          Components: membership
>            Reporter: Dan Smith
>            Assignee: Dan Smith
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> When we are testing the membership system, we need a MemberIdentifier to use.
> We should refactor the common code out of InternalDistributedMember so that we have a member identifier that is in the product code for use with membership.
> Perhaps it would be enough to move all of the InternalDistributedMember logic into a MembershipIdentifierImpl and have InternalDistributedMember extend that?
> Acceptance Criteria:
> Remove the TODO from MembershipOnlyTest related to using InternalDistributedMember



--
This message was sent by Atlassian Jira
(v8.3.4#803005)