You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/04/20 01:43:56 UTC

[GitHub] [incubator-kyuubi] jiaoqingbo opened a new pull request, #2425: [KYUUBI #2424] [Improvement] add Flink compile version and Trino client compile version to KyuubiServer Log

jiaoqingbo opened a new pull request, #2425:
URL: https://github.com/apache/incubator-kyuubi/pull/2425

   
   
   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   fix #2424 
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2425: [KYUUBI #2424] [Improvement] add Flink compile version and Trino client compile version to KyuubiServer Log

Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #2425:
URL: https://github.com/apache/incubator-kyuubi/pull/2425#issuecomment-1104808678

   Thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 closed pull request #2425: [KYUUBI #2424] [Improvement] add Flink compile version and Trino client compile version to KyuubiServer Log

Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #2425: [KYUUBI #2424] [Improvement] add Flink compile version and Trino client compile version to KyuubiServer Log
URL: https://github.com/apache/incubator-kyuubi/pull/2425


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] SteNicholas commented on a diff in pull request #2425: [KYUUBI #2424] [Improvement] add Flink compile version and Trino client compile version to KyuubiServer Log

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #2425:
URL: https://github.com/apache/incubator-kyuubi/pull/2425#discussion_r854341244


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiServer.scala:
##########
@@ -122,7 +122,8 @@ object KyuubiServer extends Logging {
     info(s"Version: $KYUUBI_VERSION, Revision: $REVISION, Branch: $BRANCH," +
       s" Java: $JAVA_COMPILE_VERSION, Scala: $SCALA_COMPILE_VERSION," +
       s" Spark: $SPARK_COMPILE_VERSION, Hadoop: $HADOOP_COMPILE_VERSION," +
-      s" Hive: $HIVE_COMPILE_VERSION")
+      s" Hive: $HIVE_COMPILE_VERSION, Flink: $FLINK_COMPILE_VERSION," +
+      s" Trino Client: $TRINO_CLIENT_COMPILE_VERSION")

Review Comment:
   ```suggestion
         s" Trino: $TRINO_COMPILE_VERSION")
   ```



##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiServer.scala:
##########
@@ -122,7 +122,8 @@ object KyuubiServer extends Logging {
     info(s"Version: $KYUUBI_VERSION, Revision: $REVISION, Branch: $BRANCH," +
       s" Java: $JAVA_COMPILE_VERSION, Scala: $SCALA_COMPILE_VERSION," +
       s" Spark: $SPARK_COMPILE_VERSION, Hadoop: $HADOOP_COMPILE_VERSION," +
-      s" Hive: $HIVE_COMPILE_VERSION")
+      s" Hive: $HIVE_COMPILE_VERSION, Flink: $FLINK_COMPILE_VERSION," +
+      s" Trino Client: $TRINO_CLIENT_COMPILE_VERSION")

Review Comment:
   ```suggestion
         s" Trino: $TRINO_COMPILE_VERSION")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2425: [KYUUBI #2424] [Improvement] add Flink compile version and Trino client compile version to KyuubiServer Log

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2425:
URL: https://github.com/apache/incubator-kyuubi/pull/2425#issuecomment-1103398955

   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2425](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6af3dd0) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/6017917100c59e444dd7a9f89845106cd8616735?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6017917) will **decrease** coverage by `0.01%`.
   > The diff coverage is `66.66%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2425      +/-   ##
   ============================================
   - Coverage     62.92%   62.91%   -0.02%     
     Complexity       69       69              
   ============================================
     Files           362      362              
     Lines         17293    17299       +6     
     Branches       2334     2334              
   ============================================
   + Hits          10882    10884       +2     
   - Misses         5387     5391       +4     
     Partials       1024     1024              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../scala/org/apache/kyuubi/server/KyuubiServer.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvS3l1dWJpU2VydmVyLnNjYWxh) | `64.13% <0.00%> (-0.71%)` | :arrow_down: |
   | [...mon/src/main/scala/org/apache/kyuubi/package.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9wYWNrYWdlLnNjYWxh) | `90.00% <100.00%> (+1.11%)` | :arrow_up: |
   | [...org/apache/kyuubi/ha/client/ServiceDiscovery.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2hhL2NsaWVudC9TZXJ2aWNlRGlzY292ZXJ5LnNjYWxh) | `83.33% <0.00%> (-8.34%)` | :arrow_down: |
   | [.../org/apache/kyuubi/engine/hive/HiveSQLEngine.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvSGl2ZVNRTEVuZ2luZS5zY2FsYQ==) | `74.60% <0.00%> (-1.21%)` | :arrow_down: |
   | [...ala/org/apache/kyuubi/session/SessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL1Nlc3Npb25NYW5hZ2VyLnNjYWxh) | `86.52% <0.00%> (ø)` | |
   | [...g/apache/kyuubi/session/KyuubiSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25NYW5hZ2VyLnNjYWxh) | `85.91% <0.00%> (ø)` | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [6017917...6af3dd0](https://codecov.io/gh/apache/incubator-kyuubi/pull/2425?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] jiaoqingbo commented on pull request #2425: [KYUUBI #2424] [Improvement] add Flink compile version and Trino client compile version to KyuubiServer Log

Posted by GitBox <gi...@apache.org>.
jiaoqingbo commented on PR #2425:
URL: https://github.com/apache/incubator-kyuubi/pull/2425#issuecomment-1103424144

   cc @pan3793 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] SteNicholas commented on a diff in pull request #2425: [KYUUBI #2424] [Improvement] add Flink compile version and Trino client compile version to KyuubiServer Log

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #2425:
URL: https://github.com/apache/incubator-kyuubi/pull/2425#discussion_r854342060


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/package.scala:
##########
@@ -61,6 +63,8 @@ package object kyuubi {
   val SPARK_COMPILE_VERSION: String = BuildInfo.spark_version
   val HIVE_COMPILE_VERSION: String = BuildInfo.hive_version
   val HADOOP_COMPILE_VERSION: String = BuildInfo.hadoop_version
+  val FLINK_COMPILE_VERSION: String = BuildInfo.flink_version
+  val TRINO_CLIENT_COMPILE_VERSION: String = BuildInfo.trino_client_version

Review Comment:
   ```suggestion
     val TRINO_COMPILE_VERSION: String = BuildInfo.trino_client_version
   ```



##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiServer.scala:
##########
@@ -122,7 +122,8 @@ object KyuubiServer extends Logging {
     info(s"Version: $KYUUBI_VERSION, Revision: $REVISION, Branch: $BRANCH," +
       s" Java: $JAVA_COMPILE_VERSION, Scala: $SCALA_COMPILE_VERSION," +
       s" Spark: $SPARK_COMPILE_VERSION, Hadoop: $HADOOP_COMPILE_VERSION," +
-      s" Hive: $HIVE_COMPILE_VERSION")
+      s" Hive: $HIVE_COMPILE_VERSION, Flink: $FLINK_COMPILE_VERSION," +
+      s" Trino Client: $TRINO_CLIENT_COMPILE_VERSION")

Review Comment:
   ```suggestion
         s" Trino: $TRINO_COMPILE_VERSION")
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] SteNicholas commented on a diff in pull request #2425: [KYUUBI #2424] [Improvement] add Flink compile version and Trino client compile version to KyuubiServer Log

Posted by GitBox <gi...@apache.org>.
SteNicholas commented on code in PR #2425:
URL: https://github.com/apache/incubator-kyuubi/pull/2425#discussion_r854340211


##########
build/kyuubi-build-info:
##########
@@ -28,6 +28,8 @@ echo_build_properties() {
   echo kyuubi_spark_version="$5"
   echo kyuubi_hive_version="$6"
   echo kyuubi_hadoop_version="$7"
+  echo kyuubi_flink_version="$8"
+  echo kyuubi_trino_client_version="$9"

Review Comment:
   ```suggestion
     echo kyuubi_trino_version="$9"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org