You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by David Medinets <da...@gmail.com> on 2012/08/23 06:01:04 UTC
Please review check-ins
Both of the following jira tickets are related to unclosed objects.
The changes were fairly simply and the code compiled after my change.
I did not create any tests or execute the code. If someone can do a
review after a 'svn update', I'd appreciate it.
https://issues.apache.org/jira/browse/ACCUMULO-737
https://issues.apache.org/jira/browse/ACCUMULO-738
Thanks
Re: Please review check-ins
Posted by John Vines <vi...@apache.org>.
If you use eclipse, there is a style provirdes in the contrib directory. If
you use something else, we should see about creating a codestyle for it so
encourage more developers to engage.
Sent from my phone, so pardon the typos and brevity.
On Aug 23, 2012 12:40 PM, "David Medinets" <da...@gmail.com> wrote:
> Sorry about the indenting. I need to find a tool to reformat. I
> haven't using FileDataIngest yet. I suppose I should check that some
> automated test exists for it. I'll look.
>
> On Thu, Aug 23, 2012 at 11:03 AM, Keith Turner <ke...@deenlo.com> wrote:
> > David,
> >
> > The indentation of bcfile.PrintInfo inside the try block is not
> > correct. Please indent. I ran bcfile.PrintInfo and it worked ok.
> >
> > FileDataIngest looks ok. Can you try running to ensure it still works?
> >
> > Keith
> >
> > On Thu, Aug 23, 2012 at 12:01 AM, David Medinets
> > <da...@gmail.com> wrote:
> >> Both of the following jira tickets are related to unclosed objects.
> >> The changes were fairly simply and the code compiled after my change.
> >> I did not create any tests or execute the code. If someone can do a
> >> review after a 'svn update', I'd appreciate it.
> >>
> >> https://issues.apache.org/jira/browse/ACCUMULO-737
> >> https://issues.apache.org/jira/browse/ACCUMULO-738
> >>
> >> Thanks
>
Re: Please review check-ins
Posted by David Medinets <da...@gmail.com>.
Sorry about the indenting. I need to find a tool to reformat. I
haven't using FileDataIngest yet. I suppose I should check that some
automated test exists for it. I'll look.
On Thu, Aug 23, 2012 at 11:03 AM, Keith Turner <ke...@deenlo.com> wrote:
> David,
>
> The indentation of bcfile.PrintInfo inside the try block is not
> correct. Please indent. I ran bcfile.PrintInfo and it worked ok.
>
> FileDataIngest looks ok. Can you try running to ensure it still works?
>
> Keith
>
> On Thu, Aug 23, 2012 at 12:01 AM, David Medinets
> <da...@gmail.com> wrote:
>> Both of the following jira tickets are related to unclosed objects.
>> The changes were fairly simply and the code compiled after my change.
>> I did not create any tests or execute the code. If someone can do a
>> review after a 'svn update', I'd appreciate it.
>>
>> https://issues.apache.org/jira/browse/ACCUMULO-737
>> https://issues.apache.org/jira/browse/ACCUMULO-738
>>
>> Thanks
Re: Please review check-ins
Posted by Keith Turner <ke...@deenlo.com>.
David,
The indentation of bcfile.PrintInfo inside the try block is not
correct. Please indent. I ran bcfile.PrintInfo and it worked ok.
FileDataIngest looks ok. Can you try running to ensure it still works?
Keith
On Thu, Aug 23, 2012 at 12:01 AM, David Medinets
<da...@gmail.com> wrote:
> Both of the following jira tickets are related to unclosed objects.
> The changes were fairly simply and the code compiled after my change.
> I did not create any tests or execute the code. If someone can do a
> review after a 'svn update', I'd appreciate it.
>
> https://issues.apache.org/jira/browse/ACCUMULO-737
> https://issues.apache.org/jira/browse/ACCUMULO-738
>
> Thanks
Re: Please review check-ins
Posted by John Vines <vi...@apache.org>.
They look kosher to me
On Thu, Aug 23, 2012 at 8:25 AM, Keith Turner <ke...@deenlo.com> wrote:
> I will take a look at them. If they did not have test, then you
> probably do not need to add test when making improvements like this.
> I would recommend at least executing the code though. Many times I
> have made what I thought were simple changes and it blew up for some
> reason.
>
> On Thu, Aug 23, 2012 at 12:01 AM, David Medinets
> <da...@gmail.com> wrote:
> > Both of the following jira tickets are related to unclosed objects.
> > The changes were fairly simply and the code compiled after my change.
> > I did not create any tests or execute the code. If someone can do a
> > review after a 'svn update', I'd appreciate it.
> >
> > https://issues.apache.org/jira/browse/ACCUMULO-737
> > https://issues.apache.org/jira/browse/ACCUMULO-738
> >
> > Thanks
>
Re: Please review check-ins
Posted by Keith Turner <ke...@deenlo.com>.
I will take a look at them. If they did not have test, then you
probably do not need to add test when making improvements like this.
I would recommend at least executing the code though. Many times I
have made what I thought were simple changes and it blew up for some
reason.
On Thu, Aug 23, 2012 at 12:01 AM, David Medinets
<da...@gmail.com> wrote:
> Both of the following jira tickets are related to unclosed objects.
> The changes were fairly simply and the code compiled after my change.
> I did not create any tests or execute the code. If someone can do a
> review after a 'svn update', I'd appreciate it.
>
> https://issues.apache.org/jira/browse/ACCUMULO-737
> https://issues.apache.org/jira/browse/ACCUMULO-738
>
> Thanks