You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/09/30 16:38:05 UTC

[GitHub] [trafficserver] SolidWallOfCode commented on a diff in pull request #9114: Add event loop timing histogram data.

SolidWallOfCode commented on code in PR #9114:
URL: https://github.com/apache/trafficserver/pull/9114#discussion_r984771313


##########
proxy/http/HttpSM.cc:
##########
@@ -8457,5 +8454,7 @@ HttpSM::milestone_update_api_time()
       }
       milestones[TS_MILESTONE_PLUGIN_ACTIVE] += delta;
     }
+    this_ethread()->metrics._api_timing(
+      delta / std::chrono::duration_cast<std::chrono::nanoseconds>(EThread::Metrics::API_HISTOGRAM_BUCKET_SIZE).count());

Review Comment:
   Technically using a leading underscore for member variables is an ATS standard, which I try to promote.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org