You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Sijie Guo (JIRA)" <ji...@apache.org> on 2012/07/09 10:59:35 UTC

[jira] [Created] (BOOKKEEPER-332) Add SubscriptionPreferences to record all preferences for a subscription

Sijie Guo created BOOKKEEPER-332:
------------------------------------

             Summary: Add SubscriptionPreferences to record all preferences for a subscription
                 Key: BOOKKEEPER-332
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-332
             Project: Bookkeeper
          Issue Type: Sub-task
          Components: hedwig-server
            Reporter: Sijie Guo
            Assignee: Sijie Guo
             Fix For: 4.2.0


Add SubscriptionPreferences to record the preferences for a subscription. This jira includes:
1) add SubscriptionPreferences protocol.
2) separated preferences from subscription state to decouple infrequent-changed data from frequent changed data (like lastConsumedSeqId).
3) add backward testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-332) Add SubscriptionPreferences to record all preferences for a subscription

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo updated BOOKKEEPER-332:
---------------------------------

    Attachment: BOOKKEEPER-332.diff

sorry. I attached a wrong patch. attach the right one.
                
> Add SubscriptionPreferences to record all preferences for a subscription
> ------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-332
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-332
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: hedwig-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-332.diff, BOOKKEEPER-332.patch, BOOKKEEPER-332.patch
>
>
> Add SubscriptionPreferences to record the preferences for a subscription. This jira includes:
> 1) add SubscriptionPreferences protocol.
> 2) separated preferences from subscription state to decouple infrequent-changed data from frequent changed data (like lastConsumedSeqId).
> 3) add backward testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-332) Add SubscriptionPreferences to record all preferences for a subscription

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436642#comment-13436642 ] 

Ivan Kelly commented on BOOKKEEPER-332:
---------------------------------------

This doesn't apply on trunk. It seems to contain BOOKKEEPER-340 also.
                
> Add SubscriptionPreferences to record all preferences for a subscription
> ------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-332
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-332
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: hedwig-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-332.patch, BOOKKEEPER-332.patch
>
>
> Add SubscriptionPreferences to record the preferences for a subscription. This jira includes:
> 1) add SubscriptionPreferences protocol.
> 2) separated preferences from subscription state to decouple infrequent-changed data from frequent changed data (like lastConsumedSeqId).
> 3) add backward testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-332) Add SubscriptionPreferences to record all preferences for a subscription

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo updated BOOKKEEPER-332:
---------------------------------

    Attachment: BOOKKEEPER-332.patch

attach a new patch, which based on BOOKKEEPER-283 and BOOKKEEPER-338, which removes backward compatible related staffs after BOOKKEEPER-340 is in.

please review BOOKKEEPER-283, BOOKKEEPER-338 and this one in order.
                
> Add SubscriptionPreferences to record all preferences for a subscription
> ------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-332
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-332
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: hedwig-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-332.patch, BOOKKEEPER-332.patch
>
>
> Add SubscriptionPreferences to record the preferences for a subscription. This jira includes:
> 1) add SubscriptionPreferences protocol.
> 2) separated preferences from subscription state to decouple infrequent-changed data from frequent changed data (like lastConsumedSeqId).
> 3) add backward testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-332) Add SubscriptionPreferences to record all preferences for a subscription

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436827#comment-13436827 ] 

Hudson commented on BOOKKEEPER-332:
-----------------------------------

Integrated in bookkeeper-trunk #654 (See [https://builds.apache.org/job/bookkeeper-trunk/654/])
    BOOKKEEPER-332: Add SubscriptionPreferences to record all preferences for a subscription (sijie via ivank) [missing files] (Revision 1374327)
BOOKKEEPER-332: Add SubscriptionPreferences to record all preferences for a subscription (sijie via ivank) (Revision 1374321)

     Result = ABORTED
ivank : 
Files : 
* /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/MapUtils.java

ivank : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/pom.xml
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/lib/data.cpp
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/lib/data.h
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/cpp/test/messageboundtest.cpp
* /zookeeper/bookkeeper/trunk/hedwig-client/src/main/java/org/apache/hedwig/client/netty/HedwigSubscriber.java
* /zookeeper/bookkeeper/trunk/hedwig-protocol/pom.xml
* /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/java/org/apache/hedwig/protocol/PubSubProtocol.java
* /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/SubscriptionStateUtils.java
* /zookeeper/bookkeeper/trunk/hedwig-protocol/src/main/protobuf/PubSubProtocol.proto
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/meta/SubscriptionDataManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/meta/ZkMetadataManagerFactory.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/InMemorySubscriptionManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/InMemorySubscriptionState.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/MMSubscriptionManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/TestBackwardCompat.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/meta/TestMetadataManager.java
* /zookeeper/bookkeeper/trunk/hedwig-server/src/test/java/org/apache/hedwig/server/persistence/MessageBoundedPersistenceTest.java

                
> Add SubscriptionPreferences to record all preferences for a subscription
> ------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-332
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-332
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: hedwig-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-332.diff, BOOKKEEPER-332.patch, BOOKKEEPER-332.patch
>
>
> Add SubscriptionPreferences to record the preferences for a subscription. This jira includes:
> 1) add SubscriptionPreferences protocol.
> 2) separated preferences from subscription state to decouple infrequent-changed data from frequent changed data (like lastConsumedSeqId).
> 3) add backward testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-332) Add SubscriptionPreferences to record all preferences for a subscription

Posted by "Sijie Guo (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sijie Guo updated BOOKKEEPER-332:
---------------------------------

    Attachment: BOOKKEEPER-332.patch

add subscription preferences in subscription data. it did clear up existed subscription options to make it more clearly and also separating SubscriptionState (frequently updated) and SubscriptionPreferences (infrequently updated).

with benefits, it replaced several tabs with spaces in proto file and pom file. 

the patch is generated based on BOOKKEEPER-78, since there is protobuf changes.
                
> Add SubscriptionPreferences to record all preferences for a subscription
> ------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-332
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-332
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: hedwig-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-332.patch
>
>
> Add SubscriptionPreferences to record the preferences for a subscription. This jira includes:
> 1) add SubscriptionPreferences protocol.
> 2) separated preferences from subscription state to decouple infrequent-changed data from frequent changed data (like lastConsumedSeqId).
> 3) add backward testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-332) Add SubscriptionPreferences to record all preferences for a subscription

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436806#comment-13436806 ] 

Ivan Kelly commented on BOOKKEEPER-332:
---------------------------------------

Added missing file in r1374327.
                
> Add SubscriptionPreferences to record all preferences for a subscription
> ------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-332
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-332
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: hedwig-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-332.diff, BOOKKEEPER-332.patch, BOOKKEEPER-332.patch
>
>
> Add SubscriptionPreferences to record the preferences for a subscription. This jira includes:
> 1) add SubscriptionPreferences protocol.
> 2) separated preferences from subscription state to decouple infrequent-changed data from frequent changed data (like lastConsumedSeqId).
> 3) add backward testing.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira