You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "ericm-db (via GitHub)" <gi...@apache.org> on 2024/11/27 23:54:12 UTC
[PR] [SPARK-50443] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [spark]
ericm-db opened a new pull request, #48996:
URL: https://github.com/apache/spark/pull/48996
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
There are maven errors introduced by the guava dependency in `sql/core`, as we use the Guava cache to store the Avro encoders, outlined in this comment: https://github.com/apache/spark/pull/48401#issuecomment-2504353098
Change this to use a concurrent hashmap instead.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To resolve maven build errors, so that the Avro change here: https://github.com/apache/spark/pull/48401 does not get reverted.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing unit tests are sufficient and maven build works on devbox
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50443] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on code in PR #48996:
URL: https://github.com/apache/spark/pull/48996#discussion_r1861391725
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -614,14 +613,9 @@ object RocksDBStateStoreProvider {
private val MAX_AVRO_ENCODERS_IN_CACHE = 1000
// Add the cache at companion object level so it persists across provider instances
- private val avroEncoderMap: NonFateSharingCache[String, AvroEncoder] = {
- val guavaCache = CacheBuilder.newBuilder()
- .maximumSize(MAX_AVRO_ENCODERS_IN_CACHE) // Adjust size based on your needs
- .expireAfterAccess(1, TimeUnit.HOURS) // Optional: Add expiration if needed
- .build[String, AvroEncoder]()
-
- new NonFateSharingCache(guavaCache)
Review Comment:
Thanks @LuciferYang, this works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50443] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #48996:
URL: https://github.com/apache/spark/pull/48996#discussion_r1861366105
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -614,14 +613,9 @@ object RocksDBStateStoreProvider {
private val MAX_AVRO_ENCODERS_IN_CACHE = 1000
// Add the cache at companion object level so it persists across provider instances
- private val avroEncoderMap: NonFateSharingCache[String, AvroEncoder] = {
- val guavaCache = CacheBuilder.newBuilder()
- .maximumSize(MAX_AVRO_ENCODERS_IN_CACHE) // Adjust size based on your needs
- .expireAfterAccess(1, TimeUnit.HOURS) // Optional: Add expiration if needed
- .build[String, AvroEncoder]()
-
- new NonFateSharingCache(guavaCache)
Review Comment:
Actually, I suspect the root cause is similar to SPARK-44064.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50443] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #48996:
URL: https://github.com/apache/spark/pull/48996#discussion_r1861377112
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -614,14 +613,9 @@ object RocksDBStateStoreProvider {
private val MAX_AVRO_ENCODERS_IN_CACHE = 1000
// Add the cache at companion object level so it persists across provider instances
- private val avroEncoderMap: NonFateSharingCache[String, AvroEncoder] = {
- val guavaCache = CacheBuilder.newBuilder()
- .maximumSize(MAX_AVRO_ENCODERS_IN_CACHE) // Adjust size based on your needs
- .expireAfterAccess(1, TimeUnit.HOURS) // Optional: Add expiration if needed
- .build[String, AvroEncoder]()
-
- new NonFateSharingCache(guavaCache)
Review Comment:
In more detail, this is because during the Maven test process, the `sql/core` module uses the shaded `core` module. The shaded `core` module has relocation `com.google.common` to `org.sparkproject.guava`.
As a result, the `com.google.common.cache.Cache` in the `NonFateSharingCache` constructor has been relocation to `org.sparkproject.guava.cache.Cache`, which leads to Maven test error in the current scenario.
So, if we add a new apply function unrelated to Guava in `NonFateSharingCache`, such as
```scala
def apply[K, V](
maximumSize: Long,
expireAfterAccessTime: Long,
expireAfterAccessTimeUnit: TimeUnit): NonFateSharingCache[K, V] = {
val builder = CacheBuilder.newBuilder().asInstanceOf[CacheBuilder[K, V]]
if (maximumSize > 0L) {
builder.maximumSize(maximumSize)
}
if(expireAfterAccessTime > 0) {
builder.expireAfterAccess(expireAfterAccessTime, expireAfterAccessTimeUnit)
}
new NonFateSharingCache(builder.build[K, V]())
}
```
and use the newly defined apply function to construct `NonFateSharingCache`, like `NonFateSharingCache(MAX_AVRO_ENCODERS_IN_CACHE, 1, TimeUnit.HOURS)` it should be able to avoid this testing issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50443][SS] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR closed pull request #48996: [SPARK-50443][SS] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider
URL: https://github.com/apache/spark/pull/48996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50443] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on code in PR #48996:
URL: https://github.com/apache/spark/pull/48996#discussion_r1861369111
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -614,14 +613,9 @@ object RocksDBStateStoreProvider {
private val MAX_AVRO_ENCODERS_IN_CACHE = 1000
// Add the cache at companion object level so it persists across provider instances
- private val avroEncoderMap: NonFateSharingCache[String, AvroEncoder] = {
- val guavaCache = CacheBuilder.newBuilder()
- .maximumSize(MAX_AVRO_ENCODERS_IN_CACHE) // Adjust size based on your needs
- .expireAfterAccess(1, TimeUnit.HOURS) // Optional: Add expiration if needed
- .build[String, AvroEncoder]()
-
- new NonFateSharingCache(guavaCache)
- }
+ // TODO: SPARK-50442 - Use Guava Cache to store Avro encoders instead of concurrent
Review Comment:
Okay updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50443] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on code in PR #48996:
URL: https://github.com/apache/spark/pull/48996#discussion_r1861365940
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -614,14 +613,9 @@ object RocksDBStateStoreProvider {
private val MAX_AVRO_ENCODERS_IN_CACHE = 1000
// Add the cache at companion object level so it persists across provider instances
- private val avroEncoderMap: NonFateSharingCache[String, AvroEncoder] = {
- val guavaCache = CacheBuilder.newBuilder()
- .maximumSize(MAX_AVRO_ENCODERS_IN_CACHE) // Adjust size based on your needs
- .expireAfterAccess(1, TimeUnit.HOURS) // Optional: Add expiration if needed
- .build[String, AvroEncoder]()
-
- new NonFateSharingCache(guavaCache)
- }
+ // TODO: SPARK-50442 - Use Guava Cache to store Avro encoders instead of concurrent
Review Comment:
nit: let's explicitly mention about the context which issue we had in the JIRA ticket, and also explicitly mention that CI PR is not sufficient; and the step to verify the new PR (running test with maven).
You don't need to change the code here but let's still ensure that JIRA has sufficient info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50443] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on code in PR #48996:
URL: https://github.com/apache/spark/pull/48996#discussion_r1861377112
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -614,14 +613,9 @@ object RocksDBStateStoreProvider {
private val MAX_AVRO_ENCODERS_IN_CACHE = 1000
// Add the cache at companion object level so it persists across provider instances
- private val avroEncoderMap: NonFateSharingCache[String, AvroEncoder] = {
- val guavaCache = CacheBuilder.newBuilder()
- .maximumSize(MAX_AVRO_ENCODERS_IN_CACHE) // Adjust size based on your needs
- .expireAfterAccess(1, TimeUnit.HOURS) // Optional: Add expiration if needed
- .build[String, AvroEncoder]()
-
- new NonFateSharingCache(guavaCache)
Review Comment:
In more detail, this is because during the Maven test process, the `sql/core` module uses the shaded `core` module. The shaded `core` module has relocation `com.google.common` to `org.sparkproject.guava`.
As a result, the `com.google.common.cache.Cache` in the `NonFateSharingCache` constructor has been relocation to `org.sparkproject.guava.cache.Cache`, which leads to Maven test error in the current scenario.
So, if we add a new apply function unrelated to Guava types in `NonFateSharingCache`, such as
```scala
def apply[K, V](
maximumSize: Long,
expireAfterAccessTime: Long,
expireAfterAccessTimeUnit: TimeUnit): NonFateSharingCache[K, V] = {
val builder = CacheBuilder.newBuilder().asInstanceOf[CacheBuilder[K, V]]
if (maximumSize > 0L) {
builder.maximumSize(maximumSize)
}
if(expireAfterAccessTime > 0) {
builder.expireAfterAccess(expireAfterAccessTime, expireAfterAccessTimeUnit)
}
new NonFateSharingCache(builder.build[K, V]())
}
```
and use the newly defined apply function to construct `NonFateSharingCache`, like `NonFateSharingCache(MAX_AVRO_ENCODERS_IN_CACHE, 1, TimeUnit.HOURS)` it should be able to avoid this testing issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50443][SS] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #48996:
URL: https://github.com/apache/spark/pull/48996#issuecomment-2505209984
Kudos to @LuciferYang providing the better way to fix this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50443][SS] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [spark]
Posted by "HeartSaVioR (via GitHub)" <gi...@apache.org>.
HeartSaVioR commented on PR #48996:
URL: https://github.com/apache/spark/pull/48996#issuecomment-2505209160
CI passed. Thanks! Merging to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-50443] Fixing Maven build errors introduced by Guava cache in RocksDBStateStoreProvider [spark]
Posted by "ericm-db (via GitHub)" <gi...@apache.org>.
ericm-db commented on code in PR #48996:
URL: https://github.com/apache/spark/pull/48996#discussion_r1861391725
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala:
##########
@@ -614,14 +613,9 @@ object RocksDBStateStoreProvider {
private val MAX_AVRO_ENCODERS_IN_CACHE = 1000
// Add the cache at companion object level so it persists across provider instances
- private val avroEncoderMap: NonFateSharingCache[String, AvroEncoder] = {
- val guavaCache = CacheBuilder.newBuilder()
- .maximumSize(MAX_AVRO_ENCODERS_IN_CACHE) // Adjust size based on your needs
- .expireAfterAccess(1, TimeUnit.HOURS) // Optional: Add expiration if needed
- .build[String, AvroEncoder]()
-
- new NonFateSharingCache(guavaCache)
Review Comment:
Thanks @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org