You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by iv...@apache.org on 2007/05/10 05:02:54 UTC
svn commit: r536736 -
/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
Author: ivaynberg
Date: Wed May 9 20:02:53 2007
New Revision: 536736
URL: http://svn.apache.org/viewvc?view=rev&rev=536736
Log:
dont know why initialize() was commented out, but it left componentmap uninitialized, which led to component lookup failures.
Modified:
incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
Modified: incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
URL: http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java?view=diff&rev=536736&r1=536735&r2=536736
==============================================================================
--- incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java (original)
+++ incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java Wed May 9 20:02:53 2007
@@ -81,7 +81,7 @@
merge(markup, baseMarkup, extendIndex);
// Initialize internals based on new markup
-// initialize();
+ initialize();
if (log.isDebugEnabled())
{
Re: svn commit: r536736 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
Posted by Juergen Donnerstag <ju...@gmail.com>.
sorry, I forgot to uncomment it. Interesting that no junit test failed
-> we definitely should add one to avoid such fauxpage in the future.
The change is part of a (small) step by step change towards markup fragments.
Juergen
On 5/10/07, Igor Vaynberg <ig...@gmail.com> wrote:
> juergen, did you forget to uncomment it or was there a bigger plan at work?
>
> -igor
>
>
> On 5/9/07, ivaynberg@apache.org <iv...@apache.org> wrote:
> >
> > Author: ivaynberg
> > Date: Wed May 9 20:02:53 2007
> > New Revision: 536736
> >
> > URL: http://svn.apache.org/viewvc?view=rev&rev=536736
> > Log:
> > dont know why initialize() was commented out, but it left componentmap
> > uninitialized, which led to component lookup failures.
> >
> > Modified:
> > incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
> >
> > Modified: incubator/wicket/trunk/jdk-1.4
> > /wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
> > URL:
> > http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java?view=diff&rev=536736&r1=536735&r2=536736
> >
> > ==============================================================================
> > --- incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
> > (original)
> > +++ incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
> > Wed May 9 20:02:53 2007
> > @@ -81,7 +81,7 @@
> > merge(markup, baseMarkup, extendIndex);
> >
> > // Initialize internals based on new markup
> > -// initialize();
> > + initialize();
> >
> > if (log.isDebugEnabled())
> > {
> >
> >
> >
>
Re: svn commit: r536736 - /incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
Posted by Igor Vaynberg <ig...@gmail.com>.
juergen, did you forget to uncomment it or was there a bigger plan at work?
-igor
On 5/9/07, ivaynberg@apache.org <iv...@apache.org> wrote:
>
> Author: ivaynberg
> Date: Wed May 9 20:02:53 2007
> New Revision: 536736
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=536736
> Log:
> dont know why initialize() was commented out, but it left componentmap
> uninitialized, which led to component lookup failures.
>
> Modified:
> incubator/wicket/trunk/jdk-1.4
> /wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
>
> Modified: incubator/wicket/trunk/jdk-1.4
> /wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
> URL:
> http://svn.apache.org/viewvc/incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java?view=diff&rev=536736&r1=536735&r2=536736
>
> ==============================================================================
> --- incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
> (original)
> +++ incubator/wicket/trunk/jdk-1.4/wicket/src/main/java/org/apache/wicket/markup/MergedMarkup.java
> Wed May 9 20:02:53 2007
> @@ -81,7 +81,7 @@
> merge(markup, baseMarkup, extendIndex);
>
> // Initialize internals based on new markup
> -// initialize();
> + initialize();
>
> if (log.isDebugEnabled())
> {
>
>
>