You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/22 21:34:18 UTC

[GitHub] [beam] rainwoodman commented on a diff in pull request #16351: Fix default type inference of CombinePerKey.

rainwoodman commented on code in PR #16351:
URL: https://github.com/apache/beam/pull/16351#discussion_r904254130


##########
sdks/python/apache_beam/transforms/core.py:
##########
@@ -687,7 +688,7 @@ def default_type_hints(self):
   def infer_output_type(self, input_type):
     # TODO(BEAM-8247): Side inputs types.
     return trivial_inference.element_type(
-        self._strip_output_annotations(

Review Comment:
   Yes. We can and I did so. Not sure how I missed deleting it. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org