You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@synapse.apache.org by hi...@apache.org on 2016/05/27 21:02:43 UTC
svn commit: r1745816 - in /synapse/trunk/java/modules/core/src:
main/java/org/apache/synapse/util/xpath/Base64DecodeFunction.java
test/java/org/apache/synapse/util/xpath/Base64DecodeFunctionTest.java
Author: hiranya
Date: Fri May 27 21:02:43 2016
New Revision: 1745816
URL: http://svn.apache.org/viewvc?rev=1745816&view=rev
Log:
Removing unnecessary charset while decoding b64 string; SYNAPSE-1012
Modified:
synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/xpath/Base64DecodeFunction.java
synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/util/xpath/Base64DecodeFunctionTest.java
Modified: synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/xpath/Base64DecodeFunction.java
URL: http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/xpath/Base64DecodeFunction.java?rev=1745816&r1=1745815&r2=1745816&view=diff
==============================================================================
--- synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/xpath/Base64DecodeFunction.java (original)
+++ synapse/trunk/java/modules/core/src/main/java/org/apache/synapse/util/xpath/Base64DecodeFunction.java Fri May 27 21:02:43 2016
@@ -82,15 +82,7 @@ public class Base64DecodeFunction implem
return SynapseXPathConstants.NULL_STRING;
}
- byte[] decodedValue;
- try {
- decodedValue = new Base64().decode(value.getBytes(charset));
- } catch (UnsupportedEncodingException e) {
- String msg = "Unsupported Charset";
- log.error(msg, e);
- throw new FunctionCallException(msg, e);
- }
-
+ byte[] decodedValue = new Base64().decode(value);
String decodedString;
try {
decodedString = new String(decodedValue, charset).trim();
Modified: synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/util/xpath/Base64DecodeFunctionTest.java
URL: http://svn.apache.org/viewvc/synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/util/xpath/Base64DecodeFunctionTest.java?rev=1745816&r1=1745815&r2=1745816&view=diff
==============================================================================
--- synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/util/xpath/Base64DecodeFunctionTest.java (original)
+++ synapse/trunk/java/modules/core/src/test/java/org/apache/synapse/util/xpath/Base64DecodeFunctionTest.java Fri May 27 21:02:43 2016
@@ -19,7 +19,6 @@
package org.apache.synapse.util.xpath;
-import junit.framework.Assert;
import junit.framework.TestCase;
import org.jaxen.Context;
import org.jaxen.ContextSupport;