[GitHub] [storm] krichter722 edited a comment on issue #3115: STORM-3490: Add checkstyle rule RedundantModifier

[GitBox <gi...@apache.org>]

krichter722 edited a comment on issue #3115: STORM-3490: Add checkstyle rule RedundantModifier
URL: https://github.com/apache/storm/pull/3115#issuecomment-524366241
 
 
   @Ethanlm Thanks for your review. All `final` modifier are removed on abstract methods (in abstract classes or interfaces) where they have no purpose because they don't influence the parameter of the overridden method (`final` can be added or omitted there no matter how the superclass' method looks like).
   
   In non-abstract classes' methods they make indeed a lot of sense and we could add a rule to enforce them.
   
   The `public` modifiers are generally removed where they can't be used, e.g. on package-private (inner) classes. All changes made sense for me, but please review carefully again.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services