You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Shnekit (via GitHub)" <gi...@apache.org> on 2026/02/18 21:51:26 UTC
[PR] Add SageMaker Unified Studio domain_id, project_id, domain_region as new parameters to SageMakerNotebookOperator [airflow]
Shnekit opened a new pull request, #62147:
URL: https://github.com/apache/airflow/pull/62147
This PR picks up the work from #61498 (by @ruijiang-rjian, who is currently OOO) and adds the following on top:
## Changes from original PR (#61498)
- Added `domain_id`, `project_id`, and `domain_region` as optional parameters to `SageMakerNotebookHook` and `SageMakerNotebookOperator`
## Added in this PR
- Unit tests covering the new parameters in both the hook and operator
- Fixed `ruff-format` failure: missing trailing comma in operator docstring example
- Fixed `update-spelling-wordlist-to-be-sorted` failure: moved `xlarge` to correct sort position in `docs/spelling_wordlist.txt`
Closes #61498 once merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SageMaker Unified Studio domain_id, project_id, domain_region as new parameters to SageMakerNotebookOperator [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas merged PR #62147:
URL: https://github.com/apache/airflow/pull/62147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SageMaker Unified Studio domain_id, project_id, domain_region as new parameters to SageMakerNotebookOperator [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #62147:
URL: https://github.com/apache/airflow/pull/62147#issuecomment-3923404173
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:
- Pay attention to the quality of your code (ruff, mypy and type annotations). Our [prek-hooks]( https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst#prerequisites-for-prek-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/airflow-core/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/dev/breeze/doc/README.rst) for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#coding-style-and-best-practices).
- Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SageMaker Unified Studio domain_id, project_id, domain_region as new parameters to SageMakerNotebookOperator [airflow]
Posted by "Shnekit (via GitHub)" <gi...@apache.org>.
Shnekit commented on code in PR #62147:
URL: https://github.com/apache/airflow/pull/62147#discussion_r2824890364
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/sagemaker_unified_studio.py:
##########
@@ -40,24 +40,43 @@ class SageMakerNotebookHook(BaseHook):
from airflow.providers.amazon.aws.hooks.sagemaker_unified_studio import SageMakerNotebookHook
notebook_hook = SageMakerNotebookHook(
+ execution_name="notebook_execution",
+ domain_id="dzd-example123456",
+ project_id="example123456",
input_config={"input_path": "path/to/notebook.ipynb", "input_params": {"param1": "value1"}},
output_config={"output_uri": "folder/output/location/prefix", "output_formats": "NOTEBOOK"},
- execution_name="notebook_execution",
+ domain_region="us-east-1",
waiter_delay=10,
waiter_max_attempts=1440,
)
:param execution_name: The name of the notebook job to be executed, this is same as task_id.
+ :param domain_id: The domain ID for Amazon SageMaker Unified Studio. Optional - if not provided,
+ the SDK will attempt to resolve it from the MWAA environment.
Review Comment:
Resolved by commit: [26123cd](https://github.com/apache/airflow/pull/62147/commits/26123cd3c67f1f29fe46ee4b3ebf4adbc3b1fefb)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SageMaker Unified Studio domain_id, project_id, domain_region as new parameters to SageMakerNotebookOperator [airflow]
Posted by "o-nikolas (via GitHub)" <gi...@apache.org>.
o-nikolas commented on code in PR #62147:
URL: https://github.com/apache/airflow/pull/62147#discussion_r2824773951
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/sagemaker_unified_studio.py:
##########
@@ -40,24 +40,43 @@ class SageMakerNotebookHook(BaseHook):
from airflow.providers.amazon.aws.hooks.sagemaker_unified_studio import SageMakerNotebookHook
notebook_hook = SageMakerNotebookHook(
+ execution_name="notebook_execution",
+ domain_id="dzd-example123456",
+ project_id="example123456",
input_config={"input_path": "path/to/notebook.ipynb", "input_params": {"param1": "value1"}},
output_config={"output_uri": "folder/output/location/prefix", "output_formats": "NOTEBOOK"},
- execution_name="notebook_execution",
+ domain_region="us-east-1",
waiter_delay=10,
waiter_max_attempts=1440,
)
:param execution_name: The name of the notebook job to be executed, this is same as task_id.
+ :param domain_id: The domain ID for Amazon SageMaker Unified Studio. Optional - if not provided,
+ the SDK will attempt to resolve it from the MWAA environment.
Review Comment:
Carrying over this feedback from the other PR that doesn't look like it was addressed:
It is technically possible to export the right variables in a non-MWAA env, no?
```suggestion
the SDK will attempt to resolve it from the environment.
```
Same suggestion for below and in the operator module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add SageMaker Unified Studio domain_id, project_id, domain_region as new parameters to SageMakerNotebookOperator [airflow]
Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on PR #62147:
URL: https://github.com/apache/airflow/pull/62147#issuecomment-3924039287
Awesome work, congrats on your first merged pull request! You are invited to check our [Issue Tracker](https://github.com/apache/airflow/issues) for additional contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org