You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2020/04/26 05:51:16 UTC
[GitHub] [struts] lukaszlenart opened a new pull request #407: [WW-5017] Drops deprecated Validation annotation as not needed
lukaszlenart opened a new pull request #407:
URL: https://github.com/apache/struts/pull/407
Resolves [WW-5017](https://issues.apache.org/jira/browse/WW-5017)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] coveralls edited a comment on pull request #407: [WW-5017] Drops deprecated Validation annotation as not needed
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #407:
URL: https://github.com/apache/struts/pull/407#issuecomment-619489582
[](https://coveralls.io/builds/30483960)
Coverage decreased (-0.02%) to 49.159% when pulling **6428aaf1495b611b466b105b05ad48c099a615ea on WW-5017-drop-validation** into **387c203c091c4f92793f8302a392aae749ab5640 on master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart commented on pull request #407: [WW-5017] Drops deprecated Validation annotation as not needed
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on pull request #407:
URL: https://github.com/apache/struts/pull/407#issuecomment-619739687
> A couple of the unit test changes dropped a few `@author` tags
It's a good practice to not to specify the tag. After my changes and previous changes, the original authors won't help anybody with the code - also hard to label them the authors of the whole code. There were a large discussion about this topic on ASF
http://mail-archives.apache.org/mod_mbox/www-community/200306.mbox/%3C20030609234538.GA22335@lyra.org%3E
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] coveralls commented on pull request #407: [WW-5017] Drops deprecated Validation annotation as not needed
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #407:
URL: https://github.com/apache/struts/pull/407#issuecomment-619489582
[](https://coveralls.io/builds/30344610)
Coverage decreased (-0.005%) to 49.176% when pulling **4a8315fa169b850b6097de498d950c2e91669231 on WW-5017-drop-validation** into **3ccbcc6f9c9f84f6f1e5644e1e266754d88a8017 on master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] coveralls edited a comment on pull request #407: [WW-5017] Drops deprecated Validation annotation as not needed
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #407:
URL: https://github.com/apache/struts/pull/407#issuecomment-619489582
[](https://coveralls.io/builds/30359266)
Coverage decreased (-0.005%) to 49.176% when pulling **13cbf0e4188fef8b44e61a51b619cf57e62fbabd on WW-5017-drop-validation** into **387c203c091c4f92793f8302a392aae749ab5640 on master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org