You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Aaron Daubman (JIRA)" <ji...@apache.org> on 2014/03/20 05:47:44 UTC

[jira] [Commented] (SOLR-2052) Allow for a list of filter queries and a single docset filter in QueryComponent

    [ https://issues.apache.org/jira/browse/SOLR-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13941385#comment-13941385 ] 

Aaron Daubman commented on SOLR-2052:
-------------------------------------

[~yseeley@gmail.com] [~hossman]
Is this test coverage sufficient?
https://github.com/daubman/lucene-solr/blob/solr2052/solr/core/src/test/org/apache/solr/handler/component/QueryComponentTest.java

You can see the full set of changes here (pretty much the same as the attached patches have always been):
https://github.com/daubman/lucene-solr/compare/solr2052?expand=1

I would love to be able to provide the necessary/desired coverage to enable this to make it into trunk and 4.8 / 4.7.1 as we have been using this functionality successfully for years and I would really love to get out of the business of patching and using a custom build! =)

> Allow for a list of filter queries and a single docset filter in QueryComponent
> -------------------------------------------------------------------------------
>
>                 Key: SOLR-2052
>                 URL: https://issues.apache.org/jira/browse/SOLR-2052
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 4.0-ALPHA
>         Environment: Mac OS X, Java 1.6
>            Reporter: Stephen Green
>            Priority: Minor
>             Fix For: 4.8
>
>         Attachments: SOLR-2052-2.patch, SOLR-2052-3-6-1.patch, SOLR-2052-3.patch, SOLR-2052-4.patch, SOLR-2052-4_0_0.patch, SOLR-2052-trunk.patch, SOLR-2052.patch
>
>
> SolrIndexSearcher.QueryCommand allows you to specify a list of filter queries or a single filter (as a DocSet), but not both.  This restriction seems arbitrary, and there are cases where we can have both a list of filter queries and a DocSet generated by some other non-query process (e.g., filtering documents according to IDs pulled from some other source like a database.)
> Fixing this requires a few small changes to SolrIndexSearcher to allow both of these to be set for a QueryCommand and to take both into account when evaluating the query.  It also requires a modification to ResponseBuilder to allow setting the single filter at query time.
> I've run into this against 1.4, but the same holds true for the trunk.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org