[GitHub] [helix] narendly commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option.

[GitBox <gi...@apache.org>]

narendly commented on a change in pull request #638: Decouple the event type and the scheduled rebalance cache refresh option.
URL: https://github.com/apache/helix/pull/638#discussion_r352019151
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
 ##########
 @@ -358,8 +365,9 @@ public void scheduleRebalance(long rebalanceTime) {
   /**
    * Schedule an on demand rebalance pipeline.
    * @param delay
+   * @param shouldRefreshCache true if refresh the cache before scheduling a rebalance.
    */
-  public void scheduleOnDemandRebalance(long delay) {
+  public void scheduleOnDemandRebalance(long delay, boolean shouldRefreshCache) {
 
 Review comment:
   Constructor change in a public method may cause backward-compatibility issues. Could we keep the original public method and add this overloaded one?
   
   If so, what should the default behavior be for `public void scheduleOnDemandRebalance(long delay)`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org