You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Isabelle Giguere (Jira)" <ji...@apache.org> on 2021/02/06 03:31:00 UTC
[jira] [Commented] (SOLR-7913) Add stream.body support to MLT
QParser
[ https://issues.apache.org/jira/browse/SOLR-7913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17280064#comment-17280064 ]
Isabelle Giguere commented on SOLR-7913:
----------------------------------------
Patch on release tag lucene-solr 8.7.0: SOLR-7913_tag_lucene-solr-8.7.0.patch
Improvement : this patch does not ignore org.apache.solr.request.TestRemoteStreaming.testNoUrlAccess()
The modifications in RequestUtils are aimed exclusively at MTLQParser, nothing else should be affected.
This patch re-introduces the changes in SearchHandler and ShardRequest that were present in previous patches (Solr 5, 6, 7). These changes allow passing the POST body to the MLTQParser. My analysis on Solr 8.5.0 may have been completely wrong .. or there may have been another issue ? I would need to double-check, if I make the time.
In unit test, results are surprisingly similar in SimpleMLTQParserTest, when comparing the tests with id and with stream.body
Results are different with id and with stream.body in CloudMLTQParserTest ... possibly because of merging results from shards.
Remaining issue : searching on an alias returns no results. No idea why.
I would also have to make the time to re-create the same patch on Solr master.
> Add stream.body support to MLT QParser
> --------------------------------------
>
> Key: SOLR-7913
> URL: https://issues.apache.org/jira/browse/SOLR-7913
> Project: Solr
> Issue Type: Improvement
> Reporter: Anshum Gupta
> Priority: Major
> Attachments: SOLR-7913.patch, SOLR-7913.patch, SOLR-7913.patch, SOLR-7913.patch, SOLR-7913_fix-unit-test-setup.patch, SOLR-7913_fixTests.patch, SOLR-7913_negative-tests.patch, SOLR-7913_tag_7.5.0.patch, SOLR-7913_tag_lucene-solr-8.7.0.patch
>
>
> Continuing from https://issues.apache.org/jira/browse/SOLR-7639?focusedCommentId=14601011&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14601011.
> It'd be good to have stream.body be supported by the mlt qparser.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org