You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Shawn Heisey (Commented) (JIRA)" <ji...@apache.org> on 2012/04/04 20:35:25 UTC
[jira] [Commented] (SOLR-2729) DIH status: successful zero-document
delta-import missing "" field
[ https://issues.apache.org/jira/browse/SOLR-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13246562#comment-13246562 ]
Shawn Heisey commented on SOLR-2729:
------------------------------------
Found it. In solr/contrib/dataimporthandler/src/java/org/apache/solr/handler/dataimport/DocBuilder.java:
{code}
// Do not commit unnecessarily if this is a delta-import and no documents were created or deleted
if (!requestParameters.clean) {
if (importStatistics.docCount.get() > 0 || importStatistics.deletedDocCount.get() > 0) {
finish(lastIndexTimeProps);
}
} else {
// Finished operation normally, commit now
finish(lastIndexTimeProps);
}
{code}
The method named finish is where the status message gets updated with the status that says how many documents were added/updated.
A fix that would take care of the immediate problem is to move the code that populates the "" part of statusMessages into its own method that is called by finish, then add an else clause to the inner if statement above which calls that method. Does that sound at all reasonable?
> DIH status: successful zero-document delta-import missing "" field
> ------------------------------------------------------------------
>
> Key: SOLR-2729
> URL: https://issues.apache.org/jira/browse/SOLR-2729
> Project: Solr
> Issue Type: Bug
> Components: contrib - DataImportHandler
> Affects Versions: 3.2
> Environment: Linux idxst0-a 2.6.18-238.12.1.el5.centos.plusxen #1 SMP Wed Jun 1 11:57:54 EDT 2011 x86_64 x86_64 x86_64 GNU/Linux
> java version "1.6.0_26"
> Java(TM) SE Runtime Environment (build 1.6.0_26-b03)
> Java HotSpot(TM) 64-Bit Server VM (build 20.1-b02, mixed mode)
> Reporter: Shawn Heisey
> Priority: Minor
> Fix For: 4.0
>
>
> If you have a successful delta-import that happens to process zero documents, the <str name=""> field is not present in the status. I've run into this situation when the SQL query results in an empty set. A workaround for the problem is to instead look for the "Time taken " field ... but if you don't happen to notice that this field has an extraneous space in the name, that won't work either.
> A full-import that processes zero documents has the field present as expected:
> <str name="">Indexing completed. Added/Updated: 0 documents. Deleted 0 documents.</str>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org