You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "vladanvasi-db (via GitHub)" <gi...@apache.org> on 2026/09/24 09:07:20 UTC
[PR] [SPARK-59761][SQL] Add SET VARIABLE DEFAULT golden tests [spark]
vladanvasi-db opened a new pull request, #59012:
URL: https://github.com/apache/spark/pull/59012
### What changes were proposed in this pull request?
Add SET VARIABLE DEFAULT coverage to `sql-session-variables.sql` and update its execution and analyzer golden files. The cases cover multi-variable DEFAULT assignment, DEFAULT in VALUES and subqueries, name precedence between columns and variables called `default`, and invalid assignment forms.
### Why are the changes needed?
SPARK-59761: preserve the existing SET VARIABLE DEFAULT behavior with SQL regression coverage.
### Does this PR introduce _any_ user-facing change?
No. This PR changes tests and golden files only.
### How was this patch tested?
The added SQL statements and both golden-file blocks were checked against the source regression-test patch. `git diff --check` passes, and the two golden files each contain 294 query blocks.
The focused `SQLQueryTestSuite` could not start locally: sbt project loading requires uncached plugin dependencies, and Maven Central DNS is unavailable in this environment. CI needs to run the suite.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59761][SQL] Add SET VARIABLE DEFAULT golden tests [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #59012:
URL: https://github.com/apache/spark/pull/59012#issuecomment-5850239154
Thank you @vladanvasi-db, let's please try to make CI green here, the failure doesn't look related but let's try re-run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59761][SQL][TEST] Add SET VARIABLE DEFAULT golden tests [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #59012:
URL: https://github.com/apache/spark/pull/59012#issuecomment-5869898187
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/5157813fe9968461c75ce955d96e80c7d6954404
- merged into branch-4.x https://github.com/apache/spark/commit/df35d45733f677d8479ad1a55a28024145147ddb
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-59761][SQL][TEST] Add SET VARIABLE DEFAULT golden tests [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b closed pull request #59012: [SPARK-59761][SQL][TEST] Add SET VARIABLE DEFAULT golden tests
URL: https://github.com/apache/spark/pull/59012
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org