You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "alekseyolg (via GitHub)" <gi...@apache.org> on 2023/12/07 09:48:43 UTC
[PR] fix(docker): Remove race condition when building image [superset]
alekseyolg opened a new pull request, #26205:
URL: https://github.com/apache/superset/pull/26205
After merging the PR, a race condition for writing access to the apt cache directory began to appear from time to time. This oversight must be corrected.
https://github.com/apache/superset/pull/26196
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): Remove race condition when building image [superset]
Posted by "john-bodley (via GitHub)" <gi...@apache.org>.
john-bodley commented on PR #26205:
URL: https://github.com/apache/superset/pull/26205#issuecomment-1845840428
Thanks @alekseyolg for the fix. Would you mind including mention in the `TESTING INSTRUCTIONS` section regarding how we know this fix is suffice? It may be something as simple as:
> Ran `docker-compose` locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): Remove race condition when building image [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #26205:
URL: https://github.com/apache/superset/pull/26205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): Remove race condition when building image [superset]
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #26205:
URL: https://github.com/apache/superset/pull/26205#issuecomment-1848287703
@michael-s-molina The increase in build time is due to the fact that the images are built sequentially; unfortunately, I have not yet figured out how to speed up this process; building ARM64 takes a lot of time.
To speed up the assembly process, respected @sebastianliebscher created a pull request https://github.com/apache/superset/pull/25564 which for some reason was not accepted. This PR should solve the problem of long image assembly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): Remove race condition when building image [superset]
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #26205:
URL: https://github.com/apache/superset/pull/26205#issuecomment-1847179457
@alekseyolg It looks like the CI Docker build execution time doubled after this PR and is taking more than 1 hour to complete. Could you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): Remove race condition when building image [superset]
Posted by "craig-rueda (via GitHub)" <gi...@apache.org>.
craig-rueda commented on PR #26205:
URL: https://github.com/apache/superset/pull/26205#issuecomment-1850530435
I'll ask Apache infra for a new dockerhub registry that we can use for build caching
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): Remove race condition when building image [superset]
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #26205:
URL: https://github.com/apache/superset/pull/26205#issuecomment-1848292807
It would also be possible to speed up the build using caching.
https://github.com/apache/superset/pull/25422
This pool request has been closed, but if the respected @craig-rueda tells me where to put the build cache, then I can create a new PR, which will significantly speed up the process of building images.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(docker): Remove race condition when building image [superset]
Posted by "alekseyolg (via GitHub)" <gi...@apache.org>.
alekseyolg commented on PR #26205:
URL: https://github.com/apache/superset/pull/26205#issuecomment-1845978691
@john-bodley Unfortunately, I am not a native English speaker and will not be able to describe everything correctly. I can write my logic of thoughts that guided me when creating this pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org