You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "roryschadler (via GitHub)" <gi...@apache.org> on 2023/12/08 16:29:44 UTC

[I] [Feature Request] Expose get/setListenerName in the C API [pulsar-client-cpp]

roryschadler opened a new issue, #369:
URL: https://github.com/apache/pulsar-client-cpp/issues/369

   https://github.com/apache/pulsar-client-cpp/blob/27cba3e7d154f97e01911cd5de2cc0d4eaf2ef50/lib/c/c_ClientConfiguration.cc doesn't seem to expose `getListenerName` and `setListenerName` from https://github.com/apache/pulsar-client-cpp/blob/27cba3e7d154f97e01911cd5de2cc0d4eaf2ef50/include/pulsar/ClientConfiguration.h#L270-L280. That prevents the Node.js binding from exposing it (see related issue https://github.com/apache/pulsar-client-node/issues/214), as it relies on the C API.
   
   I'm not an expert, but at first glance this doesn't seem like a ton of work. I'd be willing to give it a shot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Feature Request] Expose get/setListenerName in the C API [pulsar-client-cpp]

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower closed issue #369: [Feature Request] Expose get/setListenerName in the C API
URL: https://github.com/apache/pulsar-client-cpp/issues/369


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Feature Request] Expose get/setListenerName in the C API [pulsar-client-cpp]

Posted by "roryschadler (via GitHub)" <gi...@apache.org>.
roryschadler commented on issue #369:
URL: https://github.com/apache/pulsar-client-cpp/issues/369#issuecomment-1849164363

   Thanks! Opened a PR: https://github.com/apache/pulsar-client-cpp/pull/370


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] [Feature Request] Expose get/setListenerName in the C API [pulsar-client-cpp]

Posted by "BewareMyPower (via GitHub)" <gi...@apache.org>.
BewareMyPower commented on issue #369:
URL: https://github.com/apache/pulsar-client-cpp/issues/369#issuecomment-1848283807

   Yes. It should be easy. If you want to try this feature, you can take a look at the previous PRs that add new C APIs. https://github.com/apache/pulsar-client-cpp/commits/main/lib/c


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org