You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Omega359 (via GitHub)" <gi...@apache.org> on 2025/01/12 22:23:04 UTC
[PR] Add sqlite sqllogictest run to extended.yml [datafusion]
Omega359 opened a new pull request, #14101:
URL: https://github.com/apache/datafusion/pull/14101
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #13967
## Rationale for this change
Run sqlite test suite on push to main.
**##** What changes are included in this PR?
Just the github action.
## Are these changes tested?
No, I do not know of a great way to test this.
## Are there any user-facing changes?
No.
NOTE: This PR should **NOT** be merged until https://github.com/apache/datafusion-testing/pull/4 is merged into datafusion-testing and datafusion repo has been updated with a reference to that commit. As well a manual run of the sqlite test suite should likely be done prior to merging this just in case a change crept in between the generation of the sqlite test files and the merging of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add sqlite sqllogictest run to extended.yml [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #14101:
URL: https://github.com/apache/datafusion/pull/14101#issuecomment-2593141596
Let's merge this in and get some experience with running the extended suite on main. Thank you @Omega359 and @comphead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add sqlite sqllogictest run to extended.yml [datafusion]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #14101:
URL: https://github.com/apache/datafusion/pull/14101
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add sqlite sqllogictest run to extended.yml [datafusion]
Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead commented on code in PR #14101:
URL: https://github.com/apache/datafusion/pull/14101#discussion_r1915276899
##########
.github/workflows/extended.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Rust Hash Collisions
+name: Datafusion extended tests
Review Comment:
perhaps we can rename it like
```
Tests when hash values collide
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add sqlite sqllogictest run to extended.yml [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on code in PR #14101:
URL: https://github.com/apache/datafusion/pull/14101#discussion_r1915280445
##########
.github/workflows/extended.yml:
##########
@@ -15,7 +15,7 @@
# specific language governing permissions and limitations
# under the License.
-name: Rust Hash Collisions
+name: Datafusion extended tests
Review Comment:
That field is for the name of the workflow, not the job within it. Now that the workflow covers both hash and sqlite tests I thought it should be just a generic name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org