[PR] refactor: complete all 6 refactorings - extract methods, variables, c… [commons-lang]

["beaprogram (via GitHub)" <gi...@apache.org>]

beaprogram opened a new pull request, #1499:
URL: https://github.com/apache/commons-lang/pull/1499

   …lasses, and consolidate helpers
   
   Set I Refactorings (Implementation Level) - 3/3:
   - Extract Method: Split testAbbreviate_StringInt into testAbbreviateBasicCases
   - Introduce Variable: Replace magic numbers with named constants (DEFAULT_MAX_WIDTH, SHORT_MAX_WIDTH, MEDIUM_MAX_WIDTH)
   - Decompose Conditional: Extract offset validation into isValidOffsetInRange helper method
   
   Set II Refactorings (Design Level) - 3/3:
   - Extract Class: Create StringValidationUtils.java with isEmpty and isBlank methods
   - Pull-up Method: Extract common TEST_STRING constant at class level
   - Move Method: Consolidate message creation into createAbbreviateMessage helper
   
   Results:
   - All 7 tests in StringUtilsAbbreviateTest pass
   - All 269 source files compile successfully
   - No failures or errors
   - Code quality significantly improved per SOLID principles
   - Backward compatibility maintained through delegation
   
   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       https://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated!
   
   Before you push a pull request, review this list:
   
   - [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project.
   - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI).
   - [ ] I used AI to create any part of, or all of, this pull request.
   - [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself.
   - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: complete all 6 refactorings - extract methods, variables, c… [commons-lang]

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory closed pull request #1499: refactor: complete all 6 refactorings - extract methods, variables, c…
URL: https://github.com/apache/commons-lang/pull/1499


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] refactor: complete all 6 refactorings - extract methods, variables, c… [commons-lang]

["garydgregory (via GitHub)" <gi...@apache.org>]

garydgregory commented on PR #1499:
URL: https://github.com/apache/commons-lang/pull/1499#issuecomment-3572696880

   -1: This looks like change for the sake of change, and `StringValidationUtils` duplicates existing functionality.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org