You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Renan DelValle <re...@apache.org> on 2018/02/14 05:05:48 UTC
Review Request 65649: Adding support for a Thrift JSON request which
defines
UTF-8 as the charset for the Content-Type in the Request Headers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65649/
-----------------------------------------------------------
Review request for Aurora, Jordan Ly and Stephan Erb.
Repository: aurora
Description
-------
Adding support in the scheduler to receive a JSON request which defines a UTF-8 charset in the Content-Type inside of the HTTP Request Headers.
This fixes the current UI brakage as Thrift is incorrectly rejected by the scheduler servlet as an unsupported media type.
Adding a test to prevent regressions.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 91ff8d32be1dacd35c7ba74b666479a61aede296
src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 10da43bdc113791d0644dcc480476323f86cc66e
Diff: https://reviews.apache.org/r/65649/diff/1/
Testing
-------
End to end testing
Loading up UI in different browsers in order to make sure thrift.js was not cached.
vagrant destroy && vagrant up
Thanks,
Renan DelValle
Re: Review Request 65649: Adding support for a Thrift JSON request
which
defines UTF-8 as the charset for the Content-Type in the Request Headers
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65649/#review197487
-----------------------------------------------------------
Ship it!
Ship It!
- Jordan Ly
On Feb. 14, 2018, 5:05 a.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65649/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2018, 5:05 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding support in the scheduler to receive a JSON request which defines a UTF-8 charset in the Content-Type inside of the HTTP Request Headers.
>
> This fixes the current UI brakage as Thrift is incorrectly rejected by the scheduler servlet as an unsupported media type.
>
> Adding a test to prevent regressions.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 91ff8d32be1dacd35c7ba74b666479a61aede296
> src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 10da43bdc113791d0644dcc480476323f86cc66e
>
>
> Diff: https://reviews.apache.org/r/65649/diff/1/
>
>
> Testing
> -------
>
> End to end testing
> Loading up UI in different browsers in order to make sure thrift.js was not cached.
> vagrant destroy && vagrant up
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 65649: Adding support for a Thrift JSON request
which
defines UTF-8 as the charset for the Content-Type in the Request Headers
Posted by Stephan Erb <se...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65649/#review197520
-----------------------------------------------------------
Ship it!
Ship It!
- Stephan Erb
On Feb. 14, 2018, 6:05 a.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65649/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2018, 6:05 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding support in the scheduler to receive a JSON request which defines a UTF-8 charset in the Content-Type inside of the HTTP Request Headers.
>
> This fixes the current UI brakage as Thrift is incorrectly rejected by the scheduler servlet as an unsupported media type.
>
> Adding a test to prevent regressions.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 91ff8d32be1dacd35c7ba74b666479a61aede296
> src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 10da43bdc113791d0644dcc480476323f86cc66e
>
>
> Diff: https://reviews.apache.org/r/65649/diff/1/
>
>
> Testing
> -------
>
> End to end testing
> Loading up UI in different browsers in order to make sure thrift.js was not cached.
> vagrant destroy && vagrant up
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 65649: Adding support for a Thrift JSON request
which
defines UTF-8 as the charset for the Content-Type in the Request Headers
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65649/#review197480
-----------------------------------------------------------
Master (cb0faf8) is red with this patch.
./build-support/jenkins/build.sh
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
WARN] Reached consecutive failure limit.
--------------- Captured log call ----------------
health_checker.py 143 WARNING WARN] Health check failure: failure-1
health_checker.py 184 WARNING WARN] Ignoring failure of attempt: 1
health_checker.py 143 WARNING WARN] Health check failure: failure-2
health_checker.py 184 WARNING WARN] Ignoring failure of attempt: 2
health_checker.py 143 WARNING WARN] Health check failure: failure-3
health_checker.py 159 WARNING WARN] Reached consecutive failure limit.
2 failed, 798 passed, 6 skipped in 315.53 seconds
FAILURE
Waiting for background workers to finish.
06:01:54 05:52 [complete]
FAILURE
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Feb. 14, 2018, 5:05 a.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65649/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2018, 5:05 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding support in the scheduler to receive a JSON request which defines a UTF-8 charset in the Content-Type inside of the HTTP Request Headers.
>
> This fixes the current UI brakage as Thrift is incorrectly rejected by the scheduler servlet as an unsupported media type.
>
> Adding a test to prevent regressions.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 91ff8d32be1dacd35c7ba74b666479a61aede296
> src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 10da43bdc113791d0644dcc480476323f86cc66e
>
>
> Diff: https://reviews.apache.org/r/65649/diff/1/
>
>
> Testing
> -------
>
> End to end testing
> Loading up UI in different browsers in order to make sure thrift.js was not cached.
> vagrant destroy && vagrant up
>
>
> Thanks,
>
> Renan DelValle
>
>
Re: Review Request 65649: Adding support for a Thrift JSON request
which
defines UTF-8 as the charset for the Content-Type in the Request Headers
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65649/#review197477
-----------------------------------------------------------
Ship it!
Thanks for the fix!
- David McLaughlin
On Feb. 14, 2018, 5:05 a.m., Renan DelValle wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65649/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2018, 5:05 a.m.)
>
>
> Review request for Aurora, Jordan Ly and Stephan Erb.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Adding support in the scheduler to receive a JSON request which defines a UTF-8 charset in the Content-Type inside of the HTTP Request Headers.
>
> This fixes the current UI brakage as Thrift is incorrectly rejected by the scheduler servlet as an unsupported media type.
>
> Adding a test to prevent regressions.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/http/api/ApiModule.java 91ff8d32be1dacd35c7ba74b666479a61aede296
> src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java 10da43bdc113791d0644dcc480476323f86cc66e
>
>
> Diff: https://reviews.apache.org/r/65649/diff/1/
>
>
> Testing
> -------
>
> End to end testing
> Loading up UI in different browsers in order to make sure thrift.js was not cached.
> vagrant destroy && vagrant up
>
>
> Thanks,
>
> Renan DelValle
>
>