[GitHub] [arrow-datafusion] houqp commented on pull request #5729: feat: enable serde of arrow-schema

["houqp (via GitHub)" <gi...@apache.org>]

houqp commented on PR #5729:
URL: https://github.com/apache/arrow-datafusion/pull/5729#issuecomment-1510884622

   @jychen7 the optional feature needs to be added to the features section at https://github.com/apache/arrow-datafusion/blob/64941fa99e13459a99d2ec3f15cdd997fee41988/datafusion/core/Cargo.toml#L36.
   
   Adding it in the dependency directly will force all datafusion users to enable serde, which adds unnecessary overheads to users who don't need it.
   
   @tustvold as @jychen7 mentioned, this is mostly a minor UX improvement to datafusion users so they don't need to find out which downstream crate to toggle a feature and manually keep the version in sync with what's pinned in datafusion. Same idea why we have the `simd` and `pyarrow` feature flag in datafusion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org