You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/01 03:09:53 UTC

[GitHub] [shardingsphere] chrissata opened a new issue #6226: broadcast table DML SQL route wrong if broadcast table are configured only on subset of the datasources.

chrissata opened a new issue #6226:
URL: https://github.com/apache/shardingsphere/issues/6226


   ## Bug Report
   
   **For English only**, other languages will not accept.
   
   Before report a bug, make sure you have:
   
   - Searched open and closed [GitHub issues](https://github.com/apache/shardingsphere/issues).
   - Read documentation: [ShardingSphere Doc](https://shardingsphere.apache.org/document/current/en/overview).
   
   Please pay attention on issues you submitted, because we maybe need more details. 
   If no response anymore and we cannot reproduce it on current information, we will **close it**.
   
   Please answer these questions before submitting your issue. Thanks!
   
   ### Which version of ShardingSphere did you use?
   4.1.0
   ### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?
   ShardingSphere-Proxy
   
   ### Expected behavior
   DML of broadcast table route to the right datasources.
   
   ### Actual behavior
   DML of broadcast table route to the all datasources. But ddl route strategy is right.
   
   ### Reason analyze (If you can)
   DML of broadcast table use all datasources as target.  
   
   ### Steps to reproduce the behavior, such as: SQL to execute, sharding rule configuration, when exception occur etc.
   1) config.
   schemaName: test_db
   dataSources:
     ds0:
         xxxx
     ds1:
        xxxx
     ds2:
       xxxx
   shardingRule:
     tables:
       testGlobal:
         actualDataNodes: ds${0..1}.testGlobal
     broadcastTables:
       - testGlobal
   2) do DML sql
   use test_db
   update testGlobal set name="abc";
   
   ### Example codes for reproduce this issue (such as a github link).
   update or insert sql
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #6226: broadcast table DML SQL route wrong if broadcast table are configured only on subset of the datasources.

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #6226:
URL: https://github.com/apache/shardingsphere/issues/6226#issuecomment-657389543


   @chrissata There was no feedback beyond 7 days, I have to close this one. 
   
   Thanks.
   Trista


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #6226: broadcast table DML SQL route wrong if broadcast table are configured only on subset of the datasources.

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #6226:
URL: https://github.com/apache/shardingsphere/issues/6226#issuecomment-657939695


   Hi @chrissata 
   I guess you mixed up the `sharding table` and `broadcast table`. AFAIK, users can not limit data sources for `broadcast table` , namely each `broadcast table` will exist in all data sources configured.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] chrissata commented on issue #6226: broadcast table DML SQL route wrong if broadcast table are configured only on subset of the datasources.

Posted by GitBox <gi...@apache.org>.
chrissata commented on issue #6226:
URL: https://github.com/apache/shardingsphere/issues/6226#issuecomment-657413270


   > `testGlobal` is you broadcast Table ,so will route to the all datasources, Any other questions?
   
   Wondering if you have ever read the config carefully,  the config had restricted the globa table to only datasource ds0 & ds1, but I have ds0, ds1 and ds2 ,overall 3 datasources. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero closed issue #6226: broadcast table DML SQL route wrong if broadcast table are configured only on subset of the datasources.

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #6226:
URL: https://github.com/apache/shardingsphere/issues/6226


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] chrissata commented on issue #6226: broadcast table DML SQL route wrong if broadcast table are configured only on subset of the datasources.

Posted by GitBox <gi...@apache.org>.
chrissata commented on issue #6226:
URL: https://github.com/apache/shardingsphere/issues/6226#issuecomment-657950753


   Hi @tristaZero,
   I followed the instructions in issue #5919.  @terrymanu has confirmed the config that it could support my requirments. 
   So maybe he's wrong. 
   
   Thanks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero edited a comment on issue #6226: broadcast table DML SQL route wrong if broadcast table are configured only on subset of the datasources.

Posted by GitBox <gi...@apache.org>.
tristaZero edited a comment on issue #6226:
URL: https://github.com/apache/shardingsphere/issues/6226#issuecomment-658006250


   Hi @chrissata
   If so, @terrymanu is expected to give more explanation.
   From my understanding, 
   First, [ShardingRule](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java) currently does store any specific dataSources configuration for `boardcast table`.
   Second, I don't think the idea of this issue keep compatible with the definition of [boardcast table](https://shardingsphere.apache.org/document/current/cn/features/sharding/concept/sql/).
   
   Thanks,
   Trista


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yu199195 commented on issue #6226: broadcast table DML SQL route wrong if broadcast table are configured only on subset of the datasources.

Posted by GitBox <gi...@apache.org>.
yu199195 commented on issue #6226:
URL: https://github.com/apache/shardingsphere/issues/6226#issuecomment-653435396


   `testGlobal` is you broadcast Table ,so will route to the all datasources, Any other questions?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tristaZero commented on issue #6226: broadcast table DML SQL route wrong if broadcast table are configured only on subset of the datasources.

Posted by GitBox <gi...@apache.org>.
tristaZero commented on issue #6226:
URL: https://github.com/apache/shardingsphere/issues/6226#issuecomment-658006250


   Hi @chrissata
   If so, @terrymanu is expected to give more explanation.
   From my understanding, 
   First, [ShardingRule](https://github.com/apache/shardingsphere/blob/master/shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java) currently does store any specific dataSources configuration for `boardcast table`.
   Second, I don't think the idea of this issue keep compatible with the definition of [boardcast table](https://shardingsphere.apache.org/document/current/cn/features/sharding/concept/sql/)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org