You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/09/15 08:21:01 UTC
[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #221: Change url of total lines badge in README
kaijchen opened a new pull request, #221:
URL: https://github.com/apache/incubator-uniffle/pull/221
### What changes were proposed in this pull request?
Change "total lines" badge url to tokei.rs
And use empty alt message to display nothing on failure.
See https://github.com/XAMPPRocky/tokei#badges
### Why are the changes needed?
Current badge sometimes show "total lines: invalid".
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
https://github.com/kaijchen/incubator-uniffle/tree/tokei#apache-uniffle-incubating
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #221: Change total lines badge to tokei.rs in README
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #221:
URL: https://github.com/apache/incubator-uniffle/pull/221#issuecomment-1247771628
Closing this due to #222.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen commented on pull request #221: Change url of total lines badge in README
Posted by GitBox <gi...@apache.org>.
kaijchen commented on PR #221:
URL: https://github.com/apache/incubator-uniffle/pull/221#issuecomment-1247766606
Seems #222 is more stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] kaijchen closed pull request #221: Change total lines badge to tokei.rs in README
Posted by GitBox <gi...@apache.org>.
kaijchen closed pull request #221: Change total lines badge to tokei.rs in README
URL: https://github.com/apache/incubator-uniffle/pull/221
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org