You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by ah...@apache.org on 2017/05/01 03:12:54 UTC
[1/7] git commit: [flex-falcon] [refs/heads/dual] - special case
XML/XMLList for JS compiles. The JS version is not dynamic. Making it dynamic
introduced other problems
Repository: flex-falcon
Updated Branches:
refs/heads/dual 55d9fcf98 -> 8dd7f9c30
special case XML/XMLList for JS compiles. The JS version is not dynamic. Making it dynamic introduced other problems
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/5ffbc255
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/5ffbc255
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/5ffbc255
Branch: refs/heads/dual
Commit: 5ffbc255a0e3f86830eeaa6edb336c4d82d9316c
Parents: 9f793c6
Author: Alex Harui <ah...@apache.org>
Authored: Wed Apr 19 23:22:18 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Wed Apr 19 23:22:18 2017 -0700
----------------------------------------------------------------------
.../flex/compiler/internal/tree/as/ExpressionNodeBase.java | 6 ++++++
1 file changed, 6 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/5ffbc255/compiler/src/main/java/org/apache/flex/compiler/internal/tree/as/ExpressionNodeBase.java
----------------------------------------------------------------------
diff --git a/compiler/src/main/java/org/apache/flex/compiler/internal/tree/as/ExpressionNodeBase.java b/compiler/src/main/java/org/apache/flex/compiler/internal/tree/as/ExpressionNodeBase.java
index 6c514b7..b54c1f0 100644
--- a/compiler/src/main/java/org/apache/flex/compiler/internal/tree/as/ExpressionNodeBase.java
+++ b/compiler/src/main/java/org/apache/flex/compiler/internal/tree/as/ExpressionNodeBase.java
@@ -21,6 +21,7 @@ package org.apache.flex.compiler.internal.tree.as;
import org.apache.flex.abc.semantics.Name;
import org.apache.flex.compiler.common.DependencyType;
+import org.apache.flex.compiler.constants.IASLanguageConstants;
import org.apache.flex.compiler.definitions.IDefinition;
import org.apache.flex.compiler.definitions.ITypeDefinition;
import org.apache.flex.compiler.definitions.references.INamespaceReference;
@@ -149,6 +150,11 @@ public abstract class ExpressionNodeBase extends FixedChildrenNode implements IE
if (type != null)
isDynamic = type.isDynamic();
+ if (!isDynamic)
+ {
+ String qName = type.getQualifiedName();
+ isDynamic = qName.equals(IASLanguageConstants.XML) || qName.equals(IASLanguageConstants.XMLList);
+ }
return isDynamic;
}
[5/7] git commit: [flex-falcon] [refs/heads/dual] - add provides for
internal classes so the GoogDepsWriter will search for all dependencies in a
file
Posted by ah...@apache.org.
add provides for internal classes so the GoogDepsWriter will search for all dependencies in a file
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/3f9ed83d
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/3f9ed83d
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/3f9ed83d
Branch: refs/heads/dual
Commit: 3f9ed83de08907a52392044be78ad324287c6662
Parents: e11cf7e
Author: Alex Harui <ah...@apache.org>
Authored: Sun Apr 23 22:43:30 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Sun Apr 23 22:43:30 2017 -0700
----------------------------------------------------------------------
.../codegen/js/jx/PackageHeaderEmitter.java | 18 ++++++++++++++++++
.../compiler/internal/graph/GoogDepsWriter.java | 15 ++++++++++++++-
.../codegen/js/flexjs/TestFlexJSPackage.java | 8 ++++++++
.../flexjs/projects/internal/MainClass_result.js | 1 +
4 files changed, 41 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/3f9ed83d/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/PackageHeaderEmitter.java
----------------------------------------------------------------------
diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/PackageHeaderEmitter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/PackageHeaderEmitter.java
index 73d3b80..5c9c91c 100644
--- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/PackageHeaderEmitter.java
+++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/PackageHeaderEmitter.java
@@ -23,6 +23,7 @@ import java.io.File;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Collections;
+import java.util.HashMap;
import java.util.List;
import org.apache.flex.compiler.asdoc.flexjs.ASDocComment;
@@ -149,7 +150,24 @@ public class PackageHeaderEmitter extends JSSubEmitter implements
write(ASEmitterTokens.SINGLE_QUOTE);
write(ASEmitterTokens.PAREN_CLOSE);
writeNewline(ASEmitterTokens.SEMICOLON);
+
+ HashMap<String, String> internalClasses = getEmitter().getModel().getInternalClasses();
+ if (internalClasses.size() > 0)
+ {
+ for (String internalClass : internalClasses.keySet())
+ {
+ /* goog.provide('x');\n\n */
+ write(JSGoogEmitterTokens.GOOG_PROVIDE);
+ write(ASEmitterTokens.PAREN_OPEN);
+ write(ASEmitterTokens.SINGLE_QUOTE);
+ write(((JSFlexJSEmitter)getEmitter()).formatQualifiedName(internalClass, true));
+ write(ASEmitterTokens.SINGLE_QUOTE);
+ write(ASEmitterTokens.PAREN_CLOSE);
+ writeNewline(ASEmitterTokens.SEMICOLON);
+ }
+ }
writeNewline();
+
}
public void emitContents(IPackageDefinition definition)
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/3f9ed83d/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
----------------------------------------------------------------------
diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
index 5c122d4..49038cd 100644
--- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
+++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
@@ -379,6 +379,8 @@ public class GoogDepsWriter {
{
for (String dep : gd.fileInfo.impls)
{
+ if (gd.fileInfo.provides != null &&
+ gd.fileInfo.provides.contains(dep)) continue;
addDeps(dep);
}
}
@@ -388,6 +390,8 @@ public class GoogDepsWriter {
for (String dep : gd.fileInfo.deps)
{
gd.deps.add(dep);
+ if (gd.fileInfo.provides != null &&
+ gd.fileInfo.provides.contains(dep)) continue;
addDeps(dep);
}
}
@@ -590,8 +594,16 @@ public class GoogDepsWriter {
c = line.indexOf("goog.provide");
if (c > -1)
{
- if (fi.googProvideLine == -i)
+ if (fi.googProvideLine == -1)
fi.googProvideLine = i;
+ if (numProvides > 0)
+ {
+ if (fi.provides == null)
+ fi.provides = new ArrayList<String>();
+ c2 = line.indexOf(")", c);
+ String provide = line.substring(c + 14, c2 - 1);
+ fi.provides.add(provide);
+ }
numProvides++;
}
else
@@ -865,6 +877,7 @@ public class GoogDepsWriter {
public ArrayList<String> impls;
public ArrayList<String> deps;
public ArrayList<String> staticDeps;
+ public ArrayList<String> provides;
public int constructorLine;
public int depsLine;
public int suppressLine;
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/3f9ed83d/compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSPackage.java
----------------------------------------------------------------------
diff --git a/compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSPackage.java b/compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSPackage.java
index 9e94828..01932d0 100644
--- a/compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSPackage.java
+++ b/compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSPackage.java
@@ -434,6 +434,7 @@ public class TestFlexJSPackage extends TestGoogPackage
" */\n" +
"\n" +
"goog.provide('foo.bar.baz.A');\n" +
+ "goog.provide('foo.bar.baz.A.InternalClass');\n" +
"\n" +
"\n" +
"\n" +
@@ -538,6 +539,7 @@ public class TestFlexJSPackage extends TestGoogPackage
" */\n" +
"\n" +
"goog.provide('foo.bar.baz.A');\n" +
+ "goog.provide('foo.bar.baz.A.internalFunction');\n" +
"\n" +
"\n" +
"\n" +
@@ -606,6 +608,7 @@ public class TestFlexJSPackage extends TestGoogPackage
" */\n" +
"\n" +
"goog.provide('foo.bar.baz.A');\n" +
+ "goog.provide('foo.bar.baz.A.internalVar');\n" +
"\n" +
"\n" +
"\n" +
@@ -686,6 +689,7 @@ public class TestFlexJSPackage extends TestGoogPackage
" */\n" +
"\n" +
"goog.provide('foo.bar.baz.A');\n" +
+ "goog.provide('foo.bar.baz.A.InternalClass');\n" +
"\n" +
"\n" +
"\n" +
@@ -838,6 +842,7 @@ public class TestFlexJSPackage extends TestGoogPackage
" */\n" +
"\n" +
"goog.provide('foo.bar.baz.A');\n" +
+ "goog.provide('foo.bar.baz.A.InternalClass');\n" +
"\n" +
"\n" +
"\n" +
@@ -995,6 +1000,8 @@ public class TestFlexJSPackage extends TestGoogPackage
" */\n" +
"\n" +
"goog.provide('foo.bar.baz.A');\n" +
+ "goog.provide('foo.bar.baz.A.InternalClass');\n" +
+ "goog.provide('foo.bar.baz.A.ITestInterface');\n" +
"\n" +
"\n" +
"\n" +
@@ -1153,6 +1160,7 @@ public class TestFlexJSPackage extends TestGoogPackage
" */\n" +
"\n" +
"goog.provide('foo.bar.A');\n" +
+ "goog.provide('foo.bar.A.Internal');\n" +
"\n" +
"\n" +
"\n" +
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/3f9ed83d/compiler-jx/src/test/resources/flexjs/projects/internal/MainClass_result.js
----------------------------------------------------------------------
diff --git a/compiler-jx/src/test/resources/flexjs/projects/internal/MainClass_result.js b/compiler-jx/src/test/resources/flexjs/projects/internal/MainClass_result.js
index a96b203..c1f9dd7 100644
--- a/compiler-jx/src/test/resources/flexjs/projects/internal/MainClass_result.js
+++ b/compiler-jx/src/test/resources/flexjs/projects/internal/MainClass_result.js
@@ -20,6 +20,7 @@
*/
goog.provide('MainClass');
+goog.provide('MainClass.InternalClass');
goog.require('OtherClass');
[7/7] git commit: [flex-falcon] [refs/heads/dual] - Merge branch
'develop' into dual
Posted by ah...@apache.org.
Merge branch 'develop' into dual
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/8dd7f9c3
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/8dd7f9c3
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/8dd7f9c3
Branch: refs/heads/dual
Commit: 8dd7f9c3064ac929440c02f631366d41920a43cc
Parents: 55d9fcf 7137de6
Author: Alex Harui <ah...@apache.org>
Authored: Sun Apr 30 19:57:52 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Sun Apr 30 19:57:52 2017 -0700
----------------------------------------------------------------------
.../codegen/js/flexjs/JSFlexJSEmitter.java | 2 +-
.../codegen/js/jx/PackageHeaderEmitter.java | 24 ++++++++++++++++++++
.../compiler/internal/graph/GoogDepsWriter.java | 15 +++++++++++-
.../apache/flex/compiler/utils/NativeUtils.java | 1 +
.../codegen/js/flexjs/TestFlexJSPackage.java | 8 +++++++
.../projects/internal/MainClass_result.js | 1 +
.../semantics/MethodBodySemanticChecker.java | 11 +++++----
.../internal/tree/as/ExpressionNodeBase.java | 6 +++++
8 files changed, 61 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/8dd7f9c3/compiler-jx/src/main/java/org/apache/flex/compiler/internal/graph/GoogDepsWriter.java
----------------------------------------------------------------------
[3/7] git commit: [flex-falcon] [refs/heads/dual] - keep native
classes out of static dependency list
Posted by ah...@apache.org.
keep native classes out of static dependency list
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/153b51e2
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/153b51e2
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/153b51e2
Branch: refs/heads/dual
Commit: 153b51e24caa89e04e913d98e8e633f772247053
Parents: 27aa1dc
Author: Alex Harui <ah...@apache.org>
Authored: Thu Apr 20 20:12:57 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Thu Apr 20 20:12:57 2017 -0700
----------------------------------------------------------------------
.../flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/153b51e2/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java
----------------------------------------------------------------------
diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java
index 2c2050a..897408f 100644
--- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java
+++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/flexjs/JSFlexJSEmitter.java
@@ -548,7 +548,7 @@ public class JSFlexJSEmitter extends JSGoogEmitter implements IJSFlexJSEmitter
else if (!isDoc)
{
if (getModel().inStaticInitializer)
- if (!staticUsedNames.contains(name))
+ if (!staticUsedNames.contains(name) && !NativeUtils.isJSNative(name))
staticUsedNames.add(name);
if (!usedNames.contains(name))
[4/7] git commit: [flex-falcon] [refs/heads/dual] - Added RegExp to
native JS types
Posted by ah...@apache.org.
Added RegExp to native JS types
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/e11cf7ee
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/e11cf7ee
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/e11cf7ee
Branch: refs/heads/dual
Commit: e11cf7eee2258e1c21bd1193c7692427eb5b2b86
Parents: 153b51e
Author: Harbs <ha...@in-tools.com>
Authored: Thu Apr 20 23:43:53 2017 -0400
Committer: Harbs <ha...@in-tools.com>
Committed: Thu Apr 20 23:43:53 2017 -0400
----------------------------------------------------------------------
.../src/main/java/org/apache/flex/compiler/utils/NativeUtils.java | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/e11cf7ee/compiler-jx/src/main/java/org/apache/flex/compiler/utils/NativeUtils.java
----------------------------------------------------------------------
diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/utils/NativeUtils.java b/compiler-jx/src/main/java/org/apache/flex/compiler/utils/NativeUtils.java
index 4969a3d..6a493b2 100644
--- a/compiler-jx/src/main/java/org/apache/flex/compiler/utils/NativeUtils.java
+++ b/compiler-jx/src/main/java/org/apache/flex/compiler/utils/NativeUtils.java
@@ -91,6 +91,7 @@ public class NativeUtils
NaN("NaN"),
Event("Event"),
Array("Array"),
+ RegExp("RegExp"),
Float32Array("Float32Array"),
Float64Array("Float64Array"),
Int8Array("Int8Array"),
[6/7] git commit: [flex-falcon] [refs/heads/dual] - hashmaps iterate
in different orders on different Java versions,
so sort the list so tests will ass
Posted by ah...@apache.org.
hashmaps iterate in different orders on different Java versions, so sort the list so tests will ass
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/7137de6b
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/7137de6b
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/7137de6b
Branch: refs/heads/dual
Commit: 7137de6b19cd11630ee1ef29f7a9164166e35b10
Parents: 3f9ed83
Author: Alex Harui <ah...@apache.org>
Authored: Mon Apr 24 00:17:35 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Mon Apr 24 00:17:35 2017 -0700
----------------------------------------------------------------------
.../compiler/internal/codegen/js/jx/PackageHeaderEmitter.java | 6 ++++++
.../compiler/internal/codegen/js/flexjs/TestFlexJSPackage.java | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/7137de6b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/PackageHeaderEmitter.java
----------------------------------------------------------------------
diff --git a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/PackageHeaderEmitter.java b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/PackageHeaderEmitter.java
index 5c9c91c..0f1d0cd 100644
--- a/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/PackageHeaderEmitter.java
+++ b/compiler-jx/src/main/java/org/apache/flex/compiler/internal/codegen/js/jx/PackageHeaderEmitter.java
@@ -154,8 +154,14 @@ public class PackageHeaderEmitter extends JSSubEmitter implements
HashMap<String, String> internalClasses = getEmitter().getModel().getInternalClasses();
if (internalClasses.size() > 0)
{
+ ArrayList<String> classesInOrder = new ArrayList<String>();
for (String internalClass : internalClasses.keySet())
{
+ classesInOrder.add(internalClass);
+ }
+ Collections.sort(classesInOrder);
+ for (String internalClass : classesInOrder)
+ {
/* goog.provide('x');\n\n */
write(JSGoogEmitterTokens.GOOG_PROVIDE);
write(ASEmitterTokens.PAREN_OPEN);
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/7137de6b/compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSPackage.java
----------------------------------------------------------------------
diff --git a/compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSPackage.java b/compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSPackage.java
index 01932d0..f9afc81 100644
--- a/compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSPackage.java
+++ b/compiler-jx/src/test/java/org/apache/flex/compiler/internal/codegen/js/flexjs/TestFlexJSPackage.java
@@ -1000,8 +1000,8 @@ public class TestFlexJSPackage extends TestGoogPackage
" */\n" +
"\n" +
"goog.provide('foo.bar.baz.A');\n" +
- "goog.provide('foo.bar.baz.A.InternalClass');\n" +
"goog.provide('foo.bar.baz.A.ITestInterface');\n" +
+ "goog.provide('foo.bar.baz.A.InternalClass');\n" +
"\n" +
"\n" +
"\n" +
[2/7] git commit: [flex-falcon] [refs/heads/dual] - accept toString
always. JS compiles don't have it defined on Object because then
int.toString(radix) reports an illegal override
Posted by ah...@apache.org.
accept toString always. JS compiles don't have it defined on Object because then int.toString(radix) reports an illegal override
Project: http://git-wip-us.apache.org/repos/asf/flex-falcon/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-falcon/commit/27aa1dc0
Tree: http://git-wip-us.apache.org/repos/asf/flex-falcon/tree/27aa1dc0
Diff: http://git-wip-us.apache.org/repos/asf/flex-falcon/diff/27aa1dc0
Branch: refs/heads/dual
Commit: 27aa1dc0776e925f834f59ef9be91a0427ed167c
Parents: 5ffbc25
Author: Alex Harui <ah...@apache.org>
Authored: Thu Apr 20 19:51:12 2017 -0700
Committer: Alex Harui <ah...@apache.org>
Committed: Thu Apr 20 19:51:12 2017 -0700
----------------------------------------------------------------------
.../internal/semantics/MethodBodySemanticChecker.java | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-falcon/blob/27aa1dc0/compiler/src/main/java/org/apache/flex/compiler/internal/semantics/MethodBodySemanticChecker.java
----------------------------------------------------------------------
diff --git a/compiler/src/main/java/org/apache/flex/compiler/internal/semantics/MethodBodySemanticChecker.java b/compiler/src/main/java/org/apache/flex/compiler/internal/semantics/MethodBodySemanticChecker.java
index 3904823..a20d4de 100644
--- a/compiler/src/main/java/org/apache/flex/compiler/internal/semantics/MethodBodySemanticChecker.java
+++ b/compiler/src/main/java/org/apache/flex/compiler/internal/semantics/MethodBodySemanticChecker.java
@@ -828,11 +828,12 @@ public class MethodBodySemanticChecker
{
if ( utils.isInaccessible(iNode, method_binding) )
{
- addProblem(new InaccessibleMethodReferenceProblem(
- roundUpUsualSuspects(method_binding, iNode),
- method_binding.getName().getBaseName(),
- utils.getTypeOfStem(iNode)
- ));
+ if (!method_binding.getName().getBaseName().equals("toString"))
+ addProblem(new InaccessibleMethodReferenceProblem(
+ roundUpUsualSuspects(method_binding, iNode),
+ method_binding.getName().getBaseName(),
+ utils.getTypeOfStem(iNode)
+ ));
}
else if ( SemanticUtils.hasExplicitStem(iNode) && utils.hasUnderlyingType(iNode) )
{