You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2022/11/09 09:16:47 UTC
[GitHub] [incubator-livy] moritzmeister opened a new pull request, #322: [LIVY-863] Missing JVM class imports for Spark3
moritzmeister opened a new pull request, #322:
URL: https://github.com/apache/incubator-livy/pull/322
## What changes were proposed in this pull request?
Description of the problem: https://issues.apache.org/jira/browse/LIVY-863
The proposed fix consists of adding the missing imports that upstream Spark has when it's initiating the Java Gateway.
See the imports of Spark here: https://github.com/apache/spark/blob/87bf6b0ea4ca0618c8604895d05037edce8b7cb0/python/pyspark/java_gateway.py#L153
As far as I am aware, the `java_import()` does not fail or fails silently if the imported class does not exist.
But I might need to add some code to account for different Spark versions, looking for some guidance on this.
## How was this patch tested?
If you could please provide some guidance where to add tests for this, I am happy to add them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] yantzu closed pull request #322: [LIVY-863] Missing JVM class imports for Spark3
Posted by GitBox <gi...@apache.org>.
yantzu closed pull request #322: [LIVY-863] Missing JVM class imports for Spark3
URL: https://github.com/apache/incubator-livy/pull/322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-livy] yantzu commented on pull request #322: [LIVY-863] Missing JVM class imports for Spark3
Posted by GitBox <gi...@apache.org>.
yantzu commented on PR #322:
URL: https://github.com/apache/incubator-livy/pull/322#issuecomment-1308449357
Retrigger the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [LIVY-863] Missing JVM class imports for Spark3 [incubator-livy]
Posted by "lmccay (via GitHub)" <gi...@apache.org>.
lmccay commented on PR #322:
URL: https://github.com/apache/incubator-livy/pull/322#issuecomment-1951396188
@moritzmeister - did you try adding a bogus import to see whether your assumption about it failing silently is true?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@livy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org