You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/08 05:27:05 UTC

[GitHub] [airflow] uranusjr commented on issue #20116: BaseOperator.get_task_instances is broken due to order by TaskInstance.execution_date

uranusjr commented on issue #20116:
URL: https://github.com/apache/airflow/issues/20116#issuecomment-988511457


   > This is *meant* to be a backwards compatibility shim
   
   Not really, the function has not been touched (except to apply Black) in three years, and is not used at all in the code base, and therefore alluded attention during the `run_id` migration.
   
   ----
   
   Feel free to submit a pull request for this. The fix should join DagRun on TaskInstance on `run_id`, and order the result by `DagRun.execution_date` instead. You should be able to find some examples in the code base by searching for `order_by(DagRun.execution_date)`. A test would be needed as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org